Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp67685imm; Fri, 31 Aug 2018 17:34:13 -0700 (PDT) X-Google-Smtp-Source: ANB0VdY5jswWAijXiqjFNWqiMd0hiCve7D/wRFhWJsBl4/ONCXU0j6g7dV/MIEUyqMilBYYVlOT+ X-Received: by 2002:a65:6455:: with SMTP id s21-v6mr16917796pgv.25.1535762052943; Fri, 31 Aug 2018 17:34:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535762052; cv=none; d=google.com; s=arc-20160816; b=msB538oOMWhvEuPA1CmUMspjOjwFUnKtJwerCzWXC5k80ZXAP0USLYQKkGV4S2reIM Mh257QpffOEwz+yAwbo4HeBpaJrFowPJjvWQ2bOHf5NctDWM+epBAdz7yTjstz2H+kVQ egf3IeKKyGVl97+t4fZprN1iJ3+n4UEOkzOO9U39ipYoF01I2znHwgGFPkBrbyieCYBI +9FpPipHsp1uqnytCMQFXCz9V2bOM2mCB8OJNdrKkiEQkzAbB0zeaL1JfaqELAcrO/Cy KNqjKQe1FcY9Mmf2Jbn1uFQkRa06N3YymwQuhpHCi4oLLAP+OpWPDVSkJ3V3Nnfqe2hB cDSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=AWdzujc9EZFcPTJnRiI7cTrZ1EeyIfooBNTWwxNkX1I=; b=T3y0rhp7nriYAvUbNRmHaOwTuWEfzeyIaUo1GnHYN5H/cL9wnj+qyJXrbv+SORc2NR 0oJPgCfNOEcy+zn3JFp/G2wJWGP1EZNipCRS6ZcQhqZLsrg/AXV8Daw0xcdzVIt9IWHL c1sm2xtN9Cj7tlu6DBlU2ps7kiH4wKu8lzQHUmbWjYEdEN53J1ZZEf+qFyHu8gHlEtbU dEsq3lV65udPlXWsbjCO8tKAbZ2EZPhkb9wRKhp8NlZ40VvmU6FIonB/qD8u24Ve/FSf WIFDqbN33xuvn/Fi0aJVBWtyVTYqTKBK5ZVJnVQVx8LqcbtoH2YD2k2vvOV9A6zmuI6C 53lw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=C9V3DeVq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f10-v6si11078814pgk.367.2018.08.31.17.33.58; Fri, 31 Aug 2018 17:34:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=C9V3DeVq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727635AbeIAEmw (ORCPT + 99 others); Sat, 1 Sep 2018 00:42:52 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:35977 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725988AbeIAEmv (ORCPT ); Sat, 1 Sep 2018 00:42:51 -0400 Received: by mail-pg1-f193.google.com with SMTP id d1-v6so6131844pgo.3; Fri, 31 Aug 2018 17:32:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=AWdzujc9EZFcPTJnRiI7cTrZ1EeyIfooBNTWwxNkX1I=; b=C9V3DeVq0q4cwKU4sNcX7iDGR88OyavwgK2WBmo/moPlNeVbGk3ru7PVP1I62cQjag hq3WzBPOCy1vGXA1gJ1vn9Nd/5FKi//LdHT1keS7DCf0daY8kdxuLFwbnK3BWgT9tJT/ EbuXE1ZcZbF5Gp8qltGR4eKfTX4fSDVx8c9ePcJXKuTJIbMgrlguX0UL5yy30vnHo/MG WUiCW5YfM2yP5xLwHqr5UyPEx+hI2Hh9P+navxeCf+5szlUvCyCp9COnmBWYfANehBK4 rysbBTqn1pfg9GrqZNZ0S6hddkoW0hqW4mj/QO8X8s7gyVn/30ZwHJkQKecRlqXL9N4r nMKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=AWdzujc9EZFcPTJnRiI7cTrZ1EeyIfooBNTWwxNkX1I=; b=cv38aGg0OJ8p0x4C+ofvIzGnt9aCHajG2APqUMim6r8cpeIPEPbkUIobyY8D2UGnpy SYmfVspGeiNfFtpBv0f1O7R9OYSHqJ4N7IrTSw+zJSgYexkj3BQlzhnJUdf4Y0B0UdaV aGZFhaJXzpP5lQ2u6ZeYmib5EaudFFDpGvD9R6qNva5bJznodrUTzw/omSRsX7+ubCzd HkKSJBcpMsApZH4YnbYU1ENHsdCPq3XKtgA0tQnI1mMmolSB6IHJ3w/mL5sVwnlnvtey urQMdXqNA9kJnu3FyndPUgUotl2STgSnRbZaV4hwN83FbYhj6YWg7bO117GPT62yYTbv C7qw== X-Gm-Message-State: APzg51DbPNwPOkZHyie4P2TzxEQhsovYkTcOIux0WW9IGElayB4/VctB sG5h2fWSEiRnl59WwGX1Wjs= X-Received: by 2002:aa7:818f:: with SMTP id g15-v6mr18377851pfi.71.1535761973534; Fri, 31 Aug 2018 17:32:53 -0700 (PDT) Received: from localhost ([2620:10d:c090:180::1:a245]) by smtp.gmail.com with ESMTPSA id p4-v6sm20532703pgs.75.2018.08.31.17.32.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 Aug 2018 17:32:52 -0700 (PDT) Date: Fri, 31 Aug 2018 17:32:50 -0700 From: Tejun Heo To: Dennis Zhou Cc: Jens Axboe , Johannes Weiner , Josef Bacik , kernel-team@fb.com, linux-block@vger.kernel.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 14/15] blkcg: rename blkg_try_get to blkg_tryget Message-ID: <20180901003250.GL1488037@devbig004.ftw2.facebook.com> References: <20180831015356.69796-1-dennisszhou@gmail.com> <20180831015356.69796-15-dennisszhou@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180831015356.69796-15-dennisszhou@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 30, 2018 at 09:53:55PM -0400, Dennis Zhou wrote: > From: "Dennis Zhou (Facebook)" > > blkg reference counting now uses percpu_ref rather than atomic_t. Let's > make this consistent with css_tryget. This renames blkg_try_get to > blkg_tryget and now returns a bool rather than the blkg or NULL. > > Signed-off-by: Dennis Zhou Acked-by: Tejun Heo Thanks. -- tejun