Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
To:     Jia-Ju Bai <baijiaju1990@gmail.com>, airlied@linux.ie,
        gustavo@padovan.org, maarten.lankhorst@linux.intel.com,
        seanpaul@chromium.org
From:   Chris Wilson <chris@chris-wilson.co.uk>
In-Reply-To: <20180901122041.2357-1-baijiaju1990@gmail.com>
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Jia-Ju Bai <baijiaju1990@gmail.com>
References: <20180901122041.2357-1-baijiaju1990@gmail.com>
Message-ID: <153580517420.12034.2035309606925619207@skylake-alporthouse-com>
User-Agent: alot/0.6
Subject: Re: [PATCH] gpu: drm: drm_mm: Fix a sleep-in-atomic-context bug in
 show_leaks()
Date:   Sat, 01 Sep 2018 13:32:54 +0100
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Jia-Ju Bai (2018-09-01 13:20:41)
> The driver may sleep with holding a spinlock.
> 
> The function call paths (from bottom to top) in Linux-4.16 are:
> 
> [FUNC] kmalloc(GFP_KERNEL)
> drivers/gpu/drm/drm_mm.c, 130: 
>         kmalloc in show_leaks
> drivers/gpu/drm/drm_mm.c, 913: 
>         show_leaks in drm_mm_takedown
> drivers/gpu/drm/drm_vma_manager.c, 107: 
>         drm_mm_takedown in drm_vma_offset_manager_destroy
> drivers/gpu/drm/drm_vma_manager.c, 106: 
>         _raw_write_lock in drm_vma_offset_manager_destroy
> 
> [FUNC] kmalloc(GFP_KERNEL)
> drivers/gpu/drm/drm_mm.c, 130: 
>         kmalloc in show_leaks
> drivers/gpu/drm/drm_mm.c, 913: 
>         show_leaks in drm_mm_takedown
> drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c, 71: 
>         drm_mm_takedown in amdgpu_vram_mgr_fini
> drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c, 70: 
>         spin_lock in amdgpu_vram_mgr_fini
> 
> [FUNC] kmalloc(GFP_KERNEL)
> drivers/gpu/drm/drm_mm.c, 130: 
>         kmalloc in show_leaks
> drivers/gpu/drm/drm_mm.c, 913: 
>         show_leaks in drm_mm_takedown
> drivers/gpu/drm/ttm/ttm_bo_manager.c, 128: 
>         drm_mm_takedown in ttm_bo_man_takedown
> drivers/gpu/drm/ttm/ttm_bo_manager.c, 126: 
>         spin_lock in ttm_bo_man_takedown
> 
> To fix this bug, GFP_KERNEL is replaced with GFP_ATOMIC.

The bug are above, since those spinlocks do not protect the data and
imply use-after-free.
-Chris