Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180901095639.ms6kkzywazkvs376@ltop.local>
References: <20180831170514.24665-1-miguel.ojeda.sandonis@gmail.com>
 <20180831170514.24665-7-miguel.ojeda.sandonis@gmail.com> <20180901095639.ms6kkzywazkvs376@ltop.local>
From:   Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date:   Sat, 1 Sep 2018 14:58:44 +0200
Message-ID: <CANiq72nrWMtCTNhMUCRjOPY2u0x78w8Hig2GcKf6WPyo5xkZeA@mail.gmail.com>
Subject: Re: [PATCH 7/7] Compiler Attributes: use feature checks instead of
 version checks
To:     Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc:     Linus Torvalds <torvalds@linux-foundation.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Eli Friedman <efriedma@codeaurora.org>,
        Christopher Li <sparse@chrisli.org>,
        Kees Cook <keescook@chromium.org>,
        Ingo Molnar <mingo@kernel.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        Joe Perches <joe@perches.com>,
        Dominique Martinet <asmadeus@codewreck.org>,
        Nick Desaulniers <ndesaulniers@google.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Luc,

On Sat, Sep 1, 2018 at 11:56 AM, Luc Van Oostenryck
<luc.vanoostenryck@gmail.com> wrote:
>
> For sparse (which doesn't support __has_attribute() yet and defines
> __GNUC_MINOR__ depending on the compiler used to build it) it won't
> be totally correct since the concerned attributes here will be
> incorrectly considered as not supported. But, since these attributes
> have no semantic effects for sparse, it won't matter.
>
> So, for sparse:
> Reviewed-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>

Thanks for checking (and for the sparse patches too!). I will note
this in the commit message for v3.

Cheers,
Miguel