Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/1] Update AMD cpu microcode for family 15h
From:   Rudolf Marek <r.marek@assembler.cz>
To:     "Hurwitz, Sherry" <sherry.hurwitz@amd.com>,
        Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
        Ivan Ivanov <qmastery16@gmail.com>
Cc:     Josh Boyer <jwboyer@kernel.org>,
        Linux Firmware <linux-firmware@kernel.org>,
        "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
        "Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com>,
        "Lendacky, Thomas" <Thomas.Lendacky@amd.com>,
        "Grimm, Jon" <Jon.Grimm@amd.com>
References: <1527213479-121361-1-git-send-email-sherry.hurwitz@amd.com>
 <CA+5PVA7aPRHk=kfxsmPi-qStKEnK_HJ=rTjvtQGO1QbnLb9qBw@mail.gmail.com>
 <CAAaskFAGRUU3APZbsY2w9hW9jbBJfeMbHt8ttg7vXHidp025=g@mail.gmail.com>
 <20180531220503.2jqs3oiqsnw7ye2t@khazad-dum.debian.net>
 <6402a30f-04d3-59d9-92df-5a43e2060f5c@assembler.cz>
 <MWHPR1201MB2526CF0F174938EA64156AE98B660@MWHPR1201MB2526.namprd12.prod.outlook.com>
 <b01e8484-17e6-5253-5d83-9d864c66a7f9@assembler.cz>
Openpgp: preference=signencrypt
Autocrypt: addr=r.marek@assembler.cz; prefer-encrypt=mutual; keydata=
 xsBNBFN2VH4BCADpv+3Tkikr+X489Xso9UC719YdxgGiy0xBjDiWC22wAd3tHy6G3nEhWfh4
 1UNGcqscPAvJMn2GhgSJRfBzj0wALXLkoTYta78wEK+Ji+Gs7PX9VhqRKt9/OIn/2XJ1Yv9i
 e8uo9MFBGFCB5roz+Ws8rdXq0Quu7VZylzRv7qqhxMAk9RvXCT2tyt6XY16R7ZEL9wbSLRAl
 h8LRPMF0iiLH1YenfSCX2XkW7eA7CJSjh9pwIBFOF5cd5mcT69OPO+TuAbdvgCcZPEoQQBhk
 QmOr2PlUOl3CSgqtTxjAjAxXhPTU7Q3xxgB2Oa7xbt3Eic2Z4lltP/dowULZqXvsC5DxABEB
 AAHNI1J1ZG9sZiBNYXJlayA8ci5tYXJla0Bhc3NlbWJsZXIuY3o+wsB+BBMBAgAoBQJTdlR+
 AhsjBQkJZgGABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDAb22rZM9dcMf1B/97PHhB
 YaPoM4PHlk3o3HEs0ZxiJyVqDLpmM8kOh+Pcvb40KX0uebiODfeff+RYJWOff27la7AzqG20
 dEAi3hpHYVigZWf3BaLXwCbUKlyLLydks4qydfKBG62PnM74sW1M/sfFA/bdzC9tnjy4G9r9
 mXNBJBDHb4XuHeukqlrMLDDGW78wrfv4tjtW9Z3Aoroja9CnxREt6c3iHA50TX65BrthPxhF
 c+ES+4J/uuBe6pfq9PN8HZKBWgK+jhCoyCajck964ccVF1a2uTRhN39gXtA2YpKUqb+dcsp+
 2NH2eBVYZYaPVJIoIWPxhriOHszs+NjOkk+jBw2gVLy4bmOlzsBNBFN2VH4BCADsg91uA/mm
 l6APO+aWyqkiPjENreT2DT2gmoaEkp07jZrzNcQrLyNhGhsH6+UtCJLV9YNHbfJb7wsfXmXh
 IRh+TQYLJlrU4tBqvVB0F24+MEAFdt/1/jAmaihRZWKdE/Ogtt0YV7BEKfJk2KZxrG4wLB4G
 g57kI+aVmoVRl7/WmM46JpOJhBqvI6/Pw/ZIDhJZfrOXCCWM3pYjx0ftkkULPl6E6dXv3V7N
 9dMV4bqNj4PDfysptFoVo02AblHqMmmBQ2LcI+o5HNm2iPyTklKMmq8Z5kblXDR6GXe2rO5c
 5j0vQ6q5uSyVa30JNJcfl2iUT2akFv7n+RRWhlyCItjpABEBAAHCwGUEGAECAA8FAlN2VH4C
 GwwFCQlmAYAACgkQwG9tq2TPXXAq4Af/UhDBiEaW/s1gDmtci6ZBTDetOdWGx69dzD2rIm1b
 OoQiO1EZ+WNFe0RFmMByfCsRVXP4iD/Ly1l0c6ZNvCBPR+ssXlnltE0Z1S43ZrR4gYjWw2GM
 y1EcSOLv6Yvt/+8IS6YANlzR6RRBs2pM1ndM2AhI43k2rpGFarNEX7z9QrdcoZ4rY94DUGwZ
 0hlQ5VrGt/DAnMkJmOkr6Yriiybw8COnw4qigLfZH6b87vUqdBjRr3BR0iD3ahiXUY0bhlX2
 bQE1IdT8+enQsm4+ePcC8Oihl8Y9JI/cBCw3eEZOl2p1+8aRq7tGkLsilWXUCDJ2kCDQixCJ
 RoTzi/gSro2qhg==
Message-ID: <05d222ba-768f-5095-cc7a-f48fc8b3154f@assembler.cz>
Date:   Sat, 1 Sep 2018 19:09:47 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <b01e8484-17e6-5253-5d83-9d864c66a7f9@assembler.cz>
Content-Type:   text/plain; charset=US-ASCII
Content-Language: en-US
Content-Transfer-Encoding: 7BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi again,

Here is a short summary of what is missing in the microcode containers [1] [2]. I only included AMD family 15h and 17h.
Similar could be done for Intel CPUs. 

I do believe having a latest microcode is a vital for the userspace security because it provides
IBPB barrier.

Family 15h [1] container parsed with [4] (with some lines omitted)

-- Processor Signature:       : 0x00600f20
-- Processor Revision ID:     : 0x00006020

-- Processor Signature:       : 0x00610f01
-- Processor Revision ID:     : 0x00006101

-- Processor Signature:       : 0x00600f12
-- Processor Revision ID:     : 0x00006012

Contains following microcodes:

| # | eqrev| urev     |    date    | latest|
| 1 | 6012 | 0600063E | 2018/02/07 |  yes  |
| 2 | 6020 | 06000852 | 2018/02/06 |  yes  |
| 3 | 6101 | 06001119 | 2012/07/13 |  no   |

Note the #3 is what I have been complaining about.

Family 17h [2] parsed with [4]

The container seems to include the equivalent versions for various CPUs (not even a family17h) but only a microcode for a "Naples/EPYC" chips.

Container Processor Signature Table: 
-- Processor Signature:       : 0x00600f20 (not even a fam17h)
-- Processor Revision ID:     : 0x00006020

-- Processor Signature:       : 0x00610f01 (not even a fam17h)
-- Processor Revision ID:     : 0x00006101

-- Processor Signature:       : 0x00700f01 (not even a fam17h)
-- Processor Revision ID:     : 0x00007001

-- Processor Signature:       : 0x00800f12 (update is OK)
-- Processor Revision ID:     : 0x00008012

-- Processor Signature:       : 0x00800f11 (update is missing!)
-- Processor Revision ID:     : 0x00008011

-- Processor Signature:       : 0x00600f12 (not even a fam17h)
-- Processor Revision ID:     : 0x00006012

-- Processor Signature:       : 0x00800f13 (future CPU?)
-- Processor Revision ID:     : 0x00008013

-- Processor Signature:       : 0x00800f00 (perhaps ES?)
-- Processor Revision ID:     : 0x00008000

Microcode Type:               : 0x00000001
Microcode Size:               : 0x00000c80
Date                          : 2018/02/09
Patch ID                      : 0x08001227
Patch Data ID                 : 0x00008004

| # | eqrev| urev     |    date    | latest|
| 1 | 8004 | 08001227 | 2018/02/09 | yes   |

It misses microcode update for 00800F11 - latest known should be 2018/02/14 and for other CPUs like Pinacle Ridge 00800F82 - latest known should be 2018/02/12
Or Ryzen mobile 00810F10 etc...

Thanks
Rudolf

Resources used to construct this tables:

[1] https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/amd-ucode/microcode_amd_fam15h.bin
[2] https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/amd-ucode/microcode_amd_fam17h.bin
[3] http://users.atw.hu/instlatx64/
[4] https://github.com/ddcc/microparse