Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp795424imm;
        Sat, 1 Sep 2018 22:29:54 -0700 (PDT)
X-Google-Smtp-Source: ANB0VdY0zwismKnm17QwyU/3PBtcQX8Wx5xgjvLaYbudrcmIqlN+xo+VsRqBocbRisyPN5dAgOD1
X-Received: by 2002:a63:d613:: with SMTP id q19-v6mr21228544pgg.327.1535866193994;
        Sat, 01 Sep 2018 22:29:53 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1535866193; cv=none;
        d=google.com; s=arc-20160816;
        b=J9JMumhFaWbJTlbUHCxYXX+2AWfKxCAbAi0wyLPa+H7gDThSrpz5kulC+fL+WEBnKA
         xevIPYuIGuOm/Z4HPJFdZ4IPf18Ab9Ql2E+J3s4LKxTXmJwFqd59aDvqOXjp45Vu5AON
         t9+fcD7TqVwhoI0Ez1RXPV/4AzGwM7ztafZ8V9EVAgy1lQP/HkGNo3l1eeByl+oq69NH
         m4PbH/LDOklOasAA20SvFl3htBaRoCWaAegFInSQNKt1vwC6RhZpWdvYj/PUD6ajN21y
         0215HDZzBccXyMK3FAVvHIwuIxNGojtFZYnJP5HoRlcft9wOLuHxPXpZNuxrGh9TtGBe
         ET/Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date
         :arc-authentication-results;
        bh=QdhLeUK8W8PHpSgO+9eb/L5E9AErbdMpaUtAPqietqM=;
        b=iRHLX+e2hUaI/eXoPfn38iVpo4PkNFqw6IIjhSYMeq8xlaoTdPo5JYX8gAHxY+Io1R
         2wtrSQksv2SMQgzCLPKVMfV72mVjK+ajKbRVPfBFvpqXoTGdpUG2QQx5omryGDekknEr
         oKMVOCVQWQYI1hUQd3OhVgk6jixNTuRyMloWObpNm9pQGuiIQwbkvnYKxCQybxXmlqIr
         vQdkrf8QqZVZJwejvwBSWHEEj69wecSb2lmLck/VCZW7CojLrf2ZbNRUqaN933bzRyLm
         YM1GxEkT3M/msYOVz4qkdaWov+LbGqxY3SdMcT/ZdXQPxW5nVDPcInbTDk7kQFDGtsY8
         HhAw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id x24-v6si14382459pgh.295.2018.09.01.22.29.26;
        Sat, 01 Sep 2018 22:29:53 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726711AbeIBJmK (ORCPT <rfc822;linuxbirdgao@gmail.com>
        + 99 others); Sun, 2 Sep 2018 05:42:10 -0400
Received: from shards.monkeyblade.net ([23.128.96.9]:56058 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725993AbeIBJmK (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 2 Sep 2018 05:42:10 -0400
Received: from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net [74.93.104.98])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 45262143D0E2D;
        Sat,  1 Sep 2018 22:27:39 -0700 (PDT)
Date:   Sat, 01 Sep 2018 22:27:38 -0700 (PDT)
Message-Id: <20180901.222738.2092199274760750174.davem@davemloft.net>
To:     stefan.wahren@i2se.com
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: qca_spi: Fix race condition in spi transfers
From:   David Miller <davem@davemloft.net>
In-Reply-To: <1535719981-20812-1-git-send-email-stefan.wahren@i2se.com>
References: <1535719981-20812-1-git-send-email-stefan.wahren@i2se.com>
X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 01 Sep 2018 22:27:39 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Stefan Wahren <stefan.wahren@i2se.com>
Date: Fri, 31 Aug 2018 14:53:01 +0200

> The performance optimization with the prepared spi messages
> also introduced a race condition between the kernel thread
> and the register dump. This could make spi_sync hang forever.
> 
> So revert the optimization completely.
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>

Please resubmit this patch with a better commit message, explaining in
more detail what the race is exactly.

Thank you.