Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263267AbTKEWxr (ORCPT ); Wed, 5 Nov 2003 17:53:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263271AbTKEWxr (ORCPT ); Wed, 5 Nov 2003 17:53:47 -0500 Received: from modemcable137.219-201-24.mc.videotron.ca ([24.201.219.137]:12416 "EHLO montezuma.fsmlabs.com") by vger.kernel.org with ESMTP id S263267AbTKEWxq (ORCPT ); Wed, 5 Nov 2003 17:53:46 -0500 Date: Wed, 5 Nov 2003 17:53:11 -0500 (EST) From: Zwane Mwaikambo To: Chad Kitching cc: linux-kernel@vger.kernel.org Subject: RE: BK2CVS problem In-Reply-To: <18DFD6B776308241A200853F3F83D507169CBC@pl6w2kex.lan.powerlandcomputers.com> Message-ID: References: <18DFD6B776308241A200853F3F83D507169CBC@pl6w2kex.lan.powerlandcomputers.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 737 Lines: 20 On Wed, 5 Nov 2003, Chad Kitching wrote: > From: Zwane Mwaikambo > > > + if ((options == (__WCLONE|__WALL)) && (current->uid = 0)) > > > + retval = -EINVAL; > > > > That looks odd > > > > Setting current->uid to zero when options __WCLONE and __WALL are set? The > retval is dead code because of the next line, but it looks like an attempt > to backdoor the kernel, does it not? Yes, i was more meaning to say 'that looks like fun', good times, good times. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/