Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp841220imm; Sun, 2 Sep 2018 00:31:43 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYZuXju/nvJ1SowrpRWQiOcO5JSfmLfGz5fh8cK3lWzVHX3f6h07v4C5ANc6jk00P9iGSwc X-Received: by 2002:a63:788b:: with SMTP id t133-v6mr21116250pgc.329.1535873413542; Sun, 02 Sep 2018 00:30:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535873413; cv=none; d=google.com; s=arc-20160816; b=L5F8U21cRDaXjOJNkgH55c+Yy2Pm3mIEonipa3r80ROFLWaotmIb4B6B+ucK0XrWfs hAlxn/8gaNOmhORRZzChrSe0iHTbqQMRQq+MIDZAatry6ArwBDBEb3oXtFO7BLUZohcE /ZGlUwb+kd1zng5lmHrwlAjL+lFJ/FRYX4f+8FkpC8J6Q5wdYvLssMrAgHBBFZjUgmvQ 90sSJKPf2QF9+St8mbXkcqsAdUIcdtSVPXXFFBMsAh/MOlmfAm5e7jqSZQvLARDDR+Z4 nBDBWes3lsGUHtck7xsZB1M46gg0qDDkcKvvQFKHQeQIjOfrXtr0LV+X6c8TiUKSO4Bc QlxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=/vLDwUxpzINFEVntNkm+g0KMYzbFFMgtv42VOp9SaIg=; b=BOolePPzwDt13l7Korha65dLiQ5Z+XyaGjNP6lSKATNno5mLfWrFUyMMXFjLCnBgRw TNvg0Fr2HJ2WDyp2S1rm0V5KMAcKfwe6c5mdIWk+FaTQzpPjuwY2M3e/+fl+KJgiK73N fJFA4BKT+F8VjJGBSsHVFDlDLd7BoNHMVQiIezQZ1omY5Xc5LryORual6W7cpayo1UCA gETF2FJs46n1PhTteDYe/1QOvCA28tStGLlf9OvxMzAUH3lXHOqyWRa4N2ITKgaHxDhW 602xKujqDT2ue6x9fYM8cgmfFF1LVcA89pkOMUVsfArlNBH5lu5F9jHpLWtzYAfwKdpk IgSg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l14-v6si15358306pfd.250.2018.09.02.00.29.53; Sun, 02 Sep 2018 00:30:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727650AbeIBLmt (ORCPT + 99 others); Sun, 2 Sep 2018 07:42:49 -0400 Received: from mailoutvs28.siol.net ([185.57.226.219]:55093 "EHLO mail.siol.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727415AbeIBLms (ORCPT ); Sun, 2 Sep 2018 07:42:48 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id 51623520D34; Sun, 2 Sep 2018 09:27:58 +0200 (CEST) X-Virus-Scanned: amavisd-new at psrvmta10.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta10.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id MbJDfqe6dxff; Sun, 2 Sep 2018 09:27:57 +0200 (CEST) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id D79A0520D42; Sun, 2 Sep 2018 09:27:57 +0200 (CEST) Received: from localhost.localdomain (unknown [194.152.15.144]) (Authenticated sender: 031275009) by mail.siol.net (Postfix) with ESMTPSA id 56456520D34; Sun, 2 Sep 2018 09:27:55 +0200 (CEST) From: Jernej Skrabec To: robh+dt@kernel.org, maxime.ripard@bootlin.com, wens@csie.org Cc: mark.rutland@arm.com, mturquette@baylibre.com, sboyd@kernel.org, airlied@linux.ie, architt@codeaurora.org, a.hajda@samsung.com, jernej.skrabec@siol.net, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sunxi@googlegroups.com Subject: [PATCH 22/27] drm/sun4i: Initialize registers in tcon-top driver Date: Sun, 2 Sep 2018 09:26:38 +0200 Message-Id: <20180902072643.4917-23-jernej.skrabec@siol.net> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180902072643.4917-1-jernej.skrabec@siol.net> References: <20180902072643.4917-1-jernej.skrabec@siol.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It turns out that TCON TOP registers in H6 SoC have non-zero reset value. This may cause issues if bits are not changed during configuration. To prevent that, initialize registers to 0. Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun8i_tcon_top.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/sun4i/sun8i_tcon_top.c b/drivers/gpu/drm/sun4i/sun8i_tcon_top.c index 3040a79f298f..37158548b447 100644 --- a/drivers/gpu/drm/sun4i/sun8i_tcon_top.c +++ b/drivers/gpu/drm/sun4i/sun8i_tcon_top.c @@ -167,6 +167,13 @@ static int sun8i_tcon_top_bind(struct device *dev, struct device *master, goto err_assert_reset; } + /* + * At least on H6, some registers have some bits set by default + * which may cause issues. Clear them here. + */ + writel(0, regs + TCON_TOP_PORT_SEL_REG); + writel(0, regs + TCON_TOP_GATE_SRC_REG); + /* * TCON TOP has two muxes, which select parent clock for each TCON TV * channel clock. Parent could be either TCON TV or TVE clock. For now -- 2.18.0