Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp923917imm; Sun, 2 Sep 2018 03:58:57 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYIf4iZhrFVkWFr5ZQfMRUGDS/utFcTNRBMlCtFD6B7Jqlzv354wqL72w7Je466+9zdZ/AW X-Received: by 2002:a63:e255:: with SMTP id y21-v6mr7263095pgj.160.1535885937407; Sun, 02 Sep 2018 03:58:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535885937; cv=none; d=google.com; s=arc-20160816; b=K/VAWVFQPPAd0uV2B+6wuAPE8006+Z0WtoHohtaOOSQ4rv3mi/JeYEZX/Iki3MJBcA /w1A2vUdKkE63v3jJzQeoABsj48EKBfyYWxBTKyJGZ+BXwLSF83AN/8asiGdckk3NxyV NlJ98U+i1ifwzWdNfoK1aOPDXeIE6BD9Xi7I3lRCFqlZENbKm+juVvmXtXJwOxGqxLQd wFSdDHw8P/U/CKG2Aozebjcz1U+vLLPz5kK3pspsai3Y37JDyEaQfp/81u3hJqijUwLn 424WgcWUMOV4iP+1BE3H/bPqSJU4CcYpNmLBoi65yWQ4IRweyWaiu7S78QTqsNnUVOco oNmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=6z00IKV9Hq1+jcpQkONP8fx3xMLiqoy+drrFnYqZe38=; b=CjLOyK+ZBX/ZDIbrStpFtkG89TxyopJ0wp4Z9ADf9jJCQyXWqNzzg8SQH/uUJFV6ZC o3WBFQQVabJ1y1Oo0a1MFYi3RtNKoSeLFswyYM4i3X/mACyyXWe7Pk3VWssjk2TTaPSm O3ulDW5Qd0prBEd1xoJFf8oGG3AFD5KtQtFVfcRoUMPGNJLv4KQdQvR5hSozYdx/vWiT ocSSSZ/AVhRZM/CDlaZcer6D+pUi7ZPVlcu5OxhuJXe2FpLg68Kv/9fwnQwWI1aqCdYB AfFLUcd6CFoi4RPZgSQd4e8CgNS1YH0rlbk2NZi3l0XhVlWpXR3C9/rGuWYDSNjXAZeA WgNA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l18-v6si15982906pfk.78.2018.09.02.03.58.12; Sun, 02 Sep 2018 03:58:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726421AbeIBPKf (ORCPT + 99 others); Sun, 2 Sep 2018 11:10:35 -0400 Received: from mail.skyhub.de ([5.9.137.197]:60770 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726007AbeIBPKf (ORCPT ); Sun, 2 Sep 2018 11:10:35 -0400 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id O52D-AeVvShW; Sun, 2 Sep 2018 12:54:55 +0200 (CEST) Received: from zn.tnic (p200300EC2BE52600329C23FFFEA6A903.dip0.t-ipconnect.de [IPv6:2003:ec:2be5:2600:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id CBFD01EC0200; Sun, 2 Sep 2018 12:54:54 +0200 (CEST) Date: Sun, 2 Sep 2018 12:56:02 +0200 From: Borislav Petkov To: Sai Praneeth Prakhya Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, ricardo.neri@intel.com, matt@codeblueprint.co.uk, Lee Chun-Yi , Al Stone , Ingo Molnar , Andy Lutomirski , Bhupesh Sharma , Peter Zijlstra , Ard Biesheuvel Subject: Re: [PATCH V2 2/6] x86/efi: Remove __init attribute from memory mapping functions Message-ID: <20180902105602.GA19431@zn.tnic> References: <1535881594-25469-1-git-send-email-sai.praneeth.prakhya@intel.com> <1535881594-25469-3-git-send-email-sai.praneeth.prakhya@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1535881594-25469-3-git-send-email-sai.praneeth.prakhya@intel.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 02, 2018 at 02:46:30AM -0700, Sai Praneeth Prakhya wrote: > In order to not keep these functions needlessly when > "CONFIG_EFI_WARN_ON_ILLEGAL_ACCESS" is not selected, add a new > __efi_init_fixup attribute whose value changes based on whether the Why not just __efi_init{,data} ? -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.