Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1001793imm; Sun, 2 Sep 2018 06:30:24 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbiNNHChrkO83MBGuAxEPu6TAz4aV/SDkVFf6t3mSK9+PzmsZwbzVnXE8xvxfo4mJ1PrQrH X-Received: by 2002:a17:902:6a83:: with SMTP id n3-v6mr23574907plk.246.1535895024015; Sun, 02 Sep 2018 06:30:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535895023; cv=none; d=google.com; s=arc-20160816; b=ORo1tMHo8+wtADwDJU9cY3ihnXQuRCNPioYf4VgT+HWu0ZAFksvRUMPEgPxwke/Q9F 1Z8TqQZUx6Yn2OA1InbjCnynV2Lgj/Xzb26eVhEyyXi4MwBxymyqXOLaf40B88ZnrRXR +RzqkmTja16RFpe3cPY8HOFLBL5z5UllUfbyHGY57dmFVSKES9v+iquQ3L99TtUJnwLZ mVGoFmVgtcL4wE5x2B2EOD1FJ/x3edFzp9cDSa7BYFgDzmrNMwzLnPA05wiEP4fAWQXT siUBVkHo9R1/6CfNCSg0OsfuvkbCjEg5jln3cVsRVRs1dmtVO5s8kIpQKmisIr5Pswhh +iKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=DhF8bGM7s9p7Kg/RdHF+iQJGxk8vqyaVtvebV5hp04Y=; b=XKOH/+vAL8gjzjkdwTNJx5HfdUxEsYdGjqZWpjI47AxgM7oS7tEdwN4BdAJ+yiO3ef pJLTdRaPEcxSIbYGKR1ABG4BCrK1yIe7KOg5VBp76CVCO6i2YRZg9BNGSrDVYNxOzzm5 MSzUpY3xFJDPAZ6zTzUU6UdR2IpNfAujj3/qIO0l0AoTAHbU+RG0Zfqn0A3icVB941IM qt8uy0oyXUYOq5DzE4H5zUXCdhiwIpCqVN+a2k3mkM5lFdC61BLI6AL1wbAsqFV+Rb44 D2TviE/QYqN4PgNjQ6fd4IVdfGQUAgALnTf8+PYR+hMztavC+s+rudt4tgb1+qDGSB9d LyEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=R9Ap3viV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w7-v6si15633891plq.198.2018.09.02.06.30.09; Sun, 02 Sep 2018 06:30:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=R9Ap3viV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728009AbeIBRWF (ORCPT + 99 others); Sun, 2 Sep 2018 13:22:05 -0400 Received: from mail-co1nam03on0121.outbound.protection.outlook.com ([104.47.40.121]:64374 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728649AbeIBRVd (ORCPT ); Sun, 2 Sep 2018 13:21:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DhF8bGM7s9p7Kg/RdHF+iQJGxk8vqyaVtvebV5hp04Y=; b=R9Ap3viV1lJytHuOFtdh/txNpYtMXyJIvexAqf+3C1mxJOgBKjT4CU9CsB04cjMdFn0Nk1yqQEx8b9Pyo7vho3zj53LLKrU37M1l7IXfiPSrBTfhNFhN3eJ1r2K+pdzdc/YpmKxextfPgbs6ov8brqD9cv3+VM/rI7gHFHYc3hc= Received: from CY4PR21MB0776.namprd21.prod.outlook.com (10.173.192.22) by CY4PR21MB0184.namprd21.prod.outlook.com (10.173.193.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1122.2; Sun, 2 Sep 2018 13:05:38 +0000 Received: from CY4PR21MB0776.namprd21.prod.outlook.com ([fe80::7c3a:eea8:1391:1611]) by CY4PR21MB0776.namprd21.prod.outlook.com ([fe80::7c3a:eea8:1391:1611%7]) with mapi id 15.20.1143.000; Sun, 2 Sep 2018 13:05:38 +0000 From: Sasha Levin To: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Andrey Smirnov , Lee Jones , Sasha Levin Subject: [PATCH AUTOSEL 4.18 109/131] mfd: rave-sp: Initialize flow control and parity of the port Thread-Topic: [PATCH AUTOSEL 4.18 109/131] mfd: rave-sp: Initialize flow control and parity of the port Thread-Index: AQHUQr2a2z4lcIrqKku9mIDoaG0Mqw== Date: Sun, 2 Sep 2018 13:05:20 +0000 Message-ID: <20180902064601.183036-109-alexander.levin@microsoft.com> References: <20180902064601.183036-1-alexander.levin@microsoft.com> In-Reply-To: <20180902064601.183036-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY4PR21MB0184;6:yJ0t1vshVCfi88rG8SL1y4adQ3B8EDQ/4h0Lro+N83U2kjH7f3zJo2Rhs/wezChQxefv5GV/ngC7zx8b0rd7ZvPNuGe28umMpZq5+PHeTV0BuHzdarzyz43/ZgQUsbwCpD02jBJWlUpJy0ZHrKkb+OfwI1vxSFogmblXFfsedMzg+xIheXw/WImu6CMS6sk/Sw/zqnrXiPv8+k2331UIoGo9kyWTDcPJzfgdNltz2AaGtCreUOLzxMvQnE5HHMC2oScdCtT3RY322X7MnMtyMIlfPGiLpzsJXYZyvsD0L6YJ8skzEwQC9XYYNJcPy90TyhkYafDw9SURHOGZpykkjgorrZCu5O7Kj87OI3rWO+kRNEK3700044zLNdKNpRFVlfymLZvnOIk1Mjyg9kAyc4OqGhcnak9+MAI2UBXL0Z394csr0T+JKNtXwzF0Aehd8xhlAJS2A5ih4ci1NsBPPg==;5:MjcAPjxaSlh1s4wEl+mojjT+wrbkTbfGRXNDK5Y3916+XE9Su6j9+buK7wsdWbGc+gKq6tJlLoM4RhUN2EXpWKItNEasVDCoa6VPNAJJO/uf/beFq304d2HEaJPNCetmh093gB4WWQBcv5F+K8nmtMHVh0NXeryWd8iSxZtgn7Q=;7:JZ5hVYF71MBE9ZCXPGpAO6kKcpA19Cqys8C5hx+naWKN5s7gkgFifNmUTiI79fqw/96B6SzEktHeb3rADPH8EEDuhtYlAyd+aoa8XWMW5Jr8KQ7lbfsGjlDyAZfDAinknEmFn5rPeCQPPhu9HX8NjFGyaTeIfsvBNjFNltoSX+ReRPm1SvmnBi50S6gQHbqWWl10eKVa3BtP+3WFQsGDDvczcU35GY0IfBM86qlQoosrt772e6wg8LbJ9/bR7txd x-ms-office365-filtering-correlation-id: 41e09812-e2db-4a90-050c-08d610d4c75e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(4534165)(4627221)(201703031133081)(201702281549075)(5600074)(711020)(4618075)(2017052603328)(7193020);SRVR:CY4PR21MB0184; x-ms-traffictypediagnostic: CY4PR21MB0184: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(85827821059158); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(3231340)(944501410)(52105095)(2018427008)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201708071742011)(7699049)(76991033);SRVR:CY4PR21MB0184;BCL:0;PCL:0;RULEID:;SRVR:CY4PR21MB0184; x-forefront-prvs: 078310077C x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39860400002)(366004)(136003)(396003)(376002)(346002)(189003)(199004)(6512007)(53936002)(6436002)(97736004)(105586002)(22452003)(25786009)(106356001)(107886003)(39060400002)(4326008)(6486002)(110136005)(54906003)(316002)(10090500001)(5250100002)(256004)(66066001)(36756003)(6116002)(2501003)(26005)(6506007)(5660300001)(3846002)(81156014)(76176011)(99286004)(102836004)(1076002)(8676002)(81166006)(10290500003)(2616005)(68736007)(476003)(2906002)(8936002)(11346002)(72206003)(186003)(305945005)(7736002)(486006)(6666003)(217873002)(86362001)(2900100001)(86612001)(446003)(14454004)(478600001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR21MB0184;H:CY4PR21MB0776.namprd21.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: NAaMMjTtmnZJdw0wNXsNHkTiTH1ohUdEvbaHj1nZmy/U4qv6cE86UVxA2IlyEPYTtTgtQZNA5halfscTV3S+MK3wV26Mz5PJEczOnG+9ymrMoq9m23LoxIY8a47/mWhInvT3o6g5CXGW3ZMoUXFdHqTi0ept0svy/CXjuMlrPi+MbtuoUu4Y3wcjFWqnbffyMIqK4xaBCpEF0pvVRcC350fU1/g8q/+UJCxEPUn6H7WwxESnxLLVmk/f9p5alJmFN98fjT/zzJ0zMbfUTTp/1le2I/CBwyA7bDzZTHAJ8VX1pbKsZeGabsyvuu32PRTZaFGQPQCsObevtajXRJrjn203uF36hobJJEv6JRLwKeo= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41e09812-e2db-4a90-050c-08d610d4c75e X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2018 13:05:20.2332 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0184 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andrey Smirnov [ Upstream commit 6c450bdf13ebe110821a74960936cec936edae49 ] Relying on serial port defaults for flow control and parity can result in complete breakdown of communication with RAVE SP on some platforms where defaults are not what we need them to be. One such case is VF610-base ZII SPU3 board (not supported upstream). To avoid this problem in the future, add code to explicitly configure both. Signed-off-by: Andrey Smirnov Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/mfd/rave-sp.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/mfd/rave-sp.c b/drivers/mfd/rave-sp.c index 36dcd98977d6..4f545fdc6ebc 100644 --- a/drivers/mfd/rave-sp.c +++ b/drivers/mfd/rave-sp.c @@ -776,6 +776,13 @@ static int rave_sp_probe(struct serdev_device *serdev) return ret; =20 serdev_device_set_baudrate(serdev, baud); + serdev_device_set_flow_control(serdev, false); + + ret =3D serdev_device_set_parity(serdev, SERDEV_PARITY_NONE); + if (ret) { + dev_err(dev, "Failed to set parity\n"); + return ret; + } =20 ret =3D rave_sp_get_status(sp); if (ret) { --=20 2.17.1