Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Sasha Levin <Alexander.Levin@microsoft.com>
To:     "stable@vger.kernel.org" <stable@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Petr Machata <petrm@mellanox.com>,
        Ido Schimmel <idosch@mellanox.com>,
        "David S . Miller" <davem@davemloft.net>,
        Sasha Levin <Alexander.Levin@microsoft.com>
Subject: [PATCH AUTOSEL 4.18 092/131] net: dcb: For wild-card lookups, use
 priority -1, not 0
Thread-Topic: [PATCH AUTOSEL 4.18 092/131] net: dcb: For wild-card lookups,
 use priority -1, not 0
Thread-Index: AQHUQr2OmMgcH5bPx0+gp2TBD1T75g==
Date:   Sun, 2 Sep 2018 13:05:00 +0000
Message-ID: <20180902064601.183036-92-alexander.levin@microsoft.com>
References: <20180902064601.183036-1-alexander.levin@microsoft.com>
In-Reply-To: <20180902064601.183036-1-alexander.levin@microsoft.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: microsoft.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a8a2b5cf-db0a-4034-9e6e-08d610d4c366
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2018 13:05:00.4027
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0741
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Petr Machata <petrm@mellanox.com>

[ Upstream commit 08193d1a893c802c4b807e4d522865061f4e9f4f ]

The function dcb_app_lookup walks the list of specified DCB APP entries,
looking for one that matches a given criteria: ifindex, selector,
protocol ID and optionally also priority. The "don't care" value for
priority is set to 0, because that priority has not been allowed under
CEE regime, which predates the IEEE standardization.

Under IEEE, 0 is a valid priority number. But because dcb_app_lookup
considers zero a wild card, attempts to add an APP entry with priority 0
fail when other entries exist for a given ifindex / selector / PID
triplet.

Fix by changing the wild-card value to -1.

Signed-off-by: Petr Machata <petrm@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
---
 net/dcb/dcbnl.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c
index 2589a6b78aa1..013fdb6fa07a 100644
--- a/net/dcb/dcbnl.c
+++ b/net/dcb/dcbnl.c
@@ -1786,7 +1786,7 @@ static struct dcb_app_type *dcb_app_lookup(const stru=
ct dcb_app *app,
 		if (itr->app.selector =3D=3D app->selector &&
 		    itr->app.protocol =3D=3D app->protocol &&
 		    itr->ifindex =3D=3D ifindex &&
-		    (!prio || itr->app.priority =3D=3D prio))
+		    ((prio =3D=3D -1) || itr->app.priority =3D=3D prio))
 			return itr;
 	}
=20
@@ -1821,7 +1821,8 @@ u8 dcb_getapp(struct net_device *dev, struct dcb_app =
*app)
 	u8 prio =3D 0;
=20
 	spin_lock_bh(&dcb_lock);
-	if ((itr =3D dcb_app_lookup(app, dev->ifindex, 0)))
+	itr =3D dcb_app_lookup(app, dev->ifindex, -1);
+	if (itr)
 		prio =3D itr->app.priority;
 	spin_unlock_bh(&dcb_lock);
=20
@@ -1849,7 +1850,8 @@ int dcb_setapp(struct net_device *dev, struct dcb_app=
 *new)
=20
 	spin_lock_bh(&dcb_lock);
 	/* Search for existing match and replace */
-	if ((itr =3D dcb_app_lookup(new, dev->ifindex, 0))) {
+	itr =3D dcb_app_lookup(new, dev->ifindex, -1);
+	if (itr) {
 		if (new->priority)
 			itr->app.priority =3D new->priority;
 		else {
@@ -1882,7 +1884,8 @@ u8 dcb_ieee_getapp_mask(struct net_device *dev, struc=
t dcb_app *app)
 	u8 prio =3D 0;
=20
 	spin_lock_bh(&dcb_lock);
-	if ((itr =3D dcb_app_lookup(app, dev->ifindex, 0)))
+	itr =3D dcb_app_lookup(app, dev->ifindex, -1);
+	if (itr)
 		prio |=3D 1 << itr->app.priority;
 	spin_unlock_bh(&dcb_lock);
=20
--=20
2.17.1