Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1471407imm;
        Mon, 3 Sep 2018 01:02:48 -0700 (PDT)
X-Google-Smtp-Source: ANB0VdbrvpieNa+j0rFA0jLn1WhlFifH+lMQ2EWLKm8RabCzXaVzUHNHyiegTduxvF1CCt9FYuNS
X-Received: by 2002:a63:eb0e:: with SMTP id t14-v6mr25409422pgh.198.1535961768755;
        Mon, 03 Sep 2018 01:02:48 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1535961768; cv=none;
        d=google.com; s=arc-20160816;
        b=zLeuvT3cS1BK1oU7YcZr3qjaFWYMWYT5SUldSf85h+PpkDX7DPilMrSLyiuPDepjK+
         XGlqiiNM4cisYiXyLqlZ55LGKs9NCi0+oJgW4HRYlyxYM2x9Af6C5lfxZIzo19O5WJTI
         9Q7hl/lzuc1J4MAjH7FnTM+TPTgUpBT3c3L4RxoI8fVMx5ElvdvxsigP8shaswIUYqQR
         MzNkQbVJOiJ0tJPjc/AYKMPsA4pwB+1x1IlcfUj4BOus5hNc7dlZnbQFGMQvwEAD63Ju
         ++qYUp/vxyrHtgjVhbl+1ilDOejNpcw6O51vjoyCBrBUNzNZ/grpVO4xqRHjMpdBwRj+
         n6Yg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date:arc-authentication-results;
        bh=qPX/PFdVy3aSnR0aHsJRmAeHG9qLRwpx4FLVBIq2124=;
        b=b1c0N+Xjgp+nhpq9wO0bZNEbcaDQWsw6NJFsIlWSCBMs0GBC1SaQiSKIEEWo6R4qqX
         5iAQ4xaMR5nonU/sYmEvnkA+zDGR8uVDNtawQJNOfkObc+bVSkg+xoezV4gZpomKrTbU
         rNZEfVeTwS5wqAaIMQZcl80LLVF+LdiiCO/MefT4G7/mRhkatm9qD4hrPByRgOYg9OW8
         5rPtHe3ikq+Rd8z7L3fU6gQ53THxcFAWOGp7G/4ua/4OTVpg9ij9s+6zsjrYHNe0+9tM
         AfXIWaHVpNdDhj1yZPndOet7EJGsf0XpPJpyYYmpZvaQyPGH/9xjSnJVviiRd4ybP9Fe
         WdFQ==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id t77-v6si16253515pgb.363.2018.09.03.01.02.34;
        Mon, 03 Sep 2018 01:02:48 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726314AbeICMUQ (ORCPT <rfc822;vladislav.valtchev@gmail.com>
        + 99 others); Mon, 3 Sep 2018 08:20:16 -0400
Received: from hqemgate15.nvidia.com ([216.228.121.64]:15513 "EHLO
        hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725898AbeICMUP (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 3 Sep 2018 08:20:15 -0400
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5b8cea450000>; Mon, 03 Sep 2018 01:01:09 -0700
Received: from HQMAIL101.nvidia.com ([172.20.161.6])
  by hqpgpgate102.nvidia.com (PGP Universal service);
  Mon, 03 Sep 2018 01:01:16 -0700
X-PGP-Universal: processed;
        by hqpgpgate102.nvidia.com on Mon, 03 Sep 2018 01:01:16 -0700
Received: from tbergstrom-lnx.Nvidia.com (10.124.1.5) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 3 Sep
 2018 08:01:16 +0000
Received: by tbergstrom-lnx.Nvidia.com (Postfix, from userid 1002)
        id 73103F8086D; Mon,  3 Sep 2018 11:01:11 +0300 (EEST)
Date:   Mon, 3 Sep 2018 11:01:11 +0300
From:   Peter De Schrijver <pdeschrijver@nvidia.com>
To:     Dmitry Osipenko <digetx@gmail.com>
CC:     Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Prashant Gaikwad <pgaikwad@nvidia.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>, <linux-clk@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] clk: tegra20: Enable lock-status polling for PLLs
Message-ID: <20180903080111.GR1636@tbergstrom-lnx.Nvidia.com>
References: <20180830184210.5369-1-digetx@gmail.com>
 <20180830184210.5369-2-digetx@gmail.com>
 <20180831092948.GP1636@tbergstrom-lnx.Nvidia.com>
 <909e2a52-4116-9ee7-db23-8ea1dfffade0@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <909e2a52-4116-9ee7-db23-8ea1dfffade0@gmail.com>
X-NVConfidentiality: public
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 HQMAIL101.nvidia.com (172.20.187.10)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 31, 2018 at 12:45:17PM +0300, Dmitry Osipenko wrote:
> On 8/31/18 12:29 PM, Peter De Schrijver wrote:
> > On Thu, Aug 30, 2018 at 09:42:10PM +0300, Dmitry Osipenko wrote:
> >> Currently all PLL's on Tegra20 use a hardcoded delay despite of having
> >> a lock-status bit. The lock-status polling was disabled ~7 years ago
> >> because PLLE was failing to lock and was a suspicion that other PLLs
> >> might be faulty too. Other PLLs are okay, hence enable the lock-status
> >> polling for them. This reduces delay of any operation that require PLL
> >> to lock.
> >>
> >> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> >> ---
> >>
> >> Changelog:
> >>
> >> v2:	Don't enable polling for PLLE as it known to not being able to lock.
> >>
> > 
> > This isn't correct. The lock bit of PLLE can declare lock too early, but the
> > PLL itself does lock.
> 
> Indeed, it locks but can't be polled for the lock-status as it doesn't have the
> lock-status bit.
> 
> Do you want me to adjust the commit description or it is fine as is?
> 

I think it's better to adjust it.

> It is also a bit odd that PLLE has "lock_delay = 0", is it correct?

That seems odd yes..

Peter.