Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 03 Sep 2018 19:01:47 +0800
In-Reply-To: <20180903102022.fkxfkxadkt4vpbmb@flea>
References: <20180830154518.29507-1-embed3d@gmail.com> <20180830154518.29507-22-embed3d@gmail.com> <20180831091137.wkbbipssyd6mqfbt@flea> <f01ec2f202c7e2e5a7e0c822b2f9a8f0c55a9ea4.camel@aosc.io> <20180903102022.fkxfkxadkt4vpbmb@flea>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: 8BIT
Subject: Re: [linux-sunxi] Re: [PATCH v3 21/30] iio: adc: sun4i-gpadc-iio: add support for H3 thermal sensor
To:     maxime.ripard@bootlin.com,
        Maxime Ripard <maxime.ripard@bootlin.com>
CC:     Philipp Rossak <embed3d@gmail.com>, mark.rutland@arm.com,
        geert+renesas@glider.be, linux-iio@vger.kernel.org,
        robh+dt@kernel.org, linux-sunxi@googlegroups.com,
        clabbe.montjoie@gmail.com, pmeerw@pmeerw.net, lee.jones@linaro.org,
        lars@metafoo.de, quentin.schulz@bootlin.com, linux@armlinux.org.uk,
        wens@csie.org, devicetree@vger.kernel.org, arnd@arndb.de,
        vilhelm.gray@gmail.com, broonie@kernel.org,
        linux-arm-kernel@lists.infradead.org, rdunlap@infradead.org,
        arnaud.pouliquen@st.com, linux-kernel@vger.kernel.org,
        lukas@wunner.de, knaack.h@gmx.de, eugen.hristev@microchip.com,
        jic23@kernel.org
From:   Icenowy Zheng <icenowy@aosc.io>
Message-ID: <AFDFF5AB-8BF6-4461-A5C2-D628A2F22E2E@aosc.io>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


于 2018年9月3日 GMT+08:00 下午6:20:22, Maxime Ripard <maxime.ripard@bootlin.com> 写到:
>On Fri, Aug 31, 2018 at 05:51:41PM +0800, Icenowy Zheng wrote:
>> Personally I suggest to leave out all SID or calibration related
>> patches here.
>> 
>> Currently we seems to be wrongly converting SID to big endian,
>however,
>> the orgnization of the THS calibration data on H6 shows that it's
>> surely little endian:
>> 
>> It consists a temperature value in 1/10 celsuis as unit, and some
>> thermal register readout values, which are the values read out at the
>> given temperature, and every value here (the temperature and the
>> readout) are all half word length.
>> 
>> Let the temperature value be AABB, the two readout values be XXYY and
>> ZZWW, the oragnization is:
>> BB AA YY XX WW ZZ ** ** .
>> 
>> When converting the SID to big endian, it becomes:
>> XX YY AA BB ** ** ZZ WW ,
>> which is non-sense, and not able to do sub-word cell addressing.
>> 
>> Maxime, should I drop the LE2BE conversion in SID driver? (I doubt
>> whether it will break compatibility.)
>
>This is exposed to the userspace, so no.

Please note the LE2BE totally breaks the SID addressing.

Without it dropped all cells must be referenced with
4 byte word as unit, and half word addressing of
SID is thus not possible. The driver will also need then to split
the half words if needed.

I think this is kind of hardware misbehavior, and not a simple
UAPI change, so the UAPI stability shouldn't affect this change.

>
>Maxime
>>