Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1579246imm; Mon, 3 Sep 2018 04:17:56 -0700 (PDT) X-Google-Smtp-Source: ANB0VdaA8WMkWafHwIwKtzQG/KP7oREz8Q0vukACW0kjtk6dRaJtZa3B3MpIl6bIpYSM8YksniBh X-Received: by 2002:a63:8a41:: with SMTP id y62-v6mr24371163pgd.278.1535973476463; Mon, 03 Sep 2018 04:17:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535973476; cv=none; d=google.com; s=arc-20160816; b=PF/pog1paAb2jUV4YK391F/Pmq4KiMvIH4lI464HJjtN6rpr4CsahMIqNGd38ynmr4 VD0qFRfOu8g6uiUzz1ATNHDXZ6q7ANMHttXi3SKnqi3HjN/l6fzlBn5sDTuZnvUoyfSO 7lcH3qLfM1w4XS9bp+Sq7baLLJZC8lHHbcghbK6njWfvv+HBjF4Z46a4TlnoNzwoKTGF d/CzaAr0VgPWrnDlP9O/T5SZfFRppMJw7xk34qShCm/njzB7hpeH6tCS0dD7aaINZ6A4 z1pgP8USNOBu7/BY7/KuHaVwUy1jTtTzb5M+DHCAAdRPFq3G1471TMa0nJtYAi6stynX PxzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=hy5ZjyDKQT9y3+w3V8UINFKUtSyqvyyuBkLoxwMx7UU=; b=zyM9etC7OTWwp8Nc0BvKxv2kl71igd4JIq/1ZcmzxFWMcnSlkk2CrkgsrnBajiwlMq R4WspiM4edlKZDL18ijLGPb39DpSlur5bcP01XZpVlrkyAhTGMwYDCw5Bpu1KZL24utd IV2rda5fftPemjQRjLPRSJCowtJlugrOTr12WSvIxq80MEtQHHSRMoRuOb8cQKsVMjiw dEKZxfS15bzSw9xJGaVh9Ysc5nyxlIoHzrKsg00OtDpwJIZx2AnEJ2icFc8xqZHSyXC1 c6BHQRomgA6rMeh4RVMzpH6yF44zM5U2fyMaRd7ZtDHUyLX0M2SJaMpQezG8/8FesTXu b+EA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=b253noL5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n72-v6si19497501pfk.14.2018.09.03.04.17.40; Mon, 03 Sep 2018 04:17:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=b253noL5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727210AbeICPgN (ORCPT + 99 others); Mon, 3 Sep 2018 11:36:13 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:58720 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726057AbeICPgN (ORCPT ); Mon, 3 Sep 2018 11:36:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=hy5ZjyDKQT9y3+w3V8UINFKUtSyqvyyuBkLoxwMx7UU=; b=b253noL5z7WUlNmMM7VHdCYVY fBkLOVyh3zcEVokl1bNOyspX/ErWVWuc6zH6TqatOybEL9cKF/qiqTNnazb1khKw2JvlMGhi4SryK gznjmN6cU2E3QankBvQxoQJDxPAcelGaR9uoDxKs1+rEfMki/B7/RVwlZCt1bJYSdW+3Q=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1fwmqJ-0000BE-B8; Mon, 03 Sep 2018 11:16:27 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id E2EA411227AE; Mon, 3 Sep 2018 12:16:26 +0100 (BST) Date: Mon, 3 Sep 2018 12:16:26 +0100 From: Mark Brown To: Sasha Levin Cc: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Akshu Agrawal Subject: Re: [PATCH AUTOSEL 4.18 043/131] ASoC: soc-pcm: Use delay set in component pointer function Message-ID: <20180903111626.GC10302@sirena.org.uk> References: <20180902064601.183036-1-alexander.levin@microsoft.com> <20180902064601.183036-43-alexander.levin@microsoft.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CblX+4bnyfN0pR09" Content-Disposition: inline In-Reply-To: <20180902064601.183036-43-alexander.levin@microsoft.com> X-Cookie: Inside, I'm already SOBBING! User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --CblX+4bnyfN0pR09 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 02, 2018 at 01:03:55PM +0000, Sasha Levin wrote: > From: Akshu Agrawal >=20 > [ Upstream commit 9fb4c2bf130b922c77c16a8368732699799c40de ] >=20 > Take into account the base delay set in pointer callback. >=20 > There are cases where a pointer function populates > runtime->delay, such as: > ./sound/pci/hda/hda_controller.c > ./sound/soc/intel/atom/sst-mfld-platform-pcm.c I'm worried that if anyone notices this at all they will have already compensated for the delays in userspace and therefore this will cause them to see problems as they get double compenstation for delays. --CblX+4bnyfN0pR09 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAluNGAoACgkQJNaLcl1U h9D4KAf/WEpG66GEu/Nt3vsarOLjudyUDLScLRtNYaMRi1LS3EMsHFWfgQ7Ysebr eaX6wxQM2ZAVmUKzlxy8vJrJ3PvTIfRQBHwAMman8Em3HR8sdmY4EEmpVSpSd52P jnS5ke5jdURP6gfsWOU0ho3QOT5Fil1GJTYlZGGnX/aqERwKuC2oddDLO3GltIOl VnsqQeUUSsk4m6EKvA25DRr1xxeb+3Hj3st5C9I8cq8D+7MF6qQDZPIKEra2/x/L +dl+bqf+jmHXIi7uq3krYYko2pVEaqb+gkTGe3XsVR7RK8Yt2K5jcxYnAj4rZz7q STWJV9Vxo5ULTKQ+EjT8CPWTbJTu+Q== =Wo/o -----END PGP SIGNATURE----- --CblX+4bnyfN0pR09--