Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1732575imm; Mon, 3 Sep 2018 08:03:53 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZ6QEOgfOzPYQ9gp0zv6zHZazY7MdJHefp6CGFbsQJ6D+0OIrndH4pOLuS8lCwMJIAIE0mf X-Received: by 2002:a63:ba1c:: with SMTP id k28-v6mr26491069pgf.76.1535987033898; Mon, 03 Sep 2018 08:03:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535987033; cv=none; d=google.com; s=arc-20160816; b=KYzYxU5d7AYGdjHNMuceeO7oL+GOlOMeJBflZkh5lZ8tT27WyprtVzWzcNUOZ9SVz4 kNJYjftmjABOCgmYALfLpkFY9ia90HopFm7yIBrCxleXJqF5QsJbSsCvJooPYMl6Mm7H JZxcpBeS5rmmddfDQWeDVsRHNfSgOMok5Ulg8UmcX7plcqjj4GDkIIlgbdJTGLgtYd9S oipQfgVbMxSDnYSQPsh3lnqZBVFrPvYyt3FyXFA7YbHAbg8GNx6ZDj05U4Ntf3euyDDH 3d/6j1HquY5TnWQuBh+IplueTfcplTKDejsHoOpnHOzYXgQjsdpKstEw6TTElqdOK940 fwIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:references:cc:to:from:subject :arc-authentication-results; bh=YAOGkX46/ToFDD8t4ilUN7hMjy9+yUkc3UOflWJhbkY=; b=srDL9HJgMw/e8ajes1lHH3Uzr38Vs89fOJdHzuN/jYV0b4hW+mJOKctyX03efMbwMX UzpZZwzw6k4WWXlSY5WSAAny13MtSwrVuDvTJ7vWoDCOWgkaxehJjwUUzAb88VZbfSlW ZLmFpCiz5Qcw53zGgxImdPWcngNsddMNSxin4r9ZKZo11v20WS2/CZasRXTBcL7llaKu ZmCfPB1okgufmcxPYVvROumIlKAet6bmPntH0VpuWgbuQOnoO97ttOFUgjhTjU6bnYOX gmerU28WlrBeYIl5qIr41uwLeOEYRxCqqAOb6C7ODk8J7HHXCdRcW3SSts0zjEywadGF lsmQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m10-v6si16857571pgv.374.2018.09.03.08.03.38; Mon, 03 Sep 2018 08:03:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727523AbeICTWT (ORCPT + 99 others); Mon, 3 Sep 2018 15:22:19 -0400 Received: from smtp113.iad3a.emailsrvr.com ([173.203.187.113]:34545 "EHLO smtp113.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726047AbeICTWT (ORCPT ); Mon, 3 Sep 2018 15:22:19 -0400 Received: from smtp39.relay.iad3a.emailsrvr.com (localhost [127.0.0.1]) by smtp39.relay.iad3a.emailsrvr.com (SMTP Server) with ESMTP id 1C0B95852; Mon, 3 Sep 2018 10:52:23 -0400 (EDT) X-Auth-ID: siepeng@mev.co.uk Received: by smtp39.relay.iad3a.emailsrvr.com (Authenticated sender: siepeng-AT-mev.co.uk) with ESMTPSA id 9038258E5; Mon, 3 Sep 2018 10:52:22 -0400 (EDT) X-Sender-Id: siepeng@mev.co.uk Received: from [10.0.0.185] (remote.quintadena.com [81.133.34.160]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA) by 0.0.0.0:465 (trex/5.7.12); Mon, 03 Sep 2018 10:52:23 -0400 Subject: Re: [PATCH 1/4] staging: comedi: Correct multiline dereference as per TODO From: Ian Abbott To: Ray Clinton , greg@kroah.com Cc: hsweeten@visionengravers.com, linux-kernel@vger.kernel.org References: Organization: MEV Ltd. Message-ID: <4b023c3d-eaeb-6466-5bc8-caed57fbd48b@mev.co.uk> Date: Mon, 3 Sep 2018 15:52:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/09/18 15:47, Ian Abbott wrote: > On 30/08/18 18:32, Ray Clinton wrote: >> Using checkpatch.pl I was able to find a multiline dereference which goes >> again the coding style for the kernel. I'm still working on my email >> client so >> the indentation looks bad here (in gmail) but the arguments for >> comedi_check_trigger_arg_min should go just under the opening ( > > The patch description should describe what the patch does, not how bad > the indentation loos in your email client. "loos" ==> "looks" Also, you sent 4 patches with the same subject line (other than the PATCH 1/4 part). They should be different. You can include the driver name in the patch subject line to distinguish them, e.g.: staging: comedi: dt3000: Correct multiline dereference -- -=( Ian Abbott || Web: www.mev.co.uk )=- -=( MEV Ltd. is a company registered in England & Wales. )=- -=( Registered number: 02862268. Registered address: )=- -=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-