Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1809073imm; Mon, 3 Sep 2018 10:00:43 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYXqZA5OC5gOvZReW7r/LWhcXk5CbxCRZoLi0YbVXsA5vMusWMgcmO+z7uYzmOoiqc6u+0S X-Received: by 2002:a62:41d6:: with SMTP id g83-v6mr30505730pfd.219.1535994043137; Mon, 03 Sep 2018 10:00:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535994043; cv=none; d=google.com; s=arc-20160816; b=qOA3xRU/cdNPT/1en7g6AACi2jS8mb0VGEs9diKQH6tyytQl8SJTq6JqOUSdwGH9Q1 Ayay+c4lhoaXg70gsP4Ghh/zn/+aWb8Ff3gsP2bRqqi8kEMynfFp2OHhn8yR98hp0P7d BTj7XALdsjMlOHHDYQt8aRMvG2M6Ep/0rrzkV+Gp0c+iEcCBW0oEF3EPpvl88ltqPEHS g3YEnCVfUkdELKnOuL/lmxSV/fPP26NXgNgHyo3hVU6qwXFI2ANnEY2GHbvPneZ4QeJq 26mm8fonZ4y6PpjyS3whRs9Rv/fdZrRX7QYcJ6OJHOwGnP8NDXrgVl00rVuDnrbWtMEM fMRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=8F4R4bbH6YL/wjO1xS8z83Q0yi+mZXImPXzuUEv8Onc=; b=hl39pMHRElJRhXDDS4gfB/LmESxZUI6RLE73FDh64xroOOBnVjIojgzZOkrYI0h1of EXG2kuyZIPDSG2a90ZefIdcXMUct3NAEoZEsXX2/o4OsGEiLn6nA5CubXO0YaC0WCWPt DNx4E2D+fqHex2BbVUj+jOmiQ7A/bWd5sRtR1qoD3MNYKi9pP73TgPjHVGRrX84/N0wJ gXqUprTIi14H/YlDSJLBXGFgF/XOsj8aV/TvDNqjO9A/qwdpzT1DzOJPjfCttdBedOm/ jebUbQuF5y2ZHpatmH47RC4HeioUTWqMpFcuexy7JXeMK5ej2BksyAVI/NutDzMs0+4Z UF7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s65-v6si18236555pfb.271.2018.09.03.10.00.27; Mon, 03 Sep 2018 10:00:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728592AbeICVT7 (ORCPT + 99 others); Mon, 3 Sep 2018 17:19:59 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38476 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728091AbeICVT6 (ORCPT ); Mon, 3 Sep 2018 17:19:58 -0400 Received: from localhost (ip-213-127-74-90.ip.prioritytelecom.net [213.127.74.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id E5B5CCF5; Mon, 3 Sep 2018 16:58:59 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, chen jie , Andrew Morton , Li Zefan , Yang Shi , Alexey Dobriyan , Linus Torvalds , Sasha Levin Subject: [PATCH 4.4 40/80] mm/memory.c: check return value of ioremap_prot Date: Mon, 3 Sep 2018 18:49:18 +0200 Message-Id: <20180903164935.750871255@linuxfoundation.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180903164934.171677301@linuxfoundation.org> References: <20180903164934.171677301@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: "jie@chenjie6@huwei.com" [ Upstream commit 24eee1e4c47977bdfb71d6f15f6011e7b6188d04 ] ioremap_prot() can return NULL which could lead to an oops. Link: http://lkml.kernel.org/r/1533195441-58594-1-git-send-email-chenjie6@huawei.com Signed-off-by: chen jie Reviewed-by: Andrew Morton Cc: Li Zefan Cc: chenjie Cc: Yang Shi Cc: Alexey Dobriyan Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- mm/memory.c | 3 +++ 1 file changed, 3 insertions(+) --- a/mm/memory.c +++ b/mm/memory.c @@ -3701,6 +3701,9 @@ int generic_access_phys(struct vm_area_s return -EINVAL; maddr = ioremap_prot(phys_addr, PAGE_ALIGN(len + offset), prot); + if (!maddr) + return -ENOMEM; + if (write) memcpy_toio(maddr + offset, buf, len); else