Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Prakhya, Sai Praneeth" <sai.praneeth.prakhya@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>
CC:     "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Neri, Ricardo" <ricardo.neri@intel.com>,
        "matt@codeblueprint.co.uk" <matt@codeblueprint.co.uk>,
        Lee Chun-Yi <jlee@suse.com>, Al Stone <astone@redhat.com>,
        Borislav Petkov <bp@alien8.de>, Ingo Molnar <mingo@kernel.org>,
        Andy Lutomirski <luto@kernel.org>,
        Bhupesh Sharma <bhsharma@redhat.com>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: RE: [PATCH V2 5/6] x86/mm: If in_atomic(), allocate pages without
 sleeping
Thread-Topic: [PATCH V2 5/6] x86/mm: If in_atomic(), allocate pages without
 sleeping
Thread-Index: AQHUQqIDKLGU941Wr0OybRKnptAV1aTeshSAgAAFKACAABQXoA==
Date:   Mon, 3 Sep 2018 17:07:03 +0000
Message-ID: <FFF73D592F13FD46B8700F0A279B802F485B91FE@ORSMSX114.amr.corp.intel.com>
References: <1535881594-25469-1-git-send-email-sai.praneeth.prakhya@intel.com>
 <1535881594-25469-6-git-send-email-sai.praneeth.prakhya@intel.com>
 <20180903083459.GT24124@hirez.programming.kicks-ass.net>
 <alpine.DEB.2.21.1809031048430.1349@nanos.tec.linutronix.de>
In-Reply-To: <alpine.DEB.2.21.1809031048430.1349@nanos.tec.linutronix.de>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.0.400.15
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> Thanks for CC'ing me. I wonder why the world and some more is on CC, but
> x86@kernel.org is NOT.
>

Sorry! about that. I will CC you and x86 from V3.

> > On Sun, Sep 02, 2018 at 02:46:33AM -0700, Sai Praneeth Prakhya wrote:
> 
> > > @@ -926,7 +926,13 @@ static void unmap_pud_range(p4d_t *p4d,
> > > unsigned long start, unsigned long end)
> > >
> > >  static int alloc_pte_page(pmd_t *pmd)  {
> > > -	pte_t *pte = (pte_t *)get_zeroed_page(GFP_KERNEL);
> > > +	pte_t *pte;
> > > +
> > > +	if (in_atomic())
> > > +		pte = (pte_t *)get_zeroed_page(GFP_ATOMIC);
> > > +	else
> > > +		pte = (pte_t *)get_zeroed_page(GFP_KERNEL);
> > > +
> > >  	if (!pte)
> > >  		return -1;
> > >
> >
> > This looks like tinkering to me..
> 
> Yes it is and it's not going to happen.

Haha.. ok.. I will take your suggestion in the 4th patch and that should avoid this.

Regards,
Sai