Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1822047imm; Mon, 3 Sep 2018 10:19:03 -0700 (PDT) X-Google-Smtp-Source: ANB0VdaSYbReONYcyyOxEO7jW8PUejQiOzFU2pXw/l8kSZqXKWkFi6JPydAc5YkdbDNtvzJ9O4rm X-Received: by 2002:a62:b2d3:: with SMTP id z80-v6mr31047482pfl.79.1535995143038; Mon, 03 Sep 2018 10:19:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535995143; cv=none; d=google.com; s=arc-20160816; b=BMAO4bBfTyOckgbVRWWbBYEY879jx6K2H3QTSuM3Tr3NpDNRhiWmtGAve63SSQjgGN 52I5nRAfy9eTpvMO6HSi5OLGr2x0RUmP9Oa2/1Iv4vuMrxc6YgDC7/7+uKgyOGej/yQ8 dR6EMvx75BHMUB8AlltJilHlTLX/qq0DAOtbB8gvPDUzQe/DIDBP2trdyGcGvx3nqsPQ p4Aereu4Yj35tIbfVLFFWvCM6V/MUCPg28xGiL1Fc6lKoAQ4UuzCfrmtuDyVnS5xgRiX rZiqwYOV+0GjtwpR++o6o6UPBOBkYJOJfuO6cdim9AWGo7XyeZ6rs12tBFlVZh4NjUzz I5xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=s4k8s629k7BbipY4QF5YR3JDcM330qkSuaqweqKqKu0=; b=uH+18GGBvG0a1fcyhsAOazFS7ZsfaY8NFwfTKsu4p3nABcMcGTSkqCqb5zr2xhmrSJ 5pUwyKd5DR6fEZ7C5LdqqRdXHJIodBsHww9RwNzj+PjdOVRy6FdCwH5PMkxqecHw1BJx jf0wkICW5RxJWc7sYU19ed0obhMNLO15yp8ZNdoLunCMln5GlioRCGhoaF4hxOXPUzj/ JoMwHKFocL8yFOkb0mMNGLh6zWpLKYqdxKlVTXD+Qz92tg16JwGOIdVwlrZ1+6StWaN9 BZb2++Gpc3ZxWsAZ3AL3/TWd1xldxINy+9IP8zKjvBBNM2q9vRbY30GRsCfeVgvWZCQJ fh+g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cd4-v6si20358440plb.516.2018.09.03.10.18.48; Mon, 03 Sep 2018 10:19:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730150AbeICVi0 (ORCPT + 99 others); Mon, 3 Sep 2018 17:38:26 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:42774 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728154AbeICViZ (ORCPT ); Mon, 3 Sep 2018 17:38:25 -0400 Received: from localhost (ip-213-127-74-90.ip.prioritytelecom.net [213.127.74.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id A0A0CD12; Mon, 3 Sep 2018 17:17:20 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Linus Torvalds , "David S. Miller" , Randy Dunlap , Guenter Roeck , Sasha Levin Subject: [PATCH 4.14 043/165] media: staging: omap4iss: Include asm/cacheflush.h after generic includes Date: Mon, 3 Sep 2018 18:55:29 +0200 Message-Id: <20180903165657.294513549@linuxfoundation.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180903165655.003605184@linuxfoundation.org> References: <20180903165655.003605184@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Guenter Roeck [ Upstream commit 0894da849f145af51bde88a6b84f95b9c9e0bc66 ] Including asm/cacheflush.h first results in the following build error when trying to build sparc32:allmodconfig, because 'struct page' has not been declared, and the function declaration ends up creating a separate (private) declaration of struct page (as a result of function arguments being in the scope of the function declaration and definition, not in global scope). The C scoping rules do not just affect variable visibility, they also affect type declaration visibility. The end result is that when the actual call site is seen in , the 'struct page' type in the caller is not the same 'struct page' that the function was declared with, resulting in: In file included from arch/sparc/include/asm/page.h:10:0, ... from drivers/staging/media/omap4iss/iss_video.c:15: include/linux/highmem.h: In function 'clear_user_highpage': include/linux/highmem.h:137:31: error: passing argument 1 of 'sparc_flush_page_to_ram' from incompatible pointer type Include generic includes files first to fix the problem. Fixes: fc96d58c10162 ("[media] v4l: omap4iss: Add support for OMAP4 camera interface - Video devices") Suggested-by: Linus Torvalds Acked-by: David S. Miller Cc: Randy Dunlap Signed-off-by: Guenter Roeck [ Added explanation of C scope rules - Linus ] Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/staging/media/omap4iss/iss_video.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/staging/media/omap4iss/iss_video.c +++ b/drivers/staging/media/omap4iss/iss_video.c @@ -11,7 +11,6 @@ * (at your option) any later version. */ -#include #include #include #include @@ -24,6 +23,8 @@ #include #include +#include + #include "iss_video.h" #include "iss.h"