Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <6cfb25aff666e58a376303ce02de8caa481a6599.camel@perches.com>
Subject: Re: [PATCH 1/1] docs: kernel-doc: fix parsing of function pointers
From:   Joe Perches <joe@perches.com>
To:     Jonathan Corbet <corbet@lwn.net>,
        Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc:     linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Mon, 03 Sep 2018 15:28:10 -0700
In-Reply-To: <20180903153804.2b091448@lwn.net>
References: <20180903184153.9368-1-xypron.glpk@gmx.de>
         <20180903130043.059b2e82@lwn.net>
         <b0bff870-c3c1-20e8-6609-f93f59da8624@gmx.de>
         <20180903153804.2b091448@lwn.net>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 2018-09-03 at 15:38 -0600, Jonathan Corbet wrote:
> On Mon, 3 Sep 2018 22:29:00 +0200
> Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> 
> > > >  	    # pointer-to-function
> > > >  	    $arg =~ tr/#/,/;
> > > > -	    $arg =~ m/[^\(]+\(\*?\s*([\w\.]*)\s*\)/;  
> > 
> > m/[^\(]+\(\*?\s*([\w\.]*)\s*\)/;
> >            ^
> > Here we allow for 0..1 asterixes.
> > 
> > If there is no asterix it is not a function pointer. Why should we care
> > for this case?
> 
> GCC seems to allow that asterisk (asterix is an indomitable Gaul :) to be
> missing; not sure if that's officially allowed by the language or not.  I
> also don't know if any code in the kernel elides it,

Many typedefs for function pointers do not use the *
Dunno if there are many others, I didn't look hard.

$ git grep -P '\w+\s*\*?\s*\(\s*\w+\w*\)\s*\(\w+' | \
  grep -w typedef