Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2115203imm; Mon, 3 Sep 2018 19:48:54 -0700 (PDT) X-Google-Smtp-Source: ANB0VdagZZBoDQeRsH/Gs9ReZmDZ5fAmkCHHqxzzHE7rMkWy2+fgl6AlggBIycOzYzvPYr6xdsmX X-Received: by 2002:a17:902:8541:: with SMTP id d1-v6mr31789682plo.81.1536029334844; Mon, 03 Sep 2018 19:48:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536029334; cv=none; d=google.com; s=arc-20160816; b=j0WU/LogOulvSWsCuWQg33IAH3ty3h2P/DykK/reVi72MOLjF1PYxZy80oZXn7LCfN 4h9xriDVm0u/FoquwOY3p9AS+k7Dhy8hb/tKLhelCIbgUEBj3CloqK7NsOxYRewhtKzV DKLyECrIlo/1a1rzfLdW/ot5RUEBnEp2JheJI2xJsS1YwLaQCwn6CGDE3NPc3RUTlBWg 6hImexwxensSIni+zL7lUr5sEmWa9wGieBItMzkgh9ocrebufgi0QzSu3SHCnC/fSIyq 2lTVUGvdpcGIfUELFc+IILdBZfql8ZVQleUwzE++vC6SfLiwdys5274HnLfTeb3Up2BQ g4vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=tIm6EZtwcTj/6K07q+OAE3PS7sJKQ7sQ+h1iaHX1x3Y=; b=RhMuXIrb7juWfhwB4TU7/GqawEARt2QPDixwFZ8qnkBc3MCtEDQaHIs/mC/SlbedKq 7PZYNX1yUi+FU6ZG01IsnT/YbyLnSAub2alRw2HkMLI3+9/MZO/al4pHWwsOMx7eKQP6 15ngHLO8y9pwKInXqHzMSFsjEDhH59YRhbJLPdOKtFfmzM6Rkt6itmYn5SSCq1TVTpjs slQoC2KMYijB7BCoQr36iu1CSuAPF3BQMjxHfyqJ8oDNZGwMmb1nkUDU1qHnxFYEgr87 a6r48Mmv4h2kwE1Tp7DAlF211j+a++JRGWD4DjQDsFoLsTMTugZo8gCw2qwgRqFquPbl VEFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="H/H3Tkp3"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i135-v6si17524155pgc.154.2018.09.03.19.48.39; Mon, 03 Sep 2018 19:48:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="H/H3Tkp3"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728055AbeIDHJh (ORCPT + 99 others); Tue, 4 Sep 2018 03:09:37 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:45487 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727156AbeIDHJg (ORCPT ); Tue, 4 Sep 2018 03:09:36 -0400 Received: by mail-pg1-f194.google.com with SMTP id x26-v6so873381pge.12; Mon, 03 Sep 2018 19:46:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tIm6EZtwcTj/6K07q+OAE3PS7sJKQ7sQ+h1iaHX1x3Y=; b=H/H3Tkp3uHiVEimPfiHOldaIHZ+9vgFJbNLaWIZwsJMXYQe3xgOiX9qvsHIJh96KSR 460oFGHEhBNxbZQB2gljH7ub1xrfGuoqfDIRTSO4/7UZLyZqPLo+i9PUor6MigvqfEJg mJyJr8lW8/SJMCtYUznXQ2C2/yD0gPJ4ANXyd7DOiOlRMicuGe1rGmxz113QkausZDjn JeN349FcTBx48VunsQMKZvhMKDi4qw/FQQ7k0pcmvIyjm5OsxcxveQY8l/xrRp2CxjtB AaKsf9LR7aBIjxYAKflDwvZiNXJUpA+Tfw5bvQerNV7RIA9i+4ymP99mK5I4ilVArHwW gUAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tIm6EZtwcTj/6K07q+OAE3PS7sJKQ7sQ+h1iaHX1x3Y=; b=fnkes1vSbRpg30/fzpY/vMHrRokyTt4ckKi1S+OLtdEy1O8wWJdN/qhiZPIzOGrYdR HCTr1e8Kv+IZACrBhFG3xkvvNUphax/Y/nDY+SxXvUcl/ZQJDkWDagPtTafJxOQ8ZWlQ 2YbhNSwwiozEWoJw4AdROaHlnjx+EdgoasxovoiSGepeVld4hZPKemcZvwI63OSBP/V6 J83j0ECU15LR0ZHqaYs1UeONrpc6/bCPsU1Tj0lDkocMg10UY+mN3P8KUUhYbmQxCARI 4QhVaOzI2UsC1BBAhPX16bpnfQyDrsk7fVlT1C9PxKjVr7zjzoMIQhK++7b3F7UGi68r 1GCg== X-Gm-Message-State: APzg51DGX+FS0ndE8rXlliwFCuMUJlE9Y4OlBQl4NEFDx4Bc0uth/J2b OwzOmE+OUZwicH9Ta/cToow= X-Received: by 2002:a63:9809:: with SMTP id q9-v6mr28648150pgd.58.1536029201118; Mon, 03 Sep 2018 19:46:41 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.46.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:46:40 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Jiri Slaby Subject: [PATCH 22/25] tty: nozomi: Change return type to void Date: Tue, 4 Sep 2018 11:44:48 +0900 Message-Id: <1536029091-4426-23-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since tty_standard_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- drivers/tty/nozomi.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c index fed820e..479583d 100644 --- a/drivers/tty/nozomi.c +++ b/drivers/tty/nozomi.c @@ -1555,13 +1555,11 @@ static int ntty_install(struct tty_driver *driver, struct tty_struct *tty) { struct port *port = get_port_by_tty(tty); struct nozomi *dc = get_dc_by_tty(tty); - int ret; if (!port || !dc || dc->state != NOZOMI_STATE_READY) return -ENODEV; - ret = tty_standard_install(driver, tty); - if (ret == 0) - tty->driver_data = port; - return ret; + tty_standard_install(driver, tty); + tty->driver_data = port; + return 0; } static void ntty_cleanup(struct tty_struct *tty) -- 2.7.4