Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2115575imm; Mon, 3 Sep 2018 19:49:51 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbvOhMn15lM17cu1ngZYca3R+LmYEK1aEusyaw/aQlQL9KZ1kSbeGdMLOMAsWscFsNuU8YG X-Received: by 2002:a62:5882:: with SMTP id m124-v6mr32613272pfb.249.1536029391785; Mon, 03 Sep 2018 19:49:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536029391; cv=none; d=google.com; s=arc-20160816; b=nhie4D53WKb4yCVspLsw2fOz5nufD/elOhMsCZNBnPQMw7NCaoUhgVu18QIxQ8xOxN DKOGPM+o9eq4am8VUBOynE+EXDJ9LHEScRl2iSfXq4qxkdYtGKu1z8QsQy8vu/OBcbKd fnw7oz08NeQBCtqdJ7AZgiFpxRCTOATDpV+O0/zEDJmMuMlY3m88/Rtg0S9F4FdWUMAm eQzSzmFt8Nqb0hBQXHsQ0+NK4LA0wEvhzHRF3E2dMKt889M9I6DfKAVzKF0LrVVSiv1s KYUgsGxskdzVyEVDyEpiJGON9vcwq0MnOVm03BXv3baX3CsUc3951MMxn2OFaqoIIfoE vTSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=HF0PCC9uCoqxnQ9gpvOU6TDEMKqHeKkM4XeDXQDJXAM=; b=f62QFH00R0farWu1x3yMbMzcH7sTlNWfh54af9+9PjXK9L5E20v/TzlkjEjJkGLtp/ CDXDB/bkCC/Yiaff1UapsIhdygwK5SSmP7SxSB7jntDL4HHGTA7fxlcOCvGweln0+4R5 UW2D9HrH3qLVOch5MU94qLy5FFy0I72yzYsByx/zkdiFcGkwO+GoKmdvTDeD+qlDsOBo XD0dC2mckkmu+d81+IvPNwWCfYsa41wCqq4eXI3/c5JXVa6tKY3xGxRf2WxDzSoFjzP5 miOYIKXBt+y9D9/5o0okD05njmlBalRRclWF/e0cI5cBJHoeQm67OvL7Ni2Cj896yVDI 6ZuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QaY3Jg+L; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u18-v6si19470035pgo.142.2018.09.03.19.49.36; Mon, 03 Sep 2018 19:49:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QaY3Jg+L; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727735AbeIDHJA (ORCPT + 99 others); Tue, 4 Sep 2018 03:09:00 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:38719 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726295AbeIDHI7 (ORCPT ); Tue, 4 Sep 2018 03:08:59 -0400 Received: by mail-pf1-f193.google.com with SMTP id x17-v6so911470pfh.5; Mon, 03 Sep 2018 19:46:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=HF0PCC9uCoqxnQ9gpvOU6TDEMKqHeKkM4XeDXQDJXAM=; b=QaY3Jg+LUbi6LQ/aa33tuRoTX/1JjEd63W8B2TSxWEL5lJ9KIpQD5gqrtHlt3vxnMO dkDNbosJk4FTRKImHBopXlCVuo0WJhPiGAkd9j1VhVNi3nt70gqrZUygbygxT9dPsOE8 6gkWuI0CAvYU1CE4NUzK4cQLbqNzFZiojdzR4JvhQP51Mw+r/t0E5Xl4UPJqz1pTmvqM /m/RFtkfGSGGIFDNDtJZGrb2yWWCVsUNCoC/ZJ8bQj/KAafbDyDVZ8olNfuy9viHt5/7 QQU/z+5fQ/Cjh2wSF2XGIU5fNMiSfnvKrM49z4nu5uXu6WCrztkdaQFUQ1LMGwW2dOxc RyxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=HF0PCC9uCoqxnQ9gpvOU6TDEMKqHeKkM4XeDXQDJXAM=; b=cwl4VJLiXayklQJOKorY9URvvS/SP0vcwviEB2PKJgcnDfVU25MkKZUFJvjybm+JJV dQ4S/aI7aoH9f2iXBwIPVmo7LUhaCGE+PcLQYFldVGPrHQNtEVBtZrueagA59B3oyGvH pZWqhA/2K/GIIoZLri6UX7IJWk5Tc/Io1yvab4DEb2BoG7t0vWXp/8bv5YtWd5VrhSnl /fOecyVGALihxAUF+Tv9egnXJq7SozylitvZT2xIQXzx3vidHN9grGuNVNmYsTQIt2tY XuKLsX2GkJlItGm0zH+mwRl7g8k2nI6K5YpsTo87ky2KPnHBQBIBRVsRq55rKyKcEunL NRnQ== X-Gm-Message-State: APzg51CpfGsSi2Qy/WqEo4tQQ/LTF3wdk6o/x5Bo4gE97Rq/FNlJr9BX 4rX4uPJJFrmgiJCLJiDn+RI= X-Received: by 2002:a62:7a01:: with SMTP id v1-v6mr32385003pfc.153.1536029163682; Mon, 03 Sep 2018 19:46:03 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.45.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:46:03 -0700 (PDT) From: Jaejoong Kim To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Jiri Slaby Subject: [PATCH 14/25] Bluetooth: Change return type to void Date: Tue, 4 Sep 2018 11:44:40 +0900 Message-Id: <1536029091-4426-15-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since tty_port_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim --- net/bluetooth/rfcomm/tty.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/net/bluetooth/rfcomm/tty.c b/net/bluetooth/rfcomm/tty.c index 5e44d84..b654420 100644 --- a/net/bluetooth/rfcomm/tty.c +++ b/net/bluetooth/rfcomm/tty.c @@ -710,7 +710,6 @@ static int rfcomm_tty_install(struct tty_driver *driver, struct tty_struct *tty) { struct rfcomm_dev *dev; struct rfcomm_dlc *dlc; - int err; dev = rfcomm_dev_get(tty->index); if (!dev) @@ -725,11 +724,7 @@ static int rfcomm_tty_install(struct tty_driver *driver, struct tty_struct *tty) set_bit(RFCOMM_TTY_ATTACHED, &dev->flags); /* install the tty_port */ - err = tty_port_install(&dev->port, driver, tty); - if (err) { - rfcomm_tty_cleanup(tty); - return err; - } + tty_port_install(&dev->port, driver, tty); /* take over the tty_port reference if the port was created with the * flag RFCOMM_RELEASE_ONHUP. This will force the release of the port -- 2.7.4