Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2126191imm; Mon, 3 Sep 2018 20:13:58 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZpSijNw6jQX4Ffg+Dk20Yzbcepq8j+kff7BQ3cPdVN9HmhbXLHwExTxvHkhxkaTbJetp0V X-Received: by 2002:a63:c347:: with SMTP id e7-v6mr29583222pgd.240.1536030838472; Mon, 03 Sep 2018 20:13:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536030838; cv=none; d=google.com; s=arc-20160816; b=ICKfiypVAT7tyqZ5G7oi4ozAtFaOsuw/egNz65dJO0ZtXSlsv+4QyQwsaf6WZBOexm M6N8vOj6J8lthHCvgfMv0Rmo7aM3gxR7lhBFI0TOdOMuaXFOH5uYc07tgKM6D5AzNzf8 oMJMBIEJKe3SEXWV0x/cAQqQSDsskXZaDnjQ87DKESVMz7HBaztvh+hZV7l0oKFO3AT7 iReW2HzdSgSGks0bCIIuxfforG5b+9Xc28yckyGEd7AHkrD3yNfHA31clfygodUbyeNi Yl22c8HS2mLB32CDBoi00/o6f3WEIPgYwXC1k0AKStd5xKFKZvk0MTFG3z95WYeelzHg BJzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=Jh3oiuthoRCvTV33QReAUz+4EZDRg63Ld/Q4XkprJzU=; b=mKfdSaLPpWg0G5ZkEM+0sT754OoUaweyaDj1liqz5XmrqhUrOYqVSJ4bhxaQpILmxd ticxDp+jWx7eLKUrxUoRREtF2Ys4NDQbADmativv0ud5h7eQafsCyHyrPfwGz3bWXCC/ sK1ty8qxKOX9GmZYhc0bovTiOvlIH7p+0AWPUxqAvptH63JkyDiIpftRoKYJ2w/JD2/a mZ9zVbWoLaLEJd7/WZbOjtVMwr2oNPdCiUpZlYclNqU3etHQ5jmCsWcRQLtt7DZ5+JTj pWU73EjiCjfXynXI8wJShWAKtMqc5ABxjK1PkgOVSMv6FNMUReaWwUblpemPHDhd1pAE 6ZQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Z6y7IuLR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 19-v6si18378342pgy.577.2018.09.03.20.13.43; Mon, 03 Sep 2018 20:13:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Z6y7IuLR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726520AbeIDHeg (ORCPT + 99 others); Tue, 4 Sep 2018 03:34:36 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:38123 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725990AbeIDHeg (ORCPT ); Tue, 4 Sep 2018 03:34:36 -0400 Received: by mail-pg1-f195.google.com with SMTP id f4-v6so919881pgq.5; Mon, 03 Sep 2018 20:11:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Jh3oiuthoRCvTV33QReAUz+4EZDRg63Ld/Q4XkprJzU=; b=Z6y7IuLRA5TR/7UdbGynkXE+0O1g6vt4nq42k8aGqQ8WzAOSyb3vmw7tB4H0HaeArV muHDoTAqQJnEEWXENp2Ny6Bl/ww6mHZ0TQJWcLeIrTgCGriKS2h3fA+wVsMZ+2UzXKgj OYx/yc1mLgEvYNomaiK2bG+woSrCuCJiOxU1m59aoWuHYsvnfCyHFgPRtFIkJ9RyBlEi EYrMLlsB/bUdVkWPQmA3O3PNv2SZI+qFJkHBB3RHP6kWKcPnyXWepsQHiIhdAzJLhNZS PdRBztUm/k2PwTOyCXRIwojRREkl+NXeY4nSWoPv1RyYUWvWGtTvx67jFqgZYxbl/uC8 pt7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Jh3oiuthoRCvTV33QReAUz+4EZDRg63Ld/Q4XkprJzU=; b=gBGJkMsyd8Knsl1zsk30NFLP/gaoV7WVkwn+zoqaPoCSdm/gT2WD1EFRyHkDbmQ+YV SJsFQD7vRPkYSlp2QQpcwTYPaL8BNiSvuoLoCMfetItLoDE9uiRZx8pQT0HewBTNEgYc JGFenfh+qLf+VkEERHrGFtSH66E9UD87vVbcokDZWLiwouK3VyyI5nFOyFGDKRt6hzuX hpGLAAni6ryAPxCCiCJCYccNMt84KD69W12Y6BkcdbrsiPDj0IVtm54ZxfKRhUGbsISG g+BzuTHZAUKUwdgoFEPh0Ka2nag8aW7yKy1nEEGQZKdqQ5hbCBOlmj/lZ+q6uSG5NOxZ CXsg== X-Gm-Message-State: APzg51AnQz4oAoUolVH0+4E1Db0Sq9Jt9A1ufoUbpzf3dRxx6xtd5h2g G3MTjN0xUruUY3LAW84AMKA= X-Received: by 2002:a62:5047:: with SMTP id e68-v6mr32194188pfb.157.1536030695289; Mon, 03 Sep 2018 20:11:35 -0700 (PDT) Received: from dsa-mb.local ([2601:282:800:fd80:1145:f235:fa5f:50ca]) by smtp.googlemail.com with ESMTPSA id h4-v6sm32434526pfe.49.2018.09.03.20.11.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Sep 2018 20:11:34 -0700 (PDT) Subject: Re: [PATCH net-next v1 3/5] ipv4: enable IFA_IF_NETNSID for RTM_GETADDR To: Christian Brauner , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: davem@davemloft.net, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, pombredanne@nexb.com, kstewart@linuxfoundation.org, gregkh@linuxfoundation.org, fw@strlen.de, ktkhai@virtuozzo.com, lucien.xin@gmail.com, jakub.kicinski@netronome.com, jbenc@redhat.com, nicolas.dichtel@6wind.com References: <20180903043717.20136-1-christian@brauner.io> <20180903043717.20136-4-christian@brauner.io> From: David Ahern Message-ID: Date: Mon, 3 Sep 2018 21:11:30 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180903043717.20136-4-christian@brauner.io> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/2/18 10:37 PM, Christian Brauner wrote: > - Backwards Compatibility: > If userspace wants to determine whether ipv4 RTM_GETADDR requests support > the new IFA_IF_NETNSID property they should verify that the reply after > sending a request includes the IFA_IF_NETNSID property. If it does not > userspace should assume that IFA_IF_NETNSID is not supported for ipv4 > RTM_GETADDR requests on this kernel. Can only use it once per message type, but NLM_F_DUMP_FILTERED is a flag that can be set to explicitly say the request is filtered as requested. See 21fdd092acc7e. I would like to see other filters added for addresses in the same release this gets used. The only one that comes to mind for addresses is to only return addresses for devices with master device index N (same intent as 21fdd092acc7e for neighbors).