Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2127132imm; Mon, 3 Sep 2018 20:16:06 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYssN/MyCOosE0K9ZBtga3pOPahVBdyA0U3SGUp73s0exUQw0yl5UzoGJt9/vPCPpV6jFiy X-Received: by 2002:a62:1544:: with SMTP id 65-v6mr32475924pfv.178.1536030966228; Mon, 03 Sep 2018 20:16:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536030966; cv=none; d=google.com; s=arc-20160816; b=T4iY08qIdLUGTrs0IsmVoboQ6cIhmLxzdwMTNIiMTnZ0Ie2GKvRFK48g9VGRgBHzBK dSNG5LnHmL/duoaoKXN/2THyteHbDhrItOoczCSFTSZNWaLBF/hsT2Z0uebCdB0uAQdz HSnSN3xxSHyfttSyZmF0B7kbYc4v9c0LXpRWEX2sAN5eO5I8F/a0QRCG0mYmqM6enkKJ YWfHX1DCapQ7keka71sdRnY55wj/f0M2Ufv1kIsk+3+tHUmQKNzjdpauJTXzLDaApHAX wSgep5/JAC9nd7WvNDsOLD57QobZwVVIARXxTBosx5UZt9am14r1su/AzjdBYyy4DHbG S6Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=pwcz/ffjs0Aas/fCQBXg5J0w7ohCYvjZ+MUYX7nDhj8=; b=jvKicePR5ls94Mfe4K9UZz/6pLt3b6XIh8OlIj8hLGlWFMCbQcSgp/Ixw1fm56HtkT 0igFviMw6YNiMIXBgvun+822c4sLTj8lO727tPfpaCgkP78eMn+TtlAif9gBghvUsFSb 8jM4JL5i16/YrwBgHlKEQgDQtUpo7h4CpNqqRMzOjhxax/UTtePQgT5i+OKSotSgJxdU nJl8cfU909aEVs/wzQlr4J2NU69XWgTxqAq1HUrxWoka7Ls8fam1bvzVK7eQW99Zq3SA c4bnTc7rDuEBWntEmUrcqntc5pBLWMrrwVC25EqvDzOEXN5OW2qgmMrKpJB0DlEK8aTe IFtw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 19-v6si18378342pgy.577.2018.09.03.20.15.50; Mon, 03 Sep 2018 20:16:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726157AbeIDHhr (ORCPT + 99 others); Tue, 4 Sep 2018 03:37:47 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:38666 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725990AbeIDHhr (ORCPT ); Tue, 4 Sep 2018 03:37:47 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1fx1n2-00075Z-CS; Tue, 04 Sep 2018 11:14:04 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1fx1mI-0001jF-9K; Tue, 04 Sep 2018 11:13:18 +0800 Date: Tue, 4 Sep 2018 11:13:18 +0800 From: Herbert Xu To: Kees Cook Cc: Eric Biggers , Ard Biesheuvel , Giovanni Cabiddu , Alasdair Kergon , Mike Snitzer , Tudor-Dan Ambarus , Andrew Morton , Thomas Gleixner , Geert Uytterhoeven , Arnd Bergmann , Will Deacon , Rasmus Villemoes , David Woodhouse , Matthew Wilcox , "David S. Miller" , "Gustavo A. R. Silva" , linux-crypto@vger.kernel.org, dm-devel@redhat.com, qat-linux@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 5/9] dm: Remove VLA usage from hashes Message-ID: <20180904031318.47jc3jrxcdjeac5y@gondor.apana.org.au> References: <20180807211843.47586-1-keescook@chromium.org> <20180807211843.47586-6-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180807211843.47586-6-keescook@chromium.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 07, 2018 at 02:18:39PM -0700, Kees Cook wrote: > In the quest to remove all stack VLA usage from the kernel[1], this uses > the new HASH_MAX_DIGESTSIZE from the crypto layer to allocate the upper > bounds on stack usage. > > [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com > > Signed-off-by: Kees Cook Can the dm folks please review this patch? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt