Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2218123imm; Mon, 3 Sep 2018 23:40:50 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZFJQIvdlRhL2/UPD9Cxl3IEgnwtTNC1p7bQcAmJ6nf2xflBl8f7tfw1SQegRXmEBIPb5gw X-Received: by 2002:a63:f414:: with SMTP id g20-v6mr15353433pgi.407.1536043250146; Mon, 03 Sep 2018 23:40:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536043250; cv=none; d=google.com; s=arc-20160816; b=qebLJGe5cTNr0CjvaMxZeO2K+RzVmN7cpk+q6la/cnO7WgfI5iRWsUx+oqLXfra/pM nBkWKdi9SAPFgMIlCwwELZWXrkY3MZr08Wy+DqMvAaeCG/I7y7OBEe/6pyZ+fTz0bri4 RS2UPu4ufURALByq7CepPP7r6T4xP8oiWze9s89d/0kPd52enAL5DQhhJ6xVERfmCeGo IZOEfG2G56cD89L9y+p8OgBJYZfTxAM8SD/eS4Jx21VsvFPDRH17JcIr3QQjSEGvK/Y6 1DXU44vWE9MRXyy/X3+4wSb5qilS/UAx+yKVIlBOSVGqSGUMrpsBqnDDQME+jWRWBY4E mO+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:user-agent:in-reply-to :content-disposition:mime-version:references:reply-to:subject:cc:to :from:date:arc-authentication-results; bh=UZxduSkK8V9yJ5aGsbz3qHCiXQmSvcJRGX57QGciaSY=; b=p4FiLoMD8Qu2ShU+3zu3abQNc8iHdwPrUbFanlk1j29DH1f26vBwFzzOpT4j8EJ6bY MJuOzciVfWyIM2ZqRynXRrVhKBFQr67Rr2b8//0XkQCrmdQFfHHKyZIn93O/1ECuiJti TUpr9YZSN7jdfhoYe/e42vRdLf7KeDn5MGFwOVGNJCbBOGu3vakczemOBXWKScTlfu7T WXyeD2LQtbdHneoYQ6c/TH1GBGXoXAqIj7az+vF6vxEjfNywvz7jC/EgbSDzyWC3/0Fu caIWXPa0u5R72fozX3swc4RlrrMQjyuMHlKt7k83iDGvzHFn+OKisoOm6jV3JLUIE/qA jWZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f16-v6si17279094pgf.474.2018.09.03.23.40.34; Mon, 03 Sep 2018 23:40:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727542AbeIDLDC (ORCPT + 99 others); Tue, 4 Sep 2018 07:03:02 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:58100 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726016AbeIDLDC (ORCPT ); Tue, 4 Sep 2018 07:03:02 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w846dKGx100876 for ; Tue, 4 Sep 2018 02:39:20 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 2m9k63c348-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 04 Sep 2018 02:39:20 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 4 Sep 2018 07:39:11 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 4 Sep 2018 07:39:09 +0100 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w846d8LF42991696 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 4 Sep 2018 06:39:08 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 49A6411C058; Tue, 4 Sep 2018 09:39:01 +0100 (BST) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 46AE511C04A; Tue, 4 Sep 2018 09:39:00 +0100 (BST) Received: from linux.vnet.ibm.com (unknown [9.40.192.68]) by d06av25.portsmouth.uk.ibm.com (Postfix) with SMTP; Tue, 4 Sep 2018 09:39:00 +0100 (BST) Date: Mon, 3 Sep 2018 23:39:06 -0700 From: Srikar Dronamraju To: Vincent Guittot Cc: peterz@infradead.org, mingo@redhat.com, linux-kernel@vger.kernel.org, Rik van Riel Subject: Re: [PATCH 1/4] sched/numa: remove unused code from update_numa_stats() Reply-To: Srikar Dronamraju References: <1535548752-4434-1-git-send-email-vincent.guittot@linaro.org> <1535548752-4434-2-git-send-email-vincent.guittot@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1535548752-4434-2-git-send-email-vincent.guittot@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 18090406-0020-0000-0000-000002C0CC27 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18090406-0021-0000-0000-0000210DEFAB Message-Id: <20180904063906.GA61288@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-09-04_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1809040070 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > With : > commit 2d4056fafa19 ("sched/numa: Remove numa_has_capacity()") > > the local variables smt, cpus and capacity and their results are not used > anymore in numa_has_capacity() > > Remove this unused code > > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: Srikar Dronamraju > Cc: Rik van Riel > Cc: linux-kernel@vger.kernel.org (open list) > Signed-off-by: Vincent Guittot > --- > kernel/sched/fair.c | 21 +-------------------- > 1 file changed, 1 insertion(+), 20 deletions(-) Looks good to me. Reviewed-by: Srikar Dronamraju -- Thanks and Regards Srikar Dronamraju