Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2311830imm; Tue, 4 Sep 2018 02:09:21 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZy4VWMZ+XbNdGH4m51Onqmti4LI0cCEMx/qOFc54e4m53ArXbP8LZBQgndOOUECD0XSaOQ X-Received: by 2002:a62:586:: with SMTP id 128-v6mr33955754pff.80.1536052161309; Tue, 04 Sep 2018 02:09:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536052161; cv=none; d=google.com; s=arc-20160816; b=KrJlMLPoO5XAtkcXS/DQDnfzF9YVRjeluHOgnZNUTna2K20zW5a3lOG6S+t2prXd0p ktofCzm9vKjB9ddcTYQKr92FWuFjErNdaDE6P1fcRzWukCdgBUo576RDUjX648P3VLqK ilClab5FRclTlnTqlEgMqHf1QDXYZ2oBJU+cBz2Na9Sh7UdDu9lHuBZeW8cWhdTjH6f8 Ipw0Z9Xag4Y6x2QYrqaqIXDFaS5CQBywTzs02OwhlT2LGvqjzzcxkQck12qzVT7s/hDe TAbadg4FAXI8TUhnEMUhR4SsonyFyOYeIgy5m19jWWEcNk7i4XaGLpQQEYPRZoyAQ/cp BRow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature:arc-authentication-results; bh=RoqvrdyJPnOuCbbcngTVCfjKNLdHZZFkoRzkAQfPkak=; b=EAfnG8Kc2VaNy/KFtP8td2h21HuR8t5x/Lx4YozzN4vVQlYrdmy7aw7H41u5CIrxWV Vt4BqvDT3x6/9rdYbw9FxFPlmlofAgHHQl1e06ar2FL5pxpDMKbOihGxnQMDTlE5uN21 l/biLf1xZNkk7imldVa7uhMu9gSN9gxuW34M8gJYuThSUQShkbAoprenZiFazB1UMraf pF7A62488BpBmoPAyaWJsNLu7JjiNNL8MAvp6Jj8lB3+Z7+QGHTJrq7a9qrgccTom1zX ddA7M/Pkh7ACM76nm9NYoUoilD/Y2sYRknnAdfXgLcOu95tIdzL+/H3pvZ14rQHxXDiY Aq3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=nmSN+Dl6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a9-v6si20784005pgj.224.2018.09.04.02.09.06; Tue, 04 Sep 2018 02:09:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=nmSN+Dl6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727212AbeIDNcH (ORCPT + 99 others); Tue, 4 Sep 2018 09:32:07 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:39931 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726154AbeIDNcH (ORCPT ); Tue, 4 Sep 2018 09:32:07 -0400 Received: by mail-pf1-f194.google.com with SMTP id j8-v6so1382177pff.6 for ; Tue, 04 Sep 2018 02:07:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=RoqvrdyJPnOuCbbcngTVCfjKNLdHZZFkoRzkAQfPkak=; b=nmSN+Dl6KycaM9mBY0gOAIgIQGo+zE1I+U8cM4N4eG1ayU7qMx3My7HuIJ3GhpJ/8b n6Z+Y5BFJVqYp/vZYinIhvsyrJfexJ0luhtBvltCcomw2YiA9I1zzCiHSH6qPtBmCTpn 0F9jhitZx3IswOkUBawZGn47bnqXDSRDkhOyPEMtamltqE/JSP6vlAzS7Dw7I15KGHT3 7ndlzaNkgDAzi+j16OJW81vMgx3gWJZ23WxH0NrMDux41SxtzCD7y7RT2qA+LI28g8eJ rwIP30LmGMTrxqiSrzdgALWMdWRsLOOYiLJipXCUdaqXPNEUCbJJq5Vev6coI+6Ex9dZ exGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=RoqvrdyJPnOuCbbcngTVCfjKNLdHZZFkoRzkAQfPkak=; b=Q0mD2CkjFtuxCQ8GI7FxGhATA5jcfEVg1HHGMsULxktjv446wXOUY6xiWo7zRxaRM7 4+pRoKmViwK50oDElg45dU5swOLRMn+GlOjttWgsn/jTHb+udNw9HVtGFPyAJvnzXHmz y9hjDce8zSIy7Sm1ssKEvD3W41Vqpe3l6/hvM67mvkXUemuGFGpHAJqvCo29aWBVOoh7 HuoYJYyX9NmDizMEY02C3NRsrbHgh9ZcHf2GJr4NpgTJ27Bxf+ln0kwEAZLN+QWsio88 83lh9hL37dI5Ii/9D+BRkX+p/hSpmmmvgGWYWxiandQj6VmCkrQNXVDwEBz+4cXLotaX Y6UQ== X-Gm-Message-State: APzg51Bil5Cpxyr4x7lfC6AhC035LXK2yPdCV3VArI6/avegbo6WylrX NpCiDjUKsEmZaNbLALnABZl7Ng== X-Received: by 2002:a62:5d03:: with SMTP id r3-v6mr33945752pfb.150.1536052074608; Tue, 04 Sep 2018 02:07:54 -0700 (PDT) Received: from cakuba (apn-77-114-125-170.dynamic.gprs.plus.pl. [77.114.125.170]) by smtp.gmail.com with ESMTPSA id t17-v6sm41865145pfm.138.2018.09.04.02.07.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Sep 2018 02:07:54 -0700 (PDT) Date: Tue, 4 Sep 2018 11:07:45 +0200 From: Jakub Kicinski To: Taeung Song Cc: Daniel Borkmann , Alexei Starovoitov , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf-next v2] libbpf: Remove the duplicate checking of function storage Message-ID: <20180904110745.3ab4dc3e@cakuba> In-Reply-To: <20180902233007.3003-1-treeze.taeung@gmail.com> References: <20180902233007.3003-1-treeze.taeung@gmail.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 3 Sep 2018 08:30:07 +0900, Taeung Song wrote: > After the commit eac7d84519a3 ("tools: libbpf: don't return '.text' > as a program for multi-function programs"), bpf_program__next() > in bpf_object__for_each_program skips the function storage such as .text, > so eliminate the duplicate checking. > > Cc: Jakub Kicinski > Signed-off-by: Taeung Song Acked-by: Jakub Kicinski