Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2328624imm; Tue, 4 Sep 2018 02:31:10 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZ26e5KGJJ/JG8r2nymoYmB18tFRubWbL1UOHJI0Xxo64xi5VsHS0xMJRjg1AKr+JEyWf3g X-Received: by 2002:a17:902:47:: with SMTP id 65-v6mr20128225pla.293.1536053469943; Tue, 04 Sep 2018 02:31:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536053469; cv=none; d=google.com; s=arc-20160816; b=QBrSklXRYPyvaJzlJER7kphImcV02AhCi4PbLzcAr6zal7mOvE6NfxN6dk7mcC5hSo Sa/9qjcFbL9pEeFMByu+YGNBs+OFIeTXKtu3X+MC7EYV+XG6SiSVZSWbmnFAzAEVqBcG VXC8kyQhcwMKBaApI2Y8GzDvbXd7iASv7zx7rTDhI9wgQN1G8DU/ecd++a8Md8jyeAz9 TakTFOyRlU3lwWFaEfE740Qfl8QWkVOwUEsjwpxQWKip5WppqI+UjkUlOekdZLM57RJy /l57ZGasVl/Nn7g62i/5bGABiRyh+aZB2mUP8hg6Er7C0twQShlOiqCynyEDaaAvKq6U z3CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date :arc-authentication-results; bh=9twnM20SEFhQ9bBt+tmpGInwnTRfLxZ6IoTMUbva6sk=; b=vbqNY8RlofsJOZ2vqhAu6G3NQajN4hqf9uY7u0lWBJ7pPrc35Y7ucMA8PPQsDmerVL IYTriqxEePaiH+P8RFPtPph7ER5uWvAAJvSB/B0dKmz2xCfbXJGeOTlpQn6UolnCsoYT U/bAF+y8KGw/rVxBIFVBdwoGX/0UnzqXAH/lQkUbhAS28ZJmxT3yENPLCs/SKQgv3qHz fLKT4h83bRcmha5dRrA1VZsxafsvqtffNUYzfjYsZA7tnTWTYk7cqxFxBXgNGi+a/gHC /H2Er1ZJWsTO5sLIP8vs60Ksn1e7RSfAp+4cc6YZrSsHq90d20arbkc1Za1E8DO5+OlB Od7g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f67-v6si21553912pfa.73.2018.09.04.02.30.51; Tue, 04 Sep 2018 02:31:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727397AbeIDNxz (ORCPT + 99 others); Tue, 4 Sep 2018 09:53:55 -0400 Received: from cust-95-128-94-82.breedbanddelft.nl ([95.128.94.82]:43930 "EHLO cust-95-128-94-82.breedbanddelft.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727201AbeIDNxz (ORCPT ); Tue, 4 Sep 2018 09:53:55 -0400 Received: by abra2.bitwizard.nl (Postfix, from userid 1000) id 99C8C13FC8F; Tue, 4 Sep 2018 11:29:38 +0200 (CEST) Date: Tue, 4 Sep 2018 11:29:38 +0200 From: Rogier Wolff To: =?utf-8?B?54Sm5pmT5Yas?= Cc: jlayton@redhat.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: POSIX violation by writeback error Message-ID: <20180904092938.GJ11854@BitWizard.nl> References: <20180904075347.GH11854@BitWizard.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: BitWizard B.V. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 04, 2018 at 04:58:59PM +0800, 焦晓冬 wrote: > As for suggestion, maybe the error flag of inode/mapping, or the entire inode > should not be evicted if there was an error. That hopefully won't take much > memory. On extreme conditions, where too much error inode requires staying > in memory, maybe we should panic rather then spread the error. Again you are hoping it will fit in memory. In an extreme case it won't fit in memory. Tyring to come up with heuristics about when to remember and when to forget such things from the past is very difficult. Think of my comments as: "it's harder than you think", not as "can't be done". Roger. -- ** R.E.Wolff@BitWizard.nl ** http://www.BitWizard.nl/ ** +31-15-2600998 ** ** Delftechpark 26 2628 XH Delft, The Netherlands. KVK: 27239233 ** *-- BitWizard writes Linux device drivers for any device you may have! --* The plan was simple, like my brother-in-law Phil. But unlike Phil, this plan just might work.