Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] security: tomoyo: Fix obsolete function
To:     Ding Xiang <dingxiang@cmss.chinamobile.com>,
        linux-security-module@vger.kernel.org
References: <1536050499-20889-1-git-send-email-dingxiang@cmss.chinamobile.com>
Cc:     takedakn@nttdata.co.jp, linux-kernel@vger.kernel.org
From:   Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Message-ID: <e8154180-666e-2541-26d9-87d3f5eb3719@I-love.SAKURA.ne.jp>
Date:   Tue, 4 Sep 2018 19:22:40 +0900
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <1536050499-20889-1-git-send-email-dingxiang@cmss.chinamobile.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2018/09/04 17:41, Ding Xiang wrote:
> simple_strtoul is obsolete, and use kstrtouint instead
> 
> Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>

Acked-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>

> ---
>  security/tomoyo/common.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/security/tomoyo/common.c b/security/tomoyo/common.c
> index 03923a1..9b38f94 100644
> --- a/security/tomoyo/common.c
> +++ b/security/tomoyo/common.c
> @@ -1660,7 +1660,8 @@ static void tomoyo_read_pid(struct tomoyo_io_buffer *head)
>  	head->r.eof = true;
>  	if (tomoyo_str_starts(&buf, "global-pid "))
>  		global_pid = true;
> -	pid = (unsigned int) simple_strtoul(buf, NULL, 10);
> +	if (kstrtouint(buf, 10, &pid))
> +		return;
>  	rcu_read_lock();
>  	if (global_pid)
>  		p = find_task_by_pid_ns(pid, &init_pid_ns);
>