Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2528968imm; Tue, 4 Sep 2018 06:06:54 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZiZn/LopScHVm2oa2BPywVT+4OFbIskSP0CPX2xSETqihVX4ZDxeJIURZe+t433TfMo2g1 X-Received: by 2002:a63:7a0f:: with SMTP id v15-v6mr10759335pgc.127.1536066414462; Tue, 04 Sep 2018 06:06:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536066414; cv=none; d=google.com; s=arc-20160816; b=L6yw2Z2FRVfa/VOfw0H18PTYTXkSWmbo8jvWPfnlIJ4FWAtLC907QP9xqfDJ8HW4M/ s/UlzZU6/GTFR4mBiqRQOp5N+XFAU/1zI77a7JDS8BbGTn7QE5CpHtk+9hq7sBVyVu11 q9jO6tJPq4PeJz7RJ8ufKBqYTBKz9laT595kTYRSkEBVbNFwqUPeJiaoOn48+hqUpQV7 JcT8gh4HB6Fny22NUK9fhUeShYCP+ToHelOKoYaFzSkyFSW1bjUefZHoyCt2tRDMTrww xtTtFgvhXfwBzEBvQrjHcCyD/8lhaLYFw52Q/gf6pVBkUISDWc3mr8OVanG/BGraqDrI HngA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=O34fx1HPHRUncuzc9YOGkUIvld0JFmlQoJJyxMg55ow=; b=c+F0FiMwrRmUPgklZGxs4kIkvVBZH1hLOHKfEaSCYj+aLpkJqLamDJ+2ZefoOmriUY F2in32PfSIyGw7BFRzwgEZRp6SZRZgMWHLzA17EbZhwhvgZusKyVL4Xl0RSmLQU/s6ze r61/5Y58QnVVZSABqB/1PcvCRy2UO9dZ3iaqxa+lYfCfBEH5YqF43C4JO+a4qGlnjmzf 6g8ISgDXBMwNdUE7InXnTj5z0xetnYCk6SpFyoLPpaMuuO8yINTKT6mZHPtIgRasyVjV z8tQ/WNGuTKgkSekOV3vhi3PCaBH72lgOx+yyQQu36Jf2Z2ThONywiNc7vss8jFrLvFX P9NA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mellanox.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z7-v6si19740599plk.215.2018.09.04.06.06.37; Tue, 04 Sep 2018 06:06:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mellanox.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727364AbeIDR35 (ORCPT + 99 others); Tue, 4 Sep 2018 13:29:57 -0400 Received: from mail-il-dmz.mellanox.com ([193.47.165.129]:46890 "EHLO mellanox.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726355AbeIDR35 (ORCPT ); Tue, 4 Sep 2018 13:29:57 -0400 Received: from Internal Mail-Server by MTLPINE1 (envelope-from moshe@mellanox.com) with ESMTPS (AES256-SHA encrypted); 4 Sep 2018 16:08:53 +0300 Received: from dev-l-vrt-135-006.mtl.labs.mlnx (dev-l-vrt-135-006.mtl.labs.mlnx [10.134.135.6]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id w84D4mna022823; Tue, 4 Sep 2018 16:04:48 +0300 Received: from dev-l-vrt-135-006.mtl.labs.mlnx (localhost [127.0.0.1]) by dev-l-vrt-135-006.mtl.labs.mlnx (8.14.7/8.14.7) with ESMTP id w84D4mk3018688; Tue, 4 Sep 2018 16:04:48 +0300 Received: (from moshe@localhost) by dev-l-vrt-135-006.mtl.labs.mlnx (8.14.7/8.14.7/Submit) id w84D4kRY018686; Tue, 4 Sep 2018 16:04:46 +0300 From: Moshe Shemesh To: "David S. Miller" Cc: Jiri Pirko , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Moshe Shemesh Subject: [PATCH net] devlink: Fix devlink_param_driverinit_value_set() stub return code Date: Tue, 4 Sep 2018 16:04:25 +0300 Message-Id: <1536066265-18641-1-git-send-email-moshe@mellanox.com> X-Mailer: git-send-email 1.8.4.3 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The stub function returned -EOPNOTSUPP while CONFIG_NET_DEVLINK is off. It caused false warning during driver load. Driver needs to update devlink on a parameter value if devlink module is there, if not it doesn't need any error code. Fixes: ec01aeb1803e ("devlink: Add support for get/set driverinit value") Signed-off-by: Moshe Shemesh Acked-by: Jiri Pirko --- include/net/devlink.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/devlink.h b/include/net/devlink.h index b9b89d6..b467357 100644 --- a/include/net/devlink.h +++ b/include/net/devlink.h @@ -781,7 +781,7 @@ static inline bool devlink_dpipe_table_counter_enabled(struct devlink *devlink, devlink_param_driverinit_value_set(struct devlink *devlink, u32 param_id, union devlink_param_value init_val) { - return -EOPNOTSUPP; + return 0; } static inline void -- 1.8.3.1