Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/2] ARM: dts: imx6: RDU2: Fix the audio CODEC's reset pin
To:     Shawn Guo <shawnguo@kernel.org>
CC:     Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <fabio.estevam@nxp.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
References: <20180831191732.25504-1-afd@ti.com> <20180903045426.GM3850@dragon>
From:   "Andrew F. Davis" <afd@ti.com>
Message-ID: <5796c470-a533-c010-ba53-7ee785a3b9e8@ti.com>
Date:   Tue, 4 Sep 2018 08:35:09 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180903045426.GM3850@dragon>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 09/02/2018 11:54 PM, Shawn Guo wrote:
> On Fri, Aug 31, 2018 at 02:17:31PM -0500, Andrew F. Davis wrote:
>> The correct DT property for specifying a GPIO used for reset
>> is "reset-gpios", fix this here.
>>
>> Fixes: d763762e3b58 ("ARM: dts: imx6: add ZII RDU2 boards")
> 
> This Fixes tag and word 'Fix' in subject is inappropriate to me, as you
> are not fixing something wrong from the beginning, but actually
> replacing a deprecated property with new one.
> 


reset-gpios was standard before this driver got it backwards, but it
also wasn't required to be one way or the other as far as I can tell, so
I can see your point that this isn't technically "broken". I have no
preference, so I'll change the subject and drop the fixes for v2.

Andrew


> Shawn
> 
>>
>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>> ---
>>  arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
>> index 7fff3717cf7c..a0f5cfda0055 100644
>> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
>> @@ -384,7 +384,7 @@
>>  		AVDD-supply = <&reg_3p3v>;
>>  		IOVDD-supply = <&reg_3p3v>;
>>  		DVDD-supply = <&vgen4_reg>;
>> -		gpio-reset = <&gpio1 2 GPIO_ACTIVE_HIGH>;
>> +		reset-gpios = <&gpio1 2 GPIO_ACTIVE_LOW>;
>>  	};
>>  
>>  	accel@1c {
>> @@ -572,7 +572,7 @@
>>  		AVDD-supply = <&reg_3p3v>;
>>  		IOVDD-supply = <&reg_3p3v>;
>>  		DVDD-supply = <&vgen4_reg>;
>> -		gpio-reset = <&gpio1 0 GPIO_ACTIVE_HIGH>;
>> +		reset-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>;
>>  	};
>>  
>>  	touchscreen@20 {
>> -- 
>> 2.18.0
>>