Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2709591imm; Tue, 4 Sep 2018 08:47:25 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdbv1jQnSM6WsMlP4NKHt3yy/zaa4ulL6ObcuM+RylCashkD29JW7gcc05NFlOny41LMJTIB X-Received: by 2002:aa7:8118:: with SMTP id b24-v6mr35638222pfi.78.1536076045359; Tue, 04 Sep 2018 08:47:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536076045; cv=none; d=google.com; s=arc-20160816; b=GZeVMrgcy+InYSDVRAsBhpcIuJLRNohH164y07yh5jDYaKI7x+APPKQpd8tF8q6xI0 FGUSljBopkGI3AgQgSa0ewv9o1fOh9pEuff/lU6zNNFvwX1ChCL+LqECrhTXUeBNNtC6 5PmRXsr5blyalCquAHGA++QH3dOeYfgtM8fXpIHZ9ezOoBuZsrf6p/KCfXQuyR0rnJWl l+feCImTy7yr0pJUVSEbWmaeg46vRFT+7kDsxzi7ruoLZeiJsoXH5nn86FkEbLi028mJ fbHLku7ywq8whofXbZPLVBs9Yu24XRD3RUHu6pTONbAK1Nw1qyFd8WXhQjAMLULBbAQM uBUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=PAbomJpd9xQilDeTTGZSP1pc/QMwnXKYLFm1aBd0XsQ=; b=JOVWGXvCB5+7h+1f4OxpDWBoiSEk08CALDszL7x/x1nSLcok4g8j8khOLHjs0QO8Cm RyLRlWx/b0gqiJhK5TMsvnSJRAzS/BleBL3ES1KH8fP/oD8E+u2HtY5wQxet4PqFNUuZ 6R7fLVAjDM63/zHsIOC8fJ7Cy4QorVd8kU77PDE2B99f7xxPuMJBMcIeA2ynof+GTjWW VGpYob/G3bsVVeTNuXYPOTp1oOE0J/ufX6mWKEO/DdQZ8JzzPPRWofHMxup6mkfEahA3 JuXYuN7vIaBYEg/5lhmXRRVMQhYZYHJKOGZcnOL/psKOIjV4bUzr2DlmNpiQE8I9Xpmx eSVA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j8-v6si19491028pgp.548.2018.09.04.08.47.09; Tue, 04 Sep 2018 08:47:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727505AbeIDULk (ORCPT + 99 others); Tue, 4 Sep 2018 16:11:40 -0400 Received: from mga18.intel.com ([134.134.136.126]:24310 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726367AbeIDULk (ORCPT ); Tue, 4 Sep 2018 16:11:40 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2018 08:45:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,329,1531810800"; d="scan'208";a="80787747" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.20]) by orsmga003.jf.intel.com with ESMTP; 04 Sep 2018 08:45:53 -0700 Date: Tue, 4 Sep 2018 08:45:53 -0700 From: Sean Christopherson To: Jarkko Sakkinen Cc: Andy Shevchenko , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Platform Driver , Dave Hansen , nhorman@redhat.com, npmccallum@redhat.com, linux-sgx@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , suresh.b.siddha@intel.com, serge.ayoun@intel.com, Linux Kernel Mailing List Subject: Re: [PATCH v13 09/13] x86/sgx: Enclave Page Cache (EPC) memory manager Message-ID: <20180904154553.GA5412@linux.intel.com> References: <20180827185507.17087-1-jarkko.sakkinen@linux.intel.com> <20180827185507.17087-10-jarkko.sakkinen@linux.intel.com> <20180904153803.GC8344@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180904153803.GC8344@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 04, 2018 at 06:38:03PM +0300, Jarkko Sakkinen wrote: > On Mon, Sep 03, 2018 at 10:02:16PM +0300, Andy Shevchenko wrote: > > On Mon, Aug 27, 2018 at 9:58 PM Jarkko Sakkinen > > wrote: > > > > > > + WARN(ret < 0, "sgx: cannot free page, reclaim in-progress"); > > > + WARN(ret > 0, "sgx: EREMOVE returned %d (0x%x)", ret, ret); > > > > I'm not sure (though it's easy to check) that you need sgx: prefix > > here. WARN() might take pr_fmt() if defined. > > Sean, you took care of this one. Was it so that WARN() does not respect > pr_fmt? Yep, WARN() doesn't respect pr_fmt.