Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2721238imm; Tue, 4 Sep 2018 08:59:46 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZdBJyqGGMXRZZ7mcPyvesx1c9hFylhuJkvASNOSaWebf2JSupasbH0LSCNPj3C1C252GE0 X-Received: by 2002:aa7:860b:: with SMTP id p11-v6mr35451094pfn.247.1536076786891; Tue, 04 Sep 2018 08:59:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536076786; cv=none; d=google.com; s=arc-20160816; b=UsBxqaReU1F82nJvxNEMZcFtS7/Y98bt4RKcfY++FJOojbiNObuJSpMp7/K5ykMJd5 PYmGwsBATIq+YKnMnTCrOGwVJ6FtUOrMPlgmsXm/UHd61yc/dD4pQ+v+hVP/UQWc1p2w 6g6EOpx8evroAW8MWavQNxkfkzX8Qq+5vzbImeN7LewpDGHvrGI8+UldMUESxuwfV2Gy 90dJJIMVqycxOmqeIlkU8vO255EhvwTD74DO1h3twowiaoYhOLUvgjsubER3acgrC/8k T2yEkxYWG8lQ8rxRSn5wP/eNR8Qz+lJmCLpcEz6G6miN3lEn5ejXwHdJf7zHy3vAP3pn SnvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=ScxoHZVTJxRH7GZpd10ouJ/6i13Ji0hmQbUFgIZXPrQ=; b=faGZ6zO6KVu3iREHWs+VuFM0V1Be9VnSAmU0oWoWEPKR6zs9WHmM0fGF3YiSgfadLX ru9Ls9cahqOh4804RjBhbTb6Ew+wF/eA0axfdEHVqBqowRzog6xshHpVo4nLzFpbtPVj ludT4uAIR5o5K+X79eCwU12AkLDw8APzywbW6wFfOKEe9gS7Faf2dpvSrU7q1Bf8kv4H Nl2irLpn+mIShSphrZoJ1VyADjTbTfZAh70wRRSXjBZrUR5rvXDvt7EXwOieoGzko2GW wjpdqhyLBHOydzSK7RepwqsjC3wndF1XYbXJn5ssCrOi64NoIw/H1jg4EL5YSQvQUtJt xXfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=GlERiY6g; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e186-v6si22466665pfa.107.2018.09.04.08.59.31; Tue, 04 Sep 2018 08:59:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=GlERiY6g; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727574AbeIDUXb (ORCPT + 99 others); Tue, 4 Sep 2018 16:23:31 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:37924 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726211AbeIDUXb (ORCPT ); Tue, 4 Sep 2018 16:23:31 -0400 Received: by mail-oi0-f65.google.com with SMTP id x197-v6so7677805oix.5 for ; Tue, 04 Sep 2018 08:57:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ScxoHZVTJxRH7GZpd10ouJ/6i13Ji0hmQbUFgIZXPrQ=; b=GlERiY6gOee5tDgJuucJ2ciOiDmaS8ZI4pr+1jyGtDgXjP6nvhJ1M3a1PKr7J3fBT6 NQs3kk7EWkImIV26ey44m/ktO0NDTDXRy8eN7WEEkynT9cA6ZRnxlTRCQfP03LU7JtfR MLRY6j1oM1wEBzlgbYIhwBpHPGYrSK5cHYhlS+LHHfg7TaGJjvKxDkKWs3l1UztO6cKI kI3UKbed2aBGKF+TcAiWnPbwuPSqn1RLJlnrEoc2aTE92ekCBpInNMMfXMFZ4KxX7QWv oU7G2vLwljv/iK+1ga6qHtPpaSRly1A1cdCo8jYPAlN58BT79Dj3VqtgzQoeOjPG8evk oMeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ScxoHZVTJxRH7GZpd10ouJ/6i13Ji0hmQbUFgIZXPrQ=; b=afZeVB0hmy1P2zjMtmNDhrKgS4AmsqvjcC3ihbN2mNfSkR5S/deEUnXS4NgFSfz6Ix l7JdDDdoQ/pFmqvqjKMFz9JZFNnYOaIln396h8oRr78Ir2PNxdl5qrhWLWTNLLDrJndW yV+5/Dv2t3vXoDH7Fh8gkv+D28DKrrInYDTAMUyjRf4cRQQfsym9dY/yW5ssQBqpilgO Fy8cY7sUUfkfAPqHTGDNhrkK99D6fRdSAdt/16mp0aV3pWMxCpWgYFu3KckstJOfCxJM uMZ9NwXnkv4dpVZt2iFf/B+UiA+My3cVtclpQqRRT8jc8zpQ7r6Z4i/VSa0EvtkAVj7E EDEA== X-Gm-Message-State: APzg51CyvTtspON4g7RsIYzLh+uB9Rrv7c9YlrRT2/phuZMEllWlObnh uEcbBMjvzXHaRwxP+DdG+13aOlw3Ok8Hnc9O8hZ/jQ== X-Received: by 2002:aca:adc6:: with SMTP id w189-v6mr17052742oie.174.1536076667452; Tue, 04 Sep 2018 08:57:47 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4a:8346:0:0:0:0:0 with HTTP; Tue, 4 Sep 2018 08:57:47 -0700 (PDT) In-Reply-To: <1536058062-18894-1-git-send-email-oceanhehy@gmail.com> References: <1536058062-18894-1-git-send-email-oceanhehy@gmail.com> From: Dan Williams Date: Tue, 4 Sep 2018 08:57:47 -0700 Message-ID: Subject: Re: [PATCH v2] libnvdimm, region_devs: stop NDD_ALIASING bit test if one test pass To: Ocean He Cc: Ross Zwisler , Vishal L Verma , Dave Jiang , linux-nvdimm , Linux Kernel Mailing List , Ocean He Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 4, 2018 at 3:47 AM, Ocean He wrote: > From: Ocean He > > There is no need to finish entire loop to execute NDD_ALIASING bit test > against every nvdimm->flags. Of course there is. I see nothing stopping someone mixing an NVDIMM that supports labels with one that doesn't. If anything I think we need fixes to make sure this operates correctly to force disable BLK-mode capactiy when the PMEM capacity is interleaved with a label-less NVDIMM.