Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2726225imm; Tue, 4 Sep 2018 09:03:07 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbtzWr4289DWbWcyiPMZ9Mfzd9MpqDy9bWHEdbG3n+z0okU5RSy3HAn4+VpHwbcC7itbGNJ X-Received: by 2002:a63:4860:: with SMTP id x32-v6mr27871236pgk.375.1536076987120; Tue, 04 Sep 2018 09:03:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536076987; cv=none; d=google.com; s=arc-20160816; b=gEXxupNG1EXJFg/D36iveiVEaIRC5KmBZ8JaYXNS35XWjF5OxvorAAv3Ys+uXNiCZc 2kNg3kbnWkJsX5TOWZOGSTsI/gnPRt1Uyx7V5RJSPU+NHNfblYwWuCjPoRbXm4AFsF2x YAUO5U4BMhQLI1ISMFYeUbuNifCMxiiS8STbO66B9+4hgfjOfsi2miH/PaPAoZggv8XX y+offzO1M/kYtu4Ej9CyalSrQVfXan4nmrbXgodLoCebyh7SQfW+Axwpk2YoqG8hfQ2l Uudu8+7d54hSr/MOqWBeUsiL15c8JtNZ71bFNeprpx4ZiWE7kmWruZKYbtyzE19DZTDl uC8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=u44cbV8DeEk9QzBkL/tb6Tc12y8G1jgyrcRrTwkauIs=; b=CLxFW48eDJNN/tMCckOW0/OCBVq1oCt4VLDLVZGt47KkcNxxhhKyBjThdfzRDRSfiT atIBLrKa9udAfxVFKFlLwEJrasCSRIFtznQNTwa8vpkYEg9BGxqv9ksHXkWefpB08As/ 7A4QN1I97SM5RFcLNm76A2gZFmO7koRALB+b5934G2hB/bS9YpDfEjZMXhVp5lFfXJms kUycfQzFslQ9QcXdFnda33gEl8H2+Ik1B8Ls0PgdSHFyb8DXmmhRowWOdxYPWf+xN5uI SQupcwrrURX00Y/zPCgzbX1Dzjv+y5RPycmlfUAfcEvH9jylRzNzSlSxo5PuFHsw2w0S msBg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x69-v6si10265347pgd.49.2018.09.04.09.02.41; Tue, 04 Sep 2018 09:03:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727808AbeIDUYu (ORCPT + 99 others); Tue, 4 Sep 2018 16:24:50 -0400 Received: from mx2.suse.de ([195.135.220.15]:51014 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727715AbeIDUYt (ORCPT ); Tue, 4 Sep 2018 16:24:49 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 2D400B0A7; Tue, 4 Sep 2018 15:59:02 +0000 (UTC) From: Takashi Iwai To: Greg Kroah-Hartman Cc: Eric Anholt , Stefan Wahren , linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 12/29] staging: bcm2835-audio: Drop unnecessary pcm indirect setup Date: Tue, 4 Sep 2018 17:58:41 +0200 Message-Id: <20180904155858.8001-13-tiwai@suse.de> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180904155858.8001-1-tiwai@suse.de> References: <20180904155858.8001-1-tiwai@suse.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The hw_queue_size of PCM indirect helper doesn't need to be set up if you use the whole given buffer size. Drop the useless initialization, which just confuses readers. Signed-off-by: Takashi Iwai --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c index a3605505cc20..c935c6e99633 100644 --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c @@ -280,7 +280,6 @@ static int snd_bcm2835_pcm_ack(struct snd_pcm_substream *substream) struct bcm2835_alsa_stream *alsa_stream = runtime->private_data; struct snd_pcm_indirect *pcm_indirect = &alsa_stream->pcm_indirect; - pcm_indirect->hw_queue_size = runtime->hw.buffer_bytes_max; return snd_pcm_indirect_playback_transfer(substream, pcm_indirect, snd_bcm2835_pcm_transfer); } -- 2.18.0