Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2726709imm; Tue, 4 Sep 2018 09:03:26 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZaN2q64meaaUA0AwR0OpdQvncIZ/NSVfG9O45Jo2QtKXQfb3KwTW+SYwJ7L4nT3+VHfx6v X-Received: by 2002:a62:2483:: with SMTP id k3-v6mr36010132pfk.195.1536077006637; Tue, 04 Sep 2018 09:03:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536077006; cv=none; d=google.com; s=arc-20160816; b=gfaVXcwuGIYZxFn2qu+pMNyq5ESToo1OFOvY658fhzdYoL8Vay5XyuQnZQQZSHls5t UcQatal39X03U9IzPsy30+1pEf8zPzHLxBtGZNEkRbOKBimw/btvF4Q3IwfQk1yxN5DY 5tEGwF0Nr5LppwYCKXVUTTbLma68UYWa0X+7hnREweXFUfJe04sOdkBY+SNtaS6YVYrA uVD9c9zHyMSb/33A0MhBs0wImRdSa49r9z8ZjYLsSouW6E1SfnjBrzC29Wpd/Ds91y3/ pOZFO1VsGDmwmeNCMwItzqICnlcH4hSAgUqORvSVphakyOH+D2ituKpQt2YGUI05OrzC usiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=nct2wvJUW57zWsIWFQnxp7muOtLxTkcmTZZ1ngFKODw=; b=Jfocio5QWfvCZqai1icx7TG4OeV1oshMZ5WWiRnbtvyqgDsLiLpO741dscRGuzRDGf UfXUULdxLqCrj3S4eFVNpxhrxGdQdbqQRGkYTW8FAfEy2f1V6GRvYjkMwv+Qi41udwWR /KNeCWT8ttkJpsZ3kUcHjfEQ08zvH5xq9qBZpgwyYv5DZ5HVbdPhppjbG/B8RriE46Dy mOXXLZkmXcDiW6DmSMg3hNUZFAPrpZBZ3KtreomH5nH90jYjaHiicex8TahUcsm3uOxF RO/340XKEv6rjw0Ks+b+lWSORVKTTkcCU8XHhG07c0c2oQoEkItafvSo5X8wgb1Z/zq9 n3zQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r194-v6si23625964pfr.100.2018.09.04.09.03.01; Tue, 04 Sep 2018 09:03:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728151AbeIDU0T (ORCPT + 99 others); Tue, 4 Sep 2018 16:26:19 -0400 Received: from mx2.suse.de ([195.135.220.15]:51018 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726961AbeIDUYt (ORCPT ); Tue, 4 Sep 2018 16:24:49 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 3DDECB0A8; Tue, 4 Sep 2018 15:59:02 +0000 (UTC) From: Takashi Iwai To: Greg Kroah-Hartman Cc: Eric Anholt , Stefan Wahren , linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 13/29] staging: bcm2835-audio: Drop useless NULL check Date: Tue, 4 Sep 2018 17:58:42 +0200 Message-Id: <20180904155858.8001-14-tiwai@suse.de> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180904155858.8001-1-tiwai@suse.de> References: <20180904155858.8001-1-tiwai@suse.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org alsa_stream->chip can be never NULL. Signed-off-by: Takashi Iwai --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c index c935c6e99633..13c61af4e723 100644 --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c @@ -188,8 +188,7 @@ static int snd_bcm2835_playback_close(struct snd_pcm_substream *substream) alsa_stream->buffer_size = 0; bcm2835_audio_close(alsa_stream); - if (alsa_stream->chip) - alsa_stream->chip->alsa_stream[alsa_stream->idx] = NULL; + alsa_stream->chip->alsa_stream[alsa_stream->idx] = NULL; /* * Do not free up alsa_stream here, it will be freed up by * runtime->private_free callback we registered in *_open above -- 2.18.0