Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2737952imm; Tue, 4 Sep 2018 09:13:11 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZ3LRh59CuVYVEmsZip2Dv6x30gBfUl2tXsVd5EQ85lelZ/JQAkM7s+BSzSU+eQMOpit1lR X-Received: by 2002:a62:438f:: with SMTP id l15-v6mr36096196pfi.196.1536077591121; Tue, 04 Sep 2018 09:13:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536077591; cv=none; d=google.com; s=arc-20160816; b=j0cHgXqCWGHBn3Nzx9VkQ67CJx4CGWVg942lArqAKS+SutbBoaV0L1pyz4LNWQNFQs /WhVzI8/NTuOJdaZOvCqbVS5yTZgiFmYlzdzxDvki9kL+AEKdAI2qbHyCTTOtJuf9t25 MpW7oy7Z9wBCL6X8pXFciHhq1GBsnNVXE43I4A2ZSAkgp4KpbGttsfy6fv08GxplUWPY 00ygfqwiEfnMyJTm+yIpkxGSBQ2OAC5CMf8USXuhxa6Z81MnqoI9aU+8fanNLGaxzloH /XbLmHRY5opIGdUsXArB72P5P+ypEOUW2c4slViDC6YKmQOgeQcnBLdzRUFaeEf0KW4x bbkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=GSDuOrnpIgwojER1UWAJl9XV0yF/Ni/1PrEQYh4vuV4=; b=jnkwLDWw4z5fEhquGiTlYOKtvz0LTBcUMylrl4YqF9J4zXJqikX5w2Tdy2GxlCML07 T4dfnLJQDWuh7jHYsPVGQolxOtbgjQ/IQMzQC6m8STEajfnWqY9Sh2gIbprSKORP4p50 OZKyDsHs59U328z+WXd0jvYd3TL69y9fp6F4PmLisJR4ZiMs0hhmLnFcKKMXtaQVmccj zm7l42DIOi2gwrHIL6SqtuWyZwoCbu8gZjfdxw/8xN/JbJgAQTvy6wpcjeOfWvq++9ZX dHCCAKfZ+bJzq5jFyh5fccB1/ectXAekltX8qNZd0iE/0aK5HOmkaEYMgcg+pOa1J2qS kGvQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g12-v6si20927811pgk.636.2018.09.04.09.12.56; Tue, 04 Sep 2018 09:13:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727716AbeIDUhF (ORCPT + 99 others); Tue, 4 Sep 2018 16:37:05 -0400 Received: from sauhun.de ([88.99.104.3]:60424 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727272AbeIDUhF (ORCPT ); Tue, 4 Sep 2018 16:37:05 -0400 Received: from localhost (i577B9DB6.versanet.de [87.123.157.182]) by pokefinder.org (Postfix) with ESMTPSA id E80212C0114; Tue, 4 Sep 2018 18:11:15 +0200 (CEST) Date: Tue, 4 Sep 2018 18:11:14 +0200 From: Wolfram Sang To: shubhrajyoti.datta@gmail.com Cc: linux-i2c@vger.kernel.org, michal.simek@xilinx.com, linux-kernel@vger.kernel.org, Shubhrajyoti Datta Subject: Re: [PATCH] i2c: xiic: Make the start and the byte count write atomic Message-ID: <20180904161114.GC5000@kunai> References: <1535967671-7784-1-git-send-email-shubhrajyoti.datta@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wxDdMuZNg1r63Hyj" Content-Disposition: inline In-Reply-To: <1535967671-7784-1-git-send-email-shubhrajyoti.datta@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --wxDdMuZNg1r63Hyj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 03, 2018 at 03:11:11PM +0530, shubhrajyoti.datta@gmail.com wrot= e: > From: Shubhrajyoti Datta >=20 > Disable interrupts while configuring the transfer and enable them back. >=20 > We have below as the programming sequence > 1. start and slave address > 2. byte count and stop >=20 > In some customer platform there was a lot of interrupts between 1 and 2 > and after slave address (around 7 clock cyles) if 2 is not executed > then the transaction is nacked. >=20 > To fix this case make the 2 writes atomic. >=20 > Signed-off-by: Shubhrajyoti Datta > Signed-off-by: Michal Simek I assume simply changing the order of the register writes won't fix it? I also assume this is stable material? --wxDdMuZNg1r63Hyj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAluOrqIACgkQFA3kzBSg KbapRxAArZeq002KSZpUYsWhatVQEjnYvYcwpQBRDx5hECYdi+eA6jEfmMirD0+Z sU0SrQGu4DZ0pTGcB7Jcz68hIiL6E6o9+BBwI/23A/K+IanWMv/5YeDafBkZJpEu VXvcXcMB9YuOEl00Oz/kUz4IPDeL2Rs9cCeQFAIU+l8MPGvNTel1/h1r9Q04O6/k Bsd4g279d4QueTO+n6UhQYu3ny9d9j5VAF5S1aO/RZqlt29blZ1UX5RTxW3Hii1C kOdTVlZknnPD1//4SKC02W403AiVAaieitCZ2COvpoomwQSkluSEIdmohk146ssO TTTR+OmNx/bAaMgDYZWasRB+uui6gw2X9ELrermwF/VLWv8ok4zUc/AqAlnpxJgC 7exqwyXN9SFvETSs77w5PgCmnvMW2inkiS+exKcnYzg/b/vW+PvyALB7M7A23Z9D Rmo4U6zI4cdsffbe9DuuOheBYTfndPrMEWjVrxbpjGygGb5ZvXY3ym6yOUDqrYah swFRaHVrn7U7oJE42ve6efrvjhN3yWRaqKH4si9csNWQa4msw+LvRABj7kznFraX xMFNXzSquz7ZwJ+yZeMomzlbITIhXIlZeQAJe1vNiIGP2zOowpI1t+xTvJsKJqPS G+wxa8LNrC99WGL3nV68ajT58GhalGNzu+gsk394zov8ywxrMMg= =YYMd -----END PGP SIGNATURE----- --wxDdMuZNg1r63Hyj--