Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2860896imm; Tue, 4 Sep 2018 11:08:35 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYcWBRmD6vbMEuZhmUsaj/mTKI8EQ9lSo4801Ki+slDZNKNeuTT8cGJFSm4i794OjVJGXDE X-Received: by 2002:a62:d2c4:: with SMTP id c187-v6mr35990222pfg.8.1536084515061; Tue, 04 Sep 2018 11:08:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536084515; cv=none; d=google.com; s=arc-20160816; b=DBboy6GIF0d5ohGrbYB56Eboi+1GMGLCtVE0acJwiU+vJ8r+UBYz/0UOgmQ0ZLC6f4 42KWnAnqWLqIJP8z/NELgQt69N3ORxq65Bcslad8emwo820AiJKCJ8J9vBQ/BDNpZp+D xkF4zzqsjP8Fibnrp4kcGPZuH1UFfzpSVNWBQ9oYv/RYgajfQavtkPOu0XiV8Lriaz6L sV7QB65iDfO9mtzz8AzqESBt+2+dG435WUpSoEAEXGFzhcTAZX0AXTbW6oSoszaZyhHj v6ob4E9xKE0RH4CP3UFcj/cHAB2idCn42yX4Py3pVTTC7tmtzAiIvwGT+3OQQ/alZbrH 3T9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=tjr37ruYXYIaQ58ksgrl5/r51ryDgnqo2UwhXdN51FU=; b=Y5HI1sHrFIRbnMNLY0YyZ9lsL/A9+mOdyMXoX831eajbp8jxGGxX9TF7BqFMLURh0C XmbFyJgIxkUj8seOlRu6OlbiNgdyg8TICLODPu+2F1dZfklD4eEt/QOevftw4HcRcRzI +6yw8miBK4qgzi9gFf9j75CVB0RSl2U1NezRmxsnVXpnso72lP9Bnj0D6pAaWa6eCF6i cOeRfpYCnDbAGQGOCVZFf2KNEnX/w0JOOVKPjFrnqsLdpoU3sNkCnEs2vMGTdFQ1qB4E bFnQnxDZMK9qhmD7aCjqnZrE/LmligwOB3mXv+P5kX9kzT3LNai6typteMt30NQlUdlD /lMg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a38-v6si19266880pgb.427.2018.09.04.11.08.19; Tue, 04 Sep 2018 11:08:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727837AbeIDWdN (ORCPT + 99 others); Tue, 4 Sep 2018 18:33:13 -0400 Received: from mailoutvs46.siol.net ([185.57.226.237]:53665 "EHLO mail.siol.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726437AbeIDWdN (ORCPT ); Tue, 4 Sep 2018 18:33:13 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id 66D7E5212B5; Tue, 4 Sep 2018 20:06:57 +0200 (CEST) X-Virus-Scanned: amavisd-new at psrvmta09.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta09.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Eody70bIc8Np; Tue, 4 Sep 2018 20:06:57 +0200 (CEST) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id DEB875211BE; Tue, 4 Sep 2018 20:06:56 +0200 (CEST) Received: from jernej-laptop.localnet (cpe1-8-82.cable.triera.net [213.161.8.82]) (Authenticated sender: 031275009) by mail.siol.net (Postfix) with ESMTPA id 470F15212B5; Tue, 4 Sep 2018 20:06:54 +0200 (CEST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai Cc: Rob Herring , Maxime Ripard , Mark Rutland , Mike Turquette , Stephen Boyd , David Airlie , Archit Taneja , Andrzej Hajda , devicetree , linux-arm-kernel , linux-kernel , linux-clk , dri-devel , linux-sunxi Subject: Re: [PATCH 05/27] clk: sunxi-ng: Use u64 for calculation of NM rate Date: Tue, 04 Sep 2018 20:06:52 +0200 Message-ID: <4377030.YGBN1y1aZP@jernej-laptop> In-Reply-To: References: <20180902072643.4917-1-jernej.skrabec@siol.net> <20180902072643.4917-6-jernej.skrabec@siol.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne torek, 04. september 2018 ob 11:18:47 CEST je Chen-Yu Tsai napisal(a): > On Sun, Sep 2, 2018 at 3:27 PM Jernej Skrabec wrote: > > Allwinner H6 SoC has multiplier N range between 1 and 254. Since parent > > rate is 24MHz, intermediate result when calculating final rate easily > > overflows 32 bit variable. > > > > Because of that, introduce function for calculating clock rate which > > uses 64 bit variable for intermediate result. > > > > Signed-off-by: Jernej Skrabec > > The code looks good. The A80's Video PLLs are also affected by this. > The range for N on the A80 is 12 ~ 255. > > Can you add fixes and stable tags? Sure. > > ChenYu