Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] of: Add device_type access helper functions
To:     Rob Herring <robh@kernel.org>, devicetree@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org
References: <20180830185229.20393-1-robh@kernel.org>
From:   Frank Rowand <frowand.list@gmail.com>
Message-ID: <4253073f-5ddf-a01c-4d3e-5c6a13068903@gmail.com>
Date:   Tue, 4 Sep 2018 20:55:48 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180830185229.20393-1-robh@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 08/30/18 11:52, Rob Herring wrote:
> In preparation to remove direct access to device_node.type, add
> of_node_is_type() and of_node_get_device_type() helpers to check and
> retrieve the device type.
> 
> Cc: Frank Rowand <frowand.list@gmail.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  include/linux/of.h | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/include/linux/of.h b/include/linux/of.h
> index a40f63a36afa..506beca9588d 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -980,6 +980,18 @@ static inline struct device_node *of_find_matching_node(
>  	return of_find_matching_node_and_match(from, matches, NULL);
>  }
>  
> +static inline const char *of_node_get_device_type(const struct device_node *np)
> +{
> +	return of_get_property(np, "type", NULL);

I'm a little confused.  The patch comment says "remove direct access to device_node.type.
device_node.type is set to the value of the property "device_type" in populate_node(),
but of_node_get_device_type() is looking for property "type".


> +}> +
> +static inline bool of_node_is_type(const struct device_node *np, const char *type)
> +{
> +	const char *match = of_node_get_device_type(np);
> +
> +	return np && match && type && !of_prop_cmp(match, type);
> +}
> +
>  /**
>   * of_property_count_u8_elems - Count the number of u8 elements in a property
>   *
> 

I'd like to see one or two examples of how you plan to use of_node_get_device_type()
(outside of of_node_is_type()) and examples of planned use of of_node_is_type() so
I can better understand anticipated usage.  Complete, clean patches not needed for
the examples, just enough text for me to see the resulting code change where the
helpers are used.

-Frank