Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To:     Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>,
        "balbi@kernel.org" <balbi@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC:     "v.anuragkumar@gmail.com" <v.anuragkumar@gmail.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/8] usb: dwc3: make controller clear transfer
 resources after complete
Thread-Topic: [PATCH v2 3/8] usb: dwc3: make controller clear transfer
 resources after complete
Thread-Index: AQHUNiV8hOcNaYvD7kKOGug2l9hEXw==
Date:   Wed, 5 Sep 2018 05:38:38 +0000
Message-ID: <30102591E157244384E984126FC3CB4F544AB8AB@us01wembx1.internal.synopsys.com>
References: <1534508695-12642-1-git-send-email-anurag.kumar.vulisha@xilinx.com>
 <1534508695-12642-4-git-send-email-anurag.kumar.vulisha@xilinx.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 8/17/2018 5:26 AM, Anurag Kumar Vulisha wrote:=0A=
> To start transfer with another stream id, controller needs to free=0A=
> previously allocated transfer resource. This will be automatically=0A=
> done by the controller at the time of XferComplete Event. This=0A=
> patch updates the code to issue XferComplete event once all transfers=0A=
> are done by setting LST bit in the ctrl field of the last TRB.=0A=
>=0A=
> Signed-off-by: Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>=0A=
> ---=0A=
>  Changes in v2:=0A=
> 	1. None=0A=
> ---=0A=
>  drivers/usb/dwc3/gadget.c | 19 ++++++++++++++++---=0A=
>  1 file changed, 16 insertions(+), 3 deletions(-)=0A=
>=0A=
> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c=0A=
> index efc6e13..b3e9e7f 100644=0A=
> --- a/drivers/usb/dwc3/gadget.c=0A=
> +++ b/drivers/usb/dwc3/gadget.c=0A=
> @@ -571,7 +571,8 @@ static int dwc3_gadget_set_ep_config(struct dwc3_ep *=
dep, unsigned int action)=0A=
>  =0A=
>  	if (usb_ss_max_streams(comp_desc) && usb_endpoint_xfer_bulk(desc)) {=0A=
>  		params.param1 |=3D DWC3_DEPCFG_STREAM_CAPABLE=0A=
> -			| DWC3_DEPCFG_STREAM_EVENT_EN;=0A=
> +			| DWC3_DEPCFG_STREAM_EVENT_EN=0A=
> +			| DWC3_DEPCFG_XFER_COMPLETE_EN;=0A=
>  		dep->stream_capable =3D true;=0A=
>  	}=0A=
>  =0A=
> @@ -999,6 +1000,15 @@ static void __dwc3_prepare_one_trb(struct dwc3_ep *=
dep, struct dwc3_trb *trb,=0A=
>  	if (chain)=0A=
>  		trb->ctrl |=3D DWC3_TRB_CTRL_CHN;=0A=
>  =0A=
> +	/*=0A=
> +	 * To issue start transfer on another stream, controller need to free=
=0A=
> +	 * previously acquired transfer resource. Setting the LST bit in=0A=
> +	 * last TRB makes the controller clear transfer resource for that=0A=
> +	 * endpoint, allowing to start another stream on that endpoint.=0A=
> +	 */=0A=
> +	else if (dep->stream_capable)=0A=
> +		trb->ctrl |=3D DWC3_TRB_CTRL_LST;=0A=
> +=0A=
>  	if (usb_endpoint_xfer_bulk(dep->endpoint.desc) && dep->stream_capable)=
=0A=
>  		trb->ctrl |=3D DWC3_TRB_CTRL_SID_SOFN(stream_id);=0A=
>  =0A=
> @@ -2268,7 +2278,7 @@ static int dwc3_gadget_ep_reclaim_completed_trb(str=
uct dwc3_ep *dep,=0A=
>  	if (event->status & DEPEVT_STATUS_SHORT && !chain)=0A=
>  		return 1;=0A=
>  =0A=
> -	if (event->status & DEPEVT_STATUS_IOC)=0A=
> +	if (event->status & (DEPEVT_STATUS_IOC | DEPEVT_STATUS_LST))=0A=
>  		return 1;=0A=
>  =0A=
>  	return 0;=0A=
> @@ -2457,6 +2467,10 @@ static void dwc3_endpoint_interrupt(struct dwc3 *d=
wc,=0A=
>  	}=0A=
>  =0A=
>  	switch (event->endpoint_event) {=0A=
> +	case DWC3_DEPEVT_XFERCOMPLETE:=0A=
> +		if (!dep->stream_capable)=0A=
> +			break;=0A=
> +		dep->flags &=3D ~DWC3_EP_TRANSFER_STARTED;=0A=
 Add this:  /* Falls Through */=0A=
>  	case DWC3_DEPEVT_XFERINPROGRESS:=0A=
>  		dwc3_gadget_endpoint_transfer_in_progress(dep, event);=0A=
>  		break;=0A=
> @@ -2472,7 +2486,6 @@ static void dwc3_endpoint_interrupt(struct dwc3 *dw=
c,=0A=
>  		}=0A=
>  		break;=0A=
>  	case DWC3_DEPEVT_STREAMEVT:=0A=
> -	case DWC3_DEPEVT_XFERCOMPLETE:=0A=
>  	case DWC3_DEPEVT_RXTXFIFOEVT:=0A=
>  		break;=0A=
>  	}=0A=
=0A=
Thinh=0A=
=0A=