Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp3423453imm; Tue, 4 Sep 2018 23:13:18 -0700 (PDT) X-Google-Smtp-Source: ANB0VdaXnQb2gBK8dbnOW70yZQ/sM26bbGl8D4S5Ch1OfWCUzusweiU7ZBCaeoQqboe1nJPljBKF X-Received: by 2002:a17:902:3041:: with SMTP id u59-v6mr36365540plb.99.1536127998860; Tue, 04 Sep 2018 23:13:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536127998; cv=none; d=google.com; s=arc-20160816; b=r23jGjvhTsW2ysuVpjsatkZ2BWdJg1tuH6iiIC1yqwt9Kgn2sUuHVNHZsv/wSZ3G8P sTk/p4LKqh48sa3T1OnfSR+c1GKNgQK8rFAVxHlPuG20aYoae4cgab1fCe/aWyeQSc/M fD+n5DSMMfByOjo71SxgwptrfUO6STLFecfIrcWikN89B03R4gWcDBEXx2MHve+9kZAE hNf+EEkT5mbmziRrqbFB3sVFZX0fvxeGrlwqRyTXWFVBa5jxrQ+4co40dNBSE9D3sEZM Cgikpph6lfLWasY9up8Yo7Sbi57TdIOaDaCIB/f3V26bdCDcA5FtqJ3XuHUIruvrxOpJ Rzdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Uva6WvTCO0peCxOukIV1wV5tNn0mHsrP8l7C0Uv665Q=; b=Rf5jbbHgrvpTACouvwpH0NFGs/wHcQgtEKl6/ufLnVG9auk/FERmT6jJ1mI+7Ol1zo HqFQuFpCdTEr1YxEPuTh5imL28DXrodyb/oewt6R125tauTmkczE0EBjB8J712w0oNNh Sr+btPYK1jtwLYr3MUql/7aR9M9TkiaSXQAYEWzm79jXt9UOIcc2qSRc0yw2EJObb/ij w4h07k13NfNDrv7aKqQMxzdnu5hnGw0N1oYDDXCw57iZnL1GVhx0vn/dXchlGK4mInN7 0nPTAYtujlSAGxPGbXu+bBwB+JA9D2NZ/MerN0rTwNNJHMNIXHRiVA+uXfiJAr6pZ2Yx 9GRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=fMGx3j+f; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d8-v6si1120703pgn.382.2018.09.04.23.13.03; Tue, 04 Sep 2018 23:13:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=fMGx3j+f; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727692AbeIEKkM (ORCPT + 99 others); Wed, 5 Sep 2018 06:40:12 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:44073 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726299AbeIEKkM (ORCPT ); Wed, 5 Sep 2018 06:40:12 -0400 Received: by mail-pf1-f194.google.com with SMTP id k21-v6so2894893pff.11; Tue, 04 Sep 2018 23:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Uva6WvTCO0peCxOukIV1wV5tNn0mHsrP8l7C0Uv665Q=; b=fMGx3j+fHmbNiCYYf0bCE0CsLNOR+Hdy7VIohe5KgvE3TuE9s2ybym5BuPMqx3PYJ4 Dc+lWIo4kTNnalodstwsBghMJFQUhoKmjDayWzTflwQ/Jutm4UzhOMSPBnwXr6TByev+ 9xjyRgmFD4EtAVBR9DOQL/fHpDRaU0oEjYnNNHAExXkrP8qe8ri8xQYCT58Xvur7qDM1 KGBECHcJeZOUzXS64OMr0kW8wMKbYvcpM1RMpnDsNuZLacjtUn8Ef1owCfkQqk3hfT+z i3sU5kCOaXDCSd3sRy0aJphN35r+4qqVwzhuBu5vdTuJP+wvzi6yxznMEZ9vSda3vMDu GyHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Uva6WvTCO0peCxOukIV1wV5tNn0mHsrP8l7C0Uv665Q=; b=mTYyJJn6MWxi8xkr4dPv6qWEwNLzTqU5E1oTHFsHyrnJuTi4xSZ0nQ06Csy5ALaDoc A6qRUiPoezvVV/+RogkmWZ0Pe8i++QVFj/i+1wNWpXT+p+D2PnxL6DRDafdHDhCOB6QD egomwWNdHfnwizUOZFx/tshjxRta2f4W7c/8S2A8Ki5uLuSiBKNnTdxaZoQqItA9HQLX OyQH4Ydqe+tsXoqn0HvlMKj0+JaFaE47mmfdbAk/fR5mrQ7/NsdlkfG6nO+KgtuePZgF w32hZTBpjvITenbat1BqlZRuP7Dij2e7eRsA4GC/mm9bSXdx3zgV2Q+eX+Vq9bJe96Xf AhZw== X-Gm-Message-State: APzg51AqWo+pwfvrea0Os8w+tyAqgzJGeZkCfqLElaP6khL/fNUyYrUF 23VWdRA40n1kt5bLfao2Pt4= X-Received: by 2002:a63:9712:: with SMTP id n18-v6mr33887600pge.92.1536127897380; Tue, 04 Sep 2018 23:11:37 -0700 (PDT) Received: from ast-mbp.dhcp.thefacebook.com ([2620:10d:c090:180::1:bcd1]) by smtp.gmail.com with ESMTPSA id p11-v6sm1231335pfj.72.2018.09.04.23.11.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Sep 2018 23:11:36 -0700 (PDT) Date: Tue, 4 Sep 2018 23:11:33 -0700 From: Alexei Starovoitov To: Jakub Kicinski Cc: Taeung Song , Daniel Borkmann , Alexei Starovoitov , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf-next v2] libbpf: Remove the duplicate checking of function storage Message-ID: <20180905061132.m7kp5og6jopojajj@ast-mbp.dhcp.thefacebook.com> References: <20180902233007.3003-1-treeze.taeung@gmail.com> <20180904110745.3ab4dc3e@cakuba> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180904110745.3ab4dc3e@cakuba> User-Agent: NeoMutt/20180223 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 04, 2018 at 11:07:45AM +0200, Jakub Kicinski wrote: > On Mon, 3 Sep 2018 08:30:07 +0900, Taeung Song wrote: > > After the commit eac7d84519a3 ("tools: libbpf: don't return '.text' > > as a program for multi-function programs"), bpf_program__next() > > in bpf_object__for_each_program skips the function storage such as .text, > > so eliminate the duplicate checking. > > > > Cc: Jakub Kicinski > > Signed-off-by: Taeung Song > > Acked-by: Jakub Kicinski Applied, Thanks