Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp3502463imm; Wed, 5 Sep 2018 00:56:28 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbqdpN0b7SWx49eBdQNH2FJetd4ogeIzyExDRxS0ae0YRiYbH4axtl4fFvDC51VK+hBTnJb X-Received: by 2002:a63:c44a:: with SMTP id m10-v6mr35342429pgg.416.1536134188601; Wed, 05 Sep 2018 00:56:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536134188; cv=none; d=google.com; s=arc-20160816; b=orXhYQBBOK8Zw2XFuXAu+EVwCvT+Vzd0e9id6rPFW125MU8Exca/kKYpVRYiFFIjMq NDzqAayxM5Sq5lz8zR4GGbe0XwZGUYENvUj+fc6Qjh9kBWxx//Xnp6CNrefcmjjmi/WA gsUFbwy7Hb5uTfU6dP0qP2n0VO0JWT/TayuB12WXnbilkbjhqHCX/NLhsVBj8jJdbt30 LetR8nKNOHX0xNQGE1F9ZHbQLhWpZF9Rgs40/vaBBsEM+xKHIkzxIy/ek6dCCB+EAlvj TL1G6/ZbzHD15CrgfS53+vGNl8Mtqv1O1GP6dOtvSVbcIHOsUuVyWMxyqjKUWhbNDBsX vPaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=Ad/qRrnN4bLcopeN3HdSw1TMV2koQ9WNay3tso3QlhU=; b=uLJMopGguvq94jujpLFrdiOG1k/NNvFDj0eV0dDnP4QI+KZoJBaedF/mkIF3xduPEW BNh9LaYQJKYS8tOs0PngwnDUNmn4cR13Y03gvWQX6an6Q5Q9jfwZCWxWlwHmQafmjc8o 3o7Pq+VK9pcipcZehJnRtU1BL5IdrwPP0WzWSY0t4KisXBhgSU2zFmK/K3f1pCsG3hSC xvS3HQQ7HaTt2kCMnxAv/yvtHMqrWT4Kv8RRe8M6mJY9YnnMU7SEha8wPqoRUF+fY5XQ exGM6nsqNgj2rQe0sJz6mtFo+0fZC8+ZVg+OQ+EIysTZtkFe8Bd8d0JxUizaKPt1NHTg dsJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v66-v6si1307923pfb.368.2018.09.05.00.56.12; Wed, 05 Sep 2018 00:56:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727694AbeIEMX2 (ORCPT + 99 others); Wed, 5 Sep 2018 08:23:28 -0400 Received: from mail-ua1-f68.google.com ([209.85.222.68]:37695 "EHLO mail-ua1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726369AbeIEMX2 (ORCPT ); Wed, 5 Sep 2018 08:23:28 -0400 Received: by mail-ua1-f68.google.com with SMTP id y10-v6so5068302uao.4; Wed, 05 Sep 2018 00:54:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ad/qRrnN4bLcopeN3HdSw1TMV2koQ9WNay3tso3QlhU=; b=r13MSDlQY0WY8e64BbA24lmv/TyGnHtOtyfFvHqbN3HSz/Un1jnP/Onpq0rCvbia1Q bJJMizR2Pa0RFC0qDouLQ5OoKTVg/0lDSDorSLPRF5dYyW+jxk89GXpabwywss9C3wAC fLDKcAtcHDKMkBNtO4Z/QotyIdG/SJ/9JzjeozWiXC1HzgpGGkt9Vc4tmVqTVriA1fxW muOTUSUoSaalgy/YHioYxRJcMP+oB4l9Jauj8Jj85iBcQiiZfS0nkiaDUx35GbHqkSYF +KxR6QMBeiUN2p+EJwHF4G4EGwIZ+p/nCvXBz8I05CuhmfeBYbFod0LsP2rAQqMnkVpa R8hg== X-Gm-Message-State: APzg51CC9y3rOlWgnSvSUzncgW2bUzkaWZ4nAAikUmG99DOOUOCtslXK XzhfvhAdS+pfEj+7jcyr8aAsKTWcV/1imYfqisw= X-Received: by 2002:a67:33cc:: with SMTP id z195-v6mr12319765vsz.40.1536134070170; Wed, 05 Sep 2018 00:54:30 -0700 (PDT) MIME-Version: 1.0 References: <20180808090944.861-1-simon.k.r.goldschmidt@gmail.com> In-Reply-To: From: Geert Uytterhoeven Date: Wed, 5 Sep 2018 09:54:18 +0200 Message-ID: Subject: Re: [PATCH] ARM: dts: socfpga: use stdout-path for chosen node To: Marek Vasut Cc: simon.k.r.goldschmidt@gmail.com, Dinh Nguyen , Rob Herring , Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 8, 2018 at 2:11 PM Marek Vasut wrote: > On 08/08/2018 02:02 PM, Simon Goldschmidt wrote: > > On Wed, Aug 8, 2018 at 1:32 PM Marek Vasut wrote: > >> On 08/08/2018 11:09 AM, Simon Goldschmidt wrote: > >>> Use stdout-path dts property for kernel console. > >>> > >>> There were two socfpga boards left not using stdout-path: > >>> socrates and vining. Make sure they match the other boards. > >>> > >>> Signed-off-by: Simon Goldschmidt > >>> --- > >>> arch/arm/boot/dts/socfpga_cyclone5_socrates.dts | 3 ++- > >>> arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts | 3 ++- > >>> 2 files changed, 4 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_socrates.dts b/arch/arm/boot/dts/socfpga_cyclone5_socrates.dts > >>> index 53bf99eef66d..6f5255a7d192 100644 > >>> --- a/arch/arm/boot/dts/socfpga_cyclone5_socrates.dts > >>> +++ b/arch/arm/boot/dts/socfpga_cyclone5_socrates.dts > >>> @@ -22,7 +22,8 @@ > >>> compatible = "ebv,socrates", "altr,socfpga-cyclone5", "altr,socfpga"; > >>> > >>> chosen { > >>> - bootargs = "console=ttyS0,115200"; > >>> + bootargs = "earlyprintk"; > >>> + stdout-path = "serial0:115200n8"; > >>> }; > >>> > >>> memory@0 { > >>> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts b/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts > >>> index f50b19447de6..e61efe16e79c 100644 > >>> --- a/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts > >>> +++ b/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts > >>> @@ -54,7 +54,8 @@ > >>> compatible = "samtec,vining", "altr,socfpga-cyclone5", "altr,socfpga"; > >>> > >>> chosen { > >>> - bootargs = "console=ttyS0,115200"; > >>> + bootargs = "earlyprintk"; > >> > >> Why this earlyprintk ? > > > > The reason is Dinh added that to all socfpga boards in his commit [1] > > and I wanted the remaining two boards to be the same. > > Isn't earlyprintk mostly a debugging aid ? Indeed. And the modern way is "earlycon", not "earlyprintk". Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds