Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Anurag Kumar Vulisha <anuragku@xilinx.com>
To:     Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        "balbi@kernel.org" <balbi@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC:     "v.anuragkumar@gmail.com" <v.anuragkumar@gmail.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 3/8] usb: dwc3: make controller clear transfer
 resources after complete
Thread-Topic: [PATCH v2 3/8] usb: dwc3: make controller clear transfer
 resources after complete
Thread-Index: AQHUNiVVrYzEd/MLO0Wv5fDm3NztnKThhvBA
Date:   Wed, 5 Sep 2018 09:21:33 +0000
Message-ID: <BN3PR0201MB0993768965D7E7C08B33E4FFA7020@BN3PR0201MB0993.namprd02.prod.outlook.com>
References: <1534508695-12642-1-git-send-email-anurag.kumar.vulisha@xilinx.com>
 <1534508695-12642-4-git-send-email-anurag.kumar.vulisha@xilinx.com>
 <30102591E157244384E984126FC3CB4F544AB8AB@us01wembx1.internal.synopsys.com>
In-Reply-To: <30102591E157244384E984126FC3CB4F544AB8AB@us01wembx1.internal.synopsys.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: xilinx.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d9bb5b3a-8a88-4e7b-8eaa-08d61310f91b
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Sep 2018 09:21:33.7139
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0201MB0932
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi Thinh,

>> +	 * To issue start transfer on another stream, controller need to free
>> +	 * previously acquired transfer resource. Setting the LST bit in
>> +	 * last TRB makes the controller clear transfer resource for that
>> +	 * endpoint, allowing to start another stream on that endpoint.
>> +	 */
>> +	else if (dep->stream_capable)
>> +		trb->ctrl |=3D DWC3_TRB_CTRL_LST;
>> +
>>  	if (usb_endpoint_xfer_bulk(dep->endpoint.desc) && dep->stream_capable)
>>  		trb->ctrl |=3D DWC3_TRB_CTRL_SID_SOFN(stream_id);
>>
>> @@ -2268,7 +2278,7 @@ static int
>dwc3_gadget_ep_reclaim_completed_trb(struct dwc3_ep *dep,
>>  	if (event->status & DEPEVT_STATUS_SHORT && !chain)
>>  		return 1;
>>
>> -	if (event->status & DEPEVT_STATUS_IOC)
>> +	if (event->status & (DEPEVT_STATUS_IOC | DEPEVT_STATUS_LST))
>>  		return 1;
>>
>>  	return 0;
>> @@ -2457,6 +2467,10 @@ static void dwc3_endpoint_interrupt(struct dwc3 *=
dwc,
>>  	}
>>
>>  	switch (event->endpoint_event) {
>> +	case DWC3_DEPEVT_XFERCOMPLETE:
>> +		if (!dep->stream_capable)
>> +			break;
>> +		dep->flags &=3D ~DWC3_EP_TRANSFER_STARTED;
> Add this:  /* Falls Through */
Thanks for correcting, will fix it in the next version of patch

Thanks,
Anurag Kumar Vulisha

>>  	case DWC3_DEPEVT_XFERINPROGRESS:
>>  		dwc3_gadget_endpoint_transfer_in_progress(dep, event);
>>  		break;
>> @@ -2472,7 +2486,6 @@ static void dwc3_endpoint_interrupt(struct dwc3 *d=
wc,
>>  		}
>>  		break;
>>  	case DWC3_DEPEVT_STREAMEVT:
>> -	case DWC3_DEPEVT_XFERCOMPLETE:
>>  	case DWC3_DEPEVT_RXTXFIFOEVT:
>>  		break;
>>  	}
>
>Thinh