Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Anurag Kumar Vulisha <anuragku@xilinx.com>
To:     Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        "balbi@kernel.org" <balbi@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC:     "v.anuragkumar@gmail.com" <v.anuragkumar@gmail.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 4/8] usb: dwc3: implement stream transfer timeout
Thread-Topic: [PATCH v2 4/8] usb: dwc3: implement stream transfer timeout
Thread-Index: AQHUNiVVg4AXlbkIiUaGiqFG6/ZLBqThh6EA
Date:   Wed, 5 Sep 2018 09:24:14 +0000
Message-ID: <BN3PR0201MB099343BF037A62CD036CD4BDA7020@BN3PR0201MB0993.namprd02.prod.outlook.com>
References: <1534508695-12642-1-git-send-email-anurag.kumar.vulisha@xilinx.com>
 <1534508695-12642-5-git-send-email-anurag.kumar.vulisha@xilinx.com>
 <30102591E157244384E984126FC3CB4F544AB8CD@us01wembx1.internal.synopsys.com>
In-Reply-To: <30102591E157244384E984126FC3CB4F544AB8CD@us01wembx1.internal.synopsys.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: xilinx.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 003166d0-d6a2-4091-7964-08d6131158af
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Sep 2018 09:24:14.0678
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0201MB0932
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Thinh,

>dwc3_gadget_endpoint_transfer_in_progress(struct dwc3_ep *dep,
>>  			stop =3D true;
>>  	}
>>
>> +	/*
>> +	 * Delete the timer that was started in __dwc3_gadget_kick_transfer()
>> +	 * for stream capable endpoints.
>> +	 */
>> +	if (dep->stream_capable)
>> +		del_timer(&dep->stream_timeout_timer);
>> +
>>  	dwc3_gadget_ep_cleanup_completed_requests(dep, event, status);
>>
>>  	if (stop) {
>> @@ -2486,6 +2505,14 @@ static void dwc3_endpoint_interrupt(struct dwc3 *=
dwc,
>>  		}
>>  		break;
>>  	case DWC3_DEPEVT_STREAMEVT:
>> +		switch (event->status) {
>> +		case DEPEVT_STREAMEVT_FOUND:
>> +			del_timer(&dep->stream_timeout_timer);
>> +			break;
>> +		case DEPEVT_STREAMEVT_NOTFOUND:
>> +		default:
>> +			dev_err(dwc->dev, "unable to find suitable stream");
>> +		}
>Add break after this. Also, it's probably easier to read if we use if-else=
 case here.
>

Thanks for correcting the code, will fix it in next series of patch

Thanks,
Anurag Kumar Vulisha

>>  	case DWC3_DEPEVT_RXTXFIFOEVT:
>>  		break;
>>  	}
>> @@ -2587,6 +2614,18 @@ static void dwc3_stop_active_transfer(struct dwc3=
_ep
>*dep, bool force)
>>  	}
>>  }
>>
>> +static void stream_timeout_function(struct timer_list *arg) {
>> +	struct dwc3_ep *dep =3D from_timer(dep, arg, stream_timeout_timer);
>> +	struct dwc3		*dwc =3D dep->dwc;
>> +	unsigned long		flags;
>> +
>> +	spin_lock_irqsave(&dwc->lock, flags);
>> +	dwc3_stop_active_transfer(dep, true);
>> +	__dwc3_gadget_kick_transfer(dep);
>> +	spin_unlock_irqrestore(&dwc->lock, flags); }
>> +
>>  static void dwc3_clear_stall_all_ep(struct dwc3 *dwc)  {
>>  	u32 epnum;
>
>Thinh