Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp3800388imm; Wed, 5 Sep 2018 06:17:30 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYUmvx1bVNNtVnrdMeaAKAGWoEUFbU/YzpuqKiQlZTNuwIGT41A/VpOEBq1ayalS9lI0DQX X-Received: by 2002:a17:902:9696:: with SMTP id n22-v6mr39260929plp.212.1536153450445; Wed, 05 Sep 2018 06:17:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536153450; cv=none; d=google.com; s=arc-20160816; b=hg9GFGWahQT2dT5MQ+iLwx/ReH09dqVHwvqDsxdVRKcdMo0Jke+R8AzlPiLj5pGiie 1KsL5hDZ3w+ws3OAF3HT/w0kgaJSI19EP/O/vGXbS2FNm2FzZmFOfZVFCYkVEkInttiW evvAmNj8QYxQSFL8JY0LsytS1JP6CdFJusvT3zs6wMnH4sUYAa8nVpayxyp29JSCrhbe AHdo4jefCJXeAOwPSAbwm8MgXB2zj6CHtbfgI73uRntPGMRD+RLT1SogO63AjwGs5M8f VaVetHFtnp62myq0Ij7sqlxWjjJ5Wk9ok4YfYQcCqlICaMW79AUCoViuyy9xyeFNvNlQ ugnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=1AooCJDdqtbJXGH+GG97gZKEXnSMqriMBFqHZA8GuwE=; b=xPm5NguEn9gc/9qz5qVlR08t8LhbwWHw6oRtZGgwMIqCJNjhiU/72ZWy40fYK7OeNn EuUmjwy5h11WYqwDyOlKX62Qm0grw24jomk73QmmTGFMN+pX/ofq6DRSUMNoUoKXlRL8 bOY3qD8SjQXRWCGFDXqVxpI3JA0gGjyij1T75Knh/foap9eStB11N4Vp/F0EpicftM6Y k4tRkx018+T9MnNoFmFMTKvOTtvtO0fKezWCkxXivRIKFgxaPUcUEuuQiWn4wLoUE0Qd to4UdA4YEFw4nqqwr/asvo0bP60AyUDMvhwwDnXB9HAwc58fh8NvjaFDgeEmOrAH7BvK 24YA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bg5-v6si1761759plb.368.2018.09.05.06.17.14; Wed, 05 Sep 2018 06:17:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727681AbeIERpt (ORCPT + 99 others); Wed, 5 Sep 2018 13:45:49 -0400 Received: from mail.skyhub.de ([5.9.137.197]:35502 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726189AbeIERps (ORCPT ); Wed, 5 Sep 2018 13:45:48 -0400 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 8pQ3aMh4OiqF; Wed, 5 Sep 2018 15:15:16 +0200 (CEST) Received: from zn.tnic (p200300EC2BCBB900329C23FFFEA6A903.dip0.t-ipconnect.de [IPv6:2003:ec:2bcb:b900:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 660281EC0253; Wed, 5 Sep 2018 15:15:16 +0200 (CEST) Date: Wed, 5 Sep 2018 15:15:10 +0200 From: Borislav Petkov To: Pu Wen Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, thomas.lendacky@amd.com, pbonzini@redhat.com, tony.luck@intel.com, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-edac@vger.kernel.org Subject: Re: [PATCH v5 10/16] x86/mce: enable Hygon support to MCE infrastructure Message-ID: <20180905131427.GI2237@zn.tnic> References: <20180905092234.GC2237@zn.tnic> <01604799-b993-e530-817c-ad097d343fc4@hygon.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <01604799-b993-e530-817c-ad097d343fc4@hygon.cn> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 05, 2018 at 08:59:24PM +0800, Pu Wen wrote: > If CONFIG_X86_MCE_AMD=n, mce_hygon_feature_init will call the other > one mce_amd_feature_init which is a null function and located in the > else branch of "#ifdef CONFIG_X86_MCE_AMD". The compilation is OK and > the kernel will run without MCE support. So my question was rather ironic but I guess irony can't travel through mail. So let me paraphrase: is that a use case you wanna support? Because I'd advise very strongly against !MCE kernels. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.