Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 5 Sep 2018 16:21:35 +0200
From:   Boris Brezillon <boris.brezillon@bootlin.com>
To:     Bartosz Golaszewski <brgl@bgdev.pl>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Joachim Eastwood <manabian@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Jonathan Corbet <corbet@lwn.net>, Sekhar Nori <nsekhar@ti.com>,
        Kevin Hilman <khilman@kernel.org>,
        David Lechner <david@lechnology.com>,
        Andrew Lunn <andrew@lunn.ch>, Alban Bedel <albeu@free.fr>,
        Maxime Ripard <maxime.ripard@bootlin.com>,
        linux-doc <linux-doc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH 11/13] nvmem: add support for cell lookups from machine
 code
Message-ID: <20180905162135.700d2145@bbrezillon>
In-Reply-To: <CAMRc=Mco7Tbk5P_mgv49f+3j9DKYk5AL6EjPhwF7M=Hb7o5-Mw@mail.gmail.com>
References: <20180905095738.26406-1-brgl@bgdev.pl>
        <20180905095738.26406-12-brgl@bgdev.pl>
        <20180905155741.22b7d0ef@bbrezillon>
        <CAMRc=Mco7Tbk5P_mgv49f+3j9DKYk5AL6EjPhwF7M=Hb7o5-Mw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 5 Sep 2018 16:00:36 +0200
Bartosz Golaszewski <brgl@bgdev.pl> wrote:

> 2018-09-05 15:57 GMT+02:00 Boris Brezillon <boris.brezillon@bootlin.com>:
> > On Wed,  5 Sep 2018 11:57:36 +0200
> > Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> >  
> >>
> >> +struct nvmem_cell_lookup {
> >> +     const char              *nvmem_name;
> >> +     const char              *dev_id;  
> >
> > Shouldn't we have a con_id here?
> >  
> >> +     const char              *cell_id;
> >> +     struct list_head        node;
> >> +};  
> 
> I wanted to stay in line with the current API - nvmem_cell_get() takes
> as argument a string called cell_id. I wanted to reflect that here.

Actually, you need both. con_id is the name you would have in your DT
in the nvmem-cell-names property, cell_id is the name of the cell
you'd find under the nvmem device node.

Let's take an example:

	mydev {
		#nvmem-cell-names = "mac-address", "revision";
		#nvmem-cells = <&cell1>, <&cell2>;
	};

	mynvmemdev {
		#size-cells = <1>;
		#address-cells = <1>;

		cell1: foo@0 {
			reg = <0x0 0x6>;
		};

		cell2: bar@6 {
			reg = <0x6 0x10>;
		};
	};

this can be described the same way using a consumer lookup table:

struct nvmem_cell_lookup_entry {
	const char *con_id;
	const char *nvmem_name;
	const char *cell_name;
};

struct nvmem_cell_lookup_table {
	struct list_head node;
	const char *dev_id;
	unsigned int nentries;
	const struct nvmem_cell_lookup_entry *entries;
}

static const struct nvmem_cell_lookup_entry mydev_nvmem_cells[] = {
	{
		.con_id = "mac-address",
		.nvmem_name = "mynvmemdev",
		.cell_name = "foo",
	},
	{
		.con_id = "revision",
		.nvmem_name = "mynvmemdev",
		.cell_name = "bar",
	},
}

static const struct nvmem_cell_lookup_table mydev_nvmem_lookup = {
	.dev_id = "mydev.0",
	.nentries = ARRAY_SIZE(mydev_nvmem_cells),
	.entries = mydev_nvmem_cells,
};


...

	nvmem_add_cell_lookups(&mydev_nvmem_lookup);