Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 06 Sep 2018 00:37:01 +0900 (JST)
Message-Id: <20180906.003701.1191480642819924726.anemo@mba.ocn.ne.jp>
To:     dingxiang@cmss.chinamobile.com
Cc:     ralf@linux-mips.org, paul.burton@mips.com, jhogan@kernel.org,
        linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] mips: txx9: fix resource leak after register fail
From:   Atsushi Nemoto <anemo@mba.ocn.ne.jp>
In-Reply-To: <1536146539-26131-1-git-send-email-dingxiang@cmss.chinamobile.com>
References: <1536146539-26131-1-git-send-email-dingxiang@cmss.chinamobile.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed,  5 Sep 2018 19:22:19 +0800, Ding Xiang <dingxiang@cmss.chinamobile.com> wrote:
> the memory allocated and ioremap address need free after
> device_register return error.
...
>  exit_put:
>  	put_device(&dev->dev);
> -	return;
> +exit_free:
> +	iounmap(dev->base);
> +	kfree(dev);

This change will break exit_put error path.
I think kfree will be called from txx9_device_release by put_device.

Please refer James's comment on previous trial:
<https://www.linux-mips.org/cgi-bin/mesg.cgi?a=linux-mips&i=20180305221833.GJ4197%40saruman>

---
Atsushi Nemoto