Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp3984218imm; Wed, 5 Sep 2018 08:56:08 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYj18vxYEJHxJboA6129zNgHe+9WGeKFSF9moNuw/gL0v/uonbLlFYofVqG/21iGggHho6C X-Received: by 2002:a17:902:e85:: with SMTP id 5-v6mr34441987plx.73.1536162968870; Wed, 05 Sep 2018 08:56:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536162968; cv=none; d=google.com; s=arc-20160816; b=fcqIvLLQ8LTMRPUDES/b1qgIDd9qntdhEnaQ0Yc4s4adk08HTEA6QgFOJxMN9ZRvg7 hYI7b5/sJur/icCbUpRCvQTQJcMJ8/eKHIffoU/gIhCmPN4Ej69nzBqe55ruNdhgGA6T b5XMLvhIOKsm2nCWUiZi8J6DuM0dgrobPsqUdVgbm58wSWdrnm0wk9TL9ej5zA4H0O9g H5xQ67i4cVThVspN9tqWqyTxXiVps1CWd+Ok+MMu5uuJN0NXiBatUE6sQofkCEiwPOn5 E0pZet1PseBHh9KfIpiDBYlasfpZlm9kCdURksMWu8LUSig1aNTEeXtkYKxptSdTM+AB 6Y3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject:organization; bh=h6erX5buxACV/KTL50QlixYjVq8wOgtugovz19NEWS8=; b=O7dvF9JFZDVgxnUSyay8VX13SXH6l8Q6Sdc90SBnfgqZ/UOOLVav3f6MEs9Nodut2J TbzcSjNb62Fj1SgnVAyhyOhrHklxdXcx6heJdXBlxEf7TAn096ITiatZXE2omWrQcUhl re8siiZGXoaoWcjxh6bAxLHG3eVys6KVD/CGh8H6JYy9QumLqLBZXf7amri0GyJGAPha dOxj4VbTfTyr4AbK76hkkE0DQqlHjDIS+ZfM/6mupLtvzGHPauKFtY3yJwwhccmKrDLx ura0b3czeI2DLoTD5WxJB6yFe2Y55TwzWI0jJkxYNPZY5E42Q6LzdAu0tx/5lqq4Mmk0 voew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d4-v6si2205301pgl.147.2018.09.05.08.55.53; Wed, 05 Sep 2018 08:56:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727672AbeIEUZb (ORCPT + 99 others); Wed, 5 Sep 2018 16:25:31 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:36964 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726189AbeIEUZa (ORCPT ); Wed, 5 Sep 2018 16:25:30 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 75E2740241C3; Wed, 5 Sep 2018 15:54:42 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-123-84.rdu2.redhat.com [10.10.123.84]) by smtp.corp.redhat.com (Postfix) with ESMTP id 604FA202706C; Wed, 5 Sep 2018 15:54:41 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 Subject: [PATCH 01/11] UAPI: drm: Fix use of C++ keywords as structural members From: David Howells To: linux-api@vger.kernel.org, linux-kbuild@vger.kernel.org Cc: Rob Clark , David Airlie , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, dhowells@redhat.com Date: Wed, 05 Sep 2018 16:54:40 +0100 Message-ID: <153616288089.23468.4502511671693917281.stgit@warthog.procyon.org.uk> In-Reply-To: <153616286704.23468.584491117180383924.stgit@warthog.procyon.org.uk> References: <153616286704.23468.584491117180383924.stgit@warthog.procyon.org.uk> User-Agent: StGit/unknown-version MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Wed, 05 Sep 2018 15:54:42 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Wed, 05 Sep 2018 15:54:42 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'dhowells@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The i810 and msm drm drivers use C++ keywords as structural members. Fix this by inserting an anonymous union that provides an alternative name and then hide the reserved name in C++. Signed-off-by: David Howells cc: Rob Clark cc: David Airlie cc: linux-arm-msm@vger.kernel.org cc: dri-devel@lists.freedesktop.org cc: freedreno@lists.freedesktop.org --- include/uapi/drm/i810_drm.h | 7 ++++++- include/uapi/drm/msm_drm.h | 7 ++++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/include/uapi/drm/i810_drm.h b/include/uapi/drm/i810_drm.h index d285d5e72e6a..617d79ec3fc5 100644 --- a/include/uapi/drm/i810_drm.h +++ b/include/uapi/drm/i810_drm.h @@ -266,7 +266,12 @@ typedef struct _drm_i810_copy_t { #define PR_MASK (0x7<<18) typedef struct drm_i810_dma { - void *virtual; + union { +#ifndef __cplusplus + void *virtual; +#endif + void *_virtual; + }; int request_idx; int request_size; int granted; diff --git a/include/uapi/drm/msm_drm.h b/include/uapi/drm/msm_drm.h index c06d0a5bdd80..e99bab72d58c 100644 --- a/include/uapi/drm/msm_drm.h +++ b/include/uapi/drm/msm_drm.h @@ -148,7 +148,12 @@ struct drm_msm_gem_cpu_fini { */ struct drm_msm_gem_submit_reloc { __u32 submit_offset; /* in, offset from submit_bo */ - __u32 or; /* in, value OR'd with result */ + union { +#ifndef __cplusplus + __u32 or; /* in, value OR'd with result */ +#endif + __u32 _or; /* in, value OR'd with result */ + }; __s32 shift; /* in, amount of left shift (can be negative) */ __u32 reloc_idx; /* in, index of reloc_bo buffer */ __u64 reloc_offset; /* in, offset from start of reloc_bo */