Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp4076071imm; Wed, 5 Sep 2018 10:17:03 -0700 (PDT) X-Google-Smtp-Source: ANB0Vda8eMB/cHnjDMeKq6Yj1+RhKq+n0ySlCdhgtJwtCMV4JhHeyNuqIBUsJAYiP79//X3FEY0w X-Received: by 2002:a63:be4a:: with SMTP id g10-v6mr37790737pgo.378.1536167822970; Wed, 05 Sep 2018 10:17:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536167822; cv=none; d=google.com; s=arc-20160816; b=aaVUdgi+VOS0iADNZrltjHHPnRWXzBps0noQwLBoana9LOUjGxdpfMSupMW1r6Vd5+ BzZ8UPgal9HwdmzTyHmdNPrBSsb6uhmiBBQMlRRWhnl2pDOCzETaF1HKf0Z9D8olUd/n sqRJTh1ilveeVrfrrDIQYCLRtrD87tG/GAmFUOhAMT5L9JWy50jFItlr/oomM0vpcI6A MgBh0xitJayuZnXBUkFUylwvkcMoxcVqGAs4kHw4qZi6ShomVlmkuU6lBdVVKQSql5fF Vo8iFYm92l34/Og/ZIK+Qa5ZGVjoZWpeFS71HN8IVFvhQr9UT8YXKsnkQHAJRC4O8IJ9 OP5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=qFodOkxJoIRBUK0avb++T5XRDW3E3h+YFVH4SKC74UA=; b=WwBSnV+9YRF6DJKcBfOuhtCilxMIpo4ZFCp0AlukzIdoYFQz8v4QF5F0alORH4Blgr GOkolK0Il860Wqu00dXNDxjqIPUrK/gNKYISt7Ms7bEJBhBcUv4wtShGtXhU5O9Sg1w0 nafKtd24RhHn3R+GYiG10U3Ci2/90JZd0DRMRr7b9ZOsfb2gWDyxnZyB3Jc29DJzBPS5 b7g0dqDre8griq+xRTMLNiF059twPkDOlb7tPsgUUNxin+2WpkLQ/jSbn3jxLsLeteJF Hf65RaqhnDvAVbEmc7e1+2lkgG8tB3mK6zYrQ+EIRuyzTQNkjzfGFg2xpWlfQ8ls2Yyr qF+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=X4ifS9yf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y7-v6si2300966pgp.551.2018.09.05.10.16.47; Wed, 05 Sep 2018 10:17:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=X4ifS9yf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727685AbeIEVqT (ORCPT + 99 others); Wed, 5 Sep 2018 17:46:19 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:42869 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726046AbeIEVqT (ORCPT ); Wed, 5 Sep 2018 17:46:19 -0400 Received: by mail-lf1-f66.google.com with SMTP id z11-v6so6633654lff.9; Wed, 05 Sep 2018 10:15:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qFodOkxJoIRBUK0avb++T5XRDW3E3h+YFVH4SKC74UA=; b=X4ifS9yfpuU4EFCJAyxv//ZMhdL4dvSamSDDQcwX+IP/ycQ0atyenXyPZ+DY5ojsos 3XXX/g+3K8s9GtbGtK93C1F1+8a13e4Zwo1upUXGHesBz49c+2tTO/XkqUFzd4mnW4Xz tSD2JyhX8LK0Z7WY1UJptbgBF7hmVRkMD/tytJtzXYgbkRVN11b8tpQxVh0+/rSRlaO2 slTOgffGzsK8Frx3VullsZVlRqOQYNYsumfNitid9pOEu79XTGTHzkUhEE/GzIdV2+v5 CqnKcR5j6ZGvd5mSd871oHUxTlp367P1uMC3bRXBef1MhNCcYyfKXCOxus7MRc7ND+eP cLGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qFodOkxJoIRBUK0avb++T5XRDW3E3h+YFVH4SKC74UA=; b=cVOG/odlh8apwf/pwfOQomiWFLnChQbogHFYqZ27RXT+gZgJiClkBYm//WUIhE+K1s eIXoafstUgF+K2i9Gxa+23Cb8nMeMCEp6NbFg+MzHwvjulJp7RNg1dPg/K0gSqDz0ert RaIkciCDVGvr/Q395PBeKvBSiD9dkOobCnxqkvgTd4xhTPPrtAoW5QzQM7f4z82Zt7bH YIofENl/swzSl+Bt6L49i4RrA7iVv+w31OdlnpVPrfWYieosHMbWRwFr499agAAd7Ao0 1jtU0iSjjcPj7WLlDXbe0/geeK0er5F/+Jost5KiUErYU6XkfDpG24b94ItHUFSyFnqt H7BA== X-Gm-Message-State: APzg51BP3BVhaXPQykKSaEPX9Hu/IFIo1/W7H7GtTp+HaeRMOQTNVY2Y V5D1BV6q80g4RnGIEJPWQaZszXikXYTKqM/t8SY= X-Received: by 2002:a19:2a91:: with SMTP id q17-v6mr25208373lfq.74.1536167710790; Wed, 05 Sep 2018 10:15:10 -0700 (PDT) MIME-Version: 1.0 References: <20180902064601.183036-1-alexander.levin@microsoft.com> <20180902064601.183036-94-alexander.levin@microsoft.com> In-Reply-To: <20180902064601.183036-94-alexander.levin@microsoft.com> From: Dmitry Torokhov Date: Wed, 5 Sep 2018 10:14:59 -0700 Message-ID: Subject: Re: [PATCH AUTOSEL 4.18 094/131] Input: atmel_mxt_ts - only use first T9 instance To: Alexander.Levin@microsoft.com Cc: "3.8+" , lkml , Nick Dyer Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 2, 2018 at 6:05 AM Sasha Levin wrote: > > From: Nick Dyer > > [ Upstream commit 36f5d9ef26e52edff046b4b097855db89bf0cd4a ] > > The driver only registers one input device, which uses the screen > parameters from the first T9 instance. The first T63 instance also uses > those parameters. > > It is incorrect to send input reports from the second instances of these > objects if they are enabled: the input scaling will be wrong and the > positions will be mashed together. > > This also causes problems on Android if the number of slots exceeds 32. > > In the future, this could be handled by looking for enabled touch object > instances and creating an input device for each one. So if this is proposed for stable, how many devices are actually affected by this? Why does this need to be in stable? Thanks. -- Dmitry