Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp4098305imm; Wed, 5 Sep 2018 10:38:59 -0700 (PDT) X-Google-Smtp-Source: ANB0VdaTchNV8evDFv7hlVnXKCHi82vUEMvqO6df+CfbmTaPzXTy6YSN64RegXUpixMokarKXXg3 X-Received: by 2002:a62:9042:: with SMTP id a63-v6mr41499894pfe.52.1536169139475; Wed, 05 Sep 2018 10:38:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536169139; cv=none; d=google.com; s=arc-20160816; b=FnFcECcVqALWFI3wRlShaQjHoqPhZjeWdBG1WcwkpLpQHqlzmEk9srtm4YSeBnVOig KSszieXm+5J5cIIH0j2kF1voSfhNJuzX4RQ4VSVb3NZXBQhSPiHdQgiEQ2Fjhdlr2Qat KUohS1QzXvkWTACc6a8zRTMXY9RdE3rh6oM98BG28IEknvbwu9C4+CU8DXsXdhOo2oQP yFP+1BcTJ1edH92uQVyVVPWYhziQg5E4tUtJH3RxajdtRO2vZH+0D+Mk3dyUXrb2LR7T +D1ntEa077UdeEzdZNY9hgt8XK9Xyt+QJDKxLMvCzv66fnVlXpB1sWjazR6hGYL4SUUM MTGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=BvyYXBr9qfVcz6DP1D7x3/7rpPM2d1ycecQcwvfqdCQ=; b=w1nMwGuCdyk2BBpEbHPYYvND+oYH/lF8p4qGA8x6lc9HxmxWdXncE/YqDqJqD0vWKu Adwxz6y9hdhppPjYOrflxooNsymIvGEksv/HuUZKskgmNyZjJ4SjMHZRYG5gKsQLyiQb 4d2OTdc5D1KimFD3LsCbKE4LRMQTHufdUgPSt8iKIY8P+LixB/FA+q8ovOT3BU6za1Tt CXFFS8HF7QPd6gHiN3B8XrN4FnIFqQ07EgcocelPOiHCuWQi5RjuKP9T12woMscoS94A JVsQL/R58w9ZnskOPe4HGkSPndh9domDoUs3+rgwQxoTvJKhYbzb/lyyQu1wOQSnwRuN ocPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=WHKygGGM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o20-v6si2388035pgh.319.2018.09.05.10.38.44; Wed, 05 Sep 2018 10:38:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=WHKygGGM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727675AbeIEWIV (ORCPT + 99 others); Wed, 5 Sep 2018 18:08:21 -0400 Received: from mail-qt0-f178.google.com ([209.85.216.178]:35662 "EHLO mail-qt0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726497AbeIEWIV (ORCPT ); Wed, 5 Sep 2018 18:08:21 -0400 Received: by mail-qt0-f178.google.com with SMTP id j7-v6so9078106qtp.2; Wed, 05 Sep 2018 10:37:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BvyYXBr9qfVcz6DP1D7x3/7rpPM2d1ycecQcwvfqdCQ=; b=WHKygGGM8q4kWeWBhMJSi+8ja7zimFU/9GnnzHrJHm+PMX4u0hMtcmcZjezpvqDfcp Cr4vLzGg6T9wIkgoObNl745bXv1+T/OtkztYi6VnoyE+eokHrnyF4iq11p0H51n/Pzzz iJVzL2S47u+jRZ81ZHuoUdNUdJuwdelt2nVg6P26lPyfoLi4+kVnIzvUJVWHSFFxxyL3 90zRYKw2zs2Y6qZAmlxDYKpDEVcQasJ1w9WsuFJ5O86xDlTAkbs8j8PRCiTGs0C5t04T /jqLW2b1+mZ5WV3UpgoJKnaJ+vLxfl9OU2CmDXypA4Z6Wgp73jkMTNsBDuFwp5jb4KWg Zg5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BvyYXBr9qfVcz6DP1D7x3/7rpPM2d1ycecQcwvfqdCQ=; b=FqjFyT1N0MEqv/zhyoqYsD3BZgi1E2rR309ZOUyRNEPOqWlR/+8u9ngPIsXgVx7z6d C6lZygpsIJZAQsFSQJxzpMDL2M428zjBQhQGM5K6rP2xAf+OGasLoHG008iclQppgKQV pH6LkWNXMjZ72hoKoMGLZhPf4vku0GfGzDLdzcnh8q5eCBns8PMnC20O9Io5o7dteX6I vOoBA+efvNm2vcbhRJBOGOt0uX+5EkR4APfjJ7pa/Z2ZK/8Sjq0W9zd8a4Efff+z6XGm 0orgO2pbTbzOwb2306lN4dSNrF+qw3U4CL+vmba1VaKtzt+ZIVy00gVuBrigCXfjRFtj gkCw== X-Gm-Message-State: APzg51Ck1KehBH4OUS8EcJ8pioJ9KYfuTTNJG0ohdhjzj/QKhz2FucUu fVv0ylh7gT3Vlv1WTPtvz5tnoWvjlU6EOrnVLIs= X-Received: by 2002:a0c:c13c:: with SMTP id f57-v6mr34739474qvh.7.1536169029697; Wed, 05 Sep 2018 10:37:09 -0700 (PDT) MIME-Version: 1.0 References: <20180827185507.17087-1-jarkko.sakkinen@linux.intel.com> <20180827185507.17087-12-jarkko.sakkinen@linux.intel.com> <20180905173355.GE11368@linux.intel.com> In-Reply-To: <20180905173355.GE11368@linux.intel.com> From: Andy Shevchenko Date: Wed, 5 Sep 2018 20:36:54 +0300 Message-ID: Subject: Re: [PATCH v13 11/13] platform/x86: Intel SGX driver To: Jarkko Sakkinen Cc: "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Platform Driver , Dave Hansen , sean.j.christopherson@intel.com, nhorman@redhat.com, npmccallum@redhat.com, linux-sgx@vger.kernel.org, serge.ayoun@intel.com, shay.katz-zamir@intel.com, suresh.b.siddha@intel.com, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Darren Hart , Andy Shevchenko , Herbert Xu , Eric Biggers , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 5, 2018 at 8:34 PM Jarkko Sakkinen wrote: > On Tue, Sep 04, 2018 at 08:59:58PM +0300, Andy Shevchenko wrote: > > On Mon, Aug 27, 2018 at 9:58 PM Jarkko Sakkinen > > wrote: > Thanks, very detailed! Does not make sense to ack these separately so I > just say that I try to fix them all with care. Just comment on which you disagree. I think one of them is the header file location. It seems I missed it's current place. -- With Best Regards, Andy Shevchenko