Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp4141471imm; Wed, 5 Sep 2018 11:22:17 -0700 (PDT) X-Google-Smtp-Source: ANB0Vda9kwsoCeHl1y9kTjZouf3qGk4qX6H4T86TzJFP9cXaYoQGt5vGA5qlznIr2dn9iB6SQImL X-Received: by 2002:a17:902:25ab:: with SMTP id y40-v6mr39405582pla.120.1536171737669; Wed, 05 Sep 2018 11:22:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536171737; cv=none; d=google.com; s=arc-20160816; b=jvt0qlWo7ygoNeS1tldNURGyU7xdf+2sw69Nl293XeP2rnuRMP6wBBUmqJUrZjjyAR E70aM9TWpWAXc53gqUNEx8+KLsNdLYL0BlFJ3HyqXn8kh7a7NPPgP40t5NAhwupI7b5/ BA9eFk4jmq+vkmHFqbPzVOLddqi9DWozGfBWjwrwxP3EUygXi+yE2q7YwXip+erDPTMs bGGFbvpMcg1RPf45K/rhzBxPFFsghSWyD9FKA3EpOe8c4mUtwsDJGg5J3hS29vhtl7aa XET6fZywsHUalQYuZKfAL4vvyT54CBbffnMnmlLTOxUI2arzP07257HlvG6hTGHV+MNn wgKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=vlTvQtmVMsSrKeQj5fQabj7Oqh7/mlRwJqlggnVQtpA=; b=lLutGxxMHIKk558+T0E+UE+xEU+YMmCpwcsi18tqc08eV6TCjZinzF3ekzc7kHqHo9 33lA2gziqjcPsac4fvl1NFXJFWrSC2E/v3Ma3uJ3aUZoN8f9P+PWbDwKao9w8TOm5HJf Cg2s/sz+f/SRKEKEX7faIx3vMxtXeSNfjX7r8MXUYqqWI6tVvw88tuvLIjAvex4wbbHn Hrcwjc9hNLNwW8D0V2bMB8A6Y8bB/mJk8ffllRo992rxlJRYnqdAWVh5JGCQvZmiGBBF 1XWq4gtX2G4JD7J28lCFXKE0Bp6GjtjW+eI5FEl2p1p8zGAn19mINgyolEjNp81cl+42 QdAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=iZRG9rll; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l9-v6si2684481pfe.11.2018.09.05.11.22.02; Wed, 05 Sep 2018 11:22:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=iZRG9rll; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727593AbeIEWwF (ORCPT + 99 others); Wed, 5 Sep 2018 18:52:05 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:43040 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727201AbeIEWwF (ORCPT ); Wed, 5 Sep 2018 18:52:05 -0400 Received: by mail-wr1-f68.google.com with SMTP id k5-v6so8641624wre.10; Wed, 05 Sep 2018 11:20:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vlTvQtmVMsSrKeQj5fQabj7Oqh7/mlRwJqlggnVQtpA=; b=iZRG9rllYezIWFRUy0n4WZcNAQ2xYLjJCM8WxEu0Ndx+GUfhnx9p+FC+b7PZ+CTcWn 9aw+nDV7pjWl/wINXtC5XdLJj7oSvbEZbREFUFb25RL1cGPxnJtNbFycQGbYW+5YHe8Q OtFX4CxyzIjITFiZ8Ds96uW5XmjtlD21ZbnvlUJ0PumXjOOs8/9Meky4Fxo+N0CJSvJH khcRptsbKbgS1sdfGWzkUAPoJSUy6+X214qScTEmqPQV3nlBbq+5Gy/3aJw0C88cMJb4 gLVMWJn9qFSWPceKq0GNr840RChgepZGHPvpKvL6d2/8b2wOMY+VbN1tNWTMv5YXM0F2 2rAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vlTvQtmVMsSrKeQj5fQabj7Oqh7/mlRwJqlggnVQtpA=; b=GZTeQ22BW8yJJNz/pTN6ALH+Qohc9b6IBcrWCOKtQ4hBT4i/m53AI95sioxpBmG74R +pdNZxz3bn/9qt3VmlZZ0p+NOWFEy+0nrOdgk9hKsqbBh3fst9wK+WSxFrhNepyH/Va7 rF0rAlIOQLeQDZhqIxkpykO0yOx1OrIHAcN6GFJl7Ib7yfUWf0oZ7zEh8mk3HUmoTyzv BMQvZ56Jq6TtUzNXDPXexFGlS6kXielqmCliq2/0e1PL7X16gxGfsHn4LkEAJhe1HX2U ZOoL3xKOInp60amNUYNwIPqkyZSVlnazjzi5q82Iz8+PL8UI6ZXZpR9yaK4XxIBW2KC+ vwwA== X-Gm-Message-State: APzg51AYtthhDw02RwoawHmX5f2f40cW76o09OwTdm8cO2PvdQAZhNIu DT1tVTuwQTnxlJs9yb/k9d4= X-Received: by 2002:adf:8103:: with SMTP id 3-v6mr27356739wrm.213.1536171643430; Wed, 05 Sep 2018 11:20:43 -0700 (PDT) Received: from ltop.local ([2a02:a03f:4006:df00:b45a:4246:cb70:58f7]) by smtp.gmail.com with ESMTPSA id h8-v6sm3691332wre.15.2018.09.05.11.20.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Sep 2018 11:20:42 -0700 (PDT) Date: Wed, 5 Sep 2018 20:20:39 +0200 From: Luc Van Oostenryck To: Miguel Ojeda Cc: Linus Torvalds , linux-kernel@vger.kernel.org, Rasmus Villemoes , Eli Friedman , Christopher Li , Kees Cook , Ingo Molnar , Geert Uytterhoeven , Arnd Bergmann , Greg Kroah-Hartman , Masahiro Yamada , Joe Perches , Dominique Martinet , linux-sparse@vger.kernel.org Subject: Re: [PATCH 07/12] Compiler Attributes: remove unneeded sparse (__CHECKER__) tests Message-ID: <20180905182038.muv535vfugm72spk@ltop.local> References: <20180903203316.16183-1-miguel.ojeda.sandonis@gmail.com> <20180903203316.16183-8-miguel.ojeda.sandonis@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180903203316.16183-8-miguel.ojeda.sandonis@gmail.com> User-Agent: NeoMutt/20180622 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 03, 2018 at 10:33:11PM +0200, Miguel Ojeda wrote: > Sparse knows about a few more attributes now, so we can remove > the __CHECKER__ conditions from them (which, in turn, allow us > to move some of them later on to compiler_attributes.h). > > * assume_aligned: since sparse's commit ffc860b ("sparse: > ignore __assume_aligned__ attribute"), included in 0.5.1 > > * error: since sparse's commit 0a04210 ("sparse: Add 'error' > to ignored attributes"), included in 0.5.0 > > * hotpatch: since sparse's commit 6043210 ("sparse/parse.c: > ignore hotpatch attribute"), included in 0.5.1 > > * warning: since sparse's commit 977365d ("Avoid "attribute > 'warning': unknown attribute" warning"), included in 0.4.2 Hi, I hadn't noticed in the previous version but I see now that hotpatch & assume_aligned is only available since sparse 0.5.1 which is only 13 months old. It would be great if everyone use a recent version but I fear that a lot of people still use something less recent. v0.5.0 should be OK, though, it's more than 5 years old. Sorry for not having noticed this earlier. -- Luc