Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp4173597imm; Wed, 5 Sep 2018 11:56:16 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdb6x+x01kDq0b5MjueXgKtHPYs921gMhmW7ubSlDWpG7yGcUOGmFll0Q0KVjgDmzthl2fH4 X-Received: by 2002:a63:ba1c:: with SMTP id k28-v6mr37600077pgf.76.1536173775925; Wed, 05 Sep 2018 11:56:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536173775; cv=none; d=google.com; s=arc-20160816; b=WU72vlemKo/RpXqxuw+k6sv95K0/jJmlxvrWB4tE0eoK9HFMDSRFaBVY+s6FwrIuJQ idVr+qqE1RhmTVVcphjvGySk6N43oPATsFBs/ZwOEZnUjHF8vyg6nfIZUgr+89a9Du8c yUyhrLawHR4UXH7oXRJRuyln7WY4x9wmFg+vnKD8VuPRSmYDqHPog5k9A5ifn+N2ab92 0SZ58jyiQXo9dpPfnGkFUE3S8xt2UPu5KQb8/XsWnmI/TOr444uqbgobb6g4YfYNqaAM 3lQx3H5uD6TZVXEL1sd/LkUIKC4pwsJnGpDozOKa282oqRT5I2V5jSUWm+1yrxnCB/A9 t4tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=L40QfUfqELILge77L2Oi58OVOgVXdMv16buiRzoMXJ4=; b=KLIcXsBlKRvwGSgj32gFjF5+taCHT+NY6CY58DhOMYj/Ysu71bXBOpEcvrCMwTdZs6 yL5aONvxlv+zubICt0ehbzmh5eu684wgGwuLhSrqd3BhaZ+Kw+4+7Z93/4Pduir65msg BDk2USyQyE0e1BCIF2Q4A0YuSNMxdi03xgU+zcbDqbbgiDhppEbh/81wVz9rKxKyvDG2 C9M3zIK388wz2ercYJqxl2ggAmcyQZjlNsdfVEAYnZVa1r5fXvR11BYA024tKhypjuBm 3OWa9XoAeLLe0hjE+XC/biACFkXzD67iANUKl1DctTkeU9bdHC5wiwvxFhJNKmKVQetQ /KJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=TGNx2Jp2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s20-v6si2745658pgk.87.2018.09.05.11.56.00; Wed, 05 Sep 2018 11:56:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=TGNx2Jp2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727611AbeIEX0C (ORCPT + 99 others); Wed, 5 Sep 2018 19:26:02 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:43266 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726487AbeIEX0C (ORCPT ); Wed, 5 Sep 2018 19:26:02 -0400 Received: by mail-lf1-f66.google.com with SMTP id h64-v6so6896247lfi.10; Wed, 05 Sep 2018 11:54:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=L40QfUfqELILge77L2Oi58OVOgVXdMv16buiRzoMXJ4=; b=TGNx2Jp2yqfrFAJUb5JPmzQuF9fru33a5k/BWR6zhA3k7/cC7xvOEQK2EhE7EUV5yj alyBPO/7/aoHRevXXNQG8VqBA1GTt6VAcRr7GRxgR+S8KfOLBs90RG1oUf5uluB1j2cM OVw638fG9YaEk2v68HgpOSKEzQ7+rxn7aiEBYtqCwLLZDTK7oS6zc/EPVovZ1rSmHQOC UnjO/DiqX1xKRfchlSvKAtzeT6Oeu2bObvk6718Uy2/ZIZpgw5W60PlZBkSfdw54QkP8 bLx4WhdkuY9PIWE6TC/QZRMSrZZA2Hznywgz76x9fzXmmkDfYh8q5j61e5AOGeRL7uTh 2w4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=L40QfUfqELILge77L2Oi58OVOgVXdMv16buiRzoMXJ4=; b=cdcM7jQpsfatnPKRwP/8OXtKrNcETrklfGnbSqyA5qdetDrjxaFPOisUWgmkSYuwDP +ivLuyqwV/GsW2yZ/YklK4+ozmPifq5vpVpS5DC045p6O+duLEl9KRv1T5X5YICz3JK1 VUZ9thqW4rI3vxrH9IHz3/sqafmNVDKQ99brn30F5lS0asLSIYRCcNlZDx1xlRGLs73X KxqpEXnd1hdexVxhabJjEdzCJI2HdU24TRqt5rDfxEjULDWE32/Y9GyhCtiy0mdNHZ3E r5wuPDPaL8FteonfcUnnMBnBExpzBl1Sip0qu0STUpBqjM9wB7CDBGqfhmUEp3RU2FE+ Ztkg== X-Gm-Message-State: APzg51D1/HJPcL8HppoS1jAtqqGzcN9y2wd/iNhlcDxV+Hldvzsxy0/j tFfGtH0CrPZJed1clbAtnuiRg348 X-Received: by 2002:a19:db94:: with SMTP id t20-v6mr24197473lfi.126.1536173672742; Wed, 05 Sep 2018 11:54:32 -0700 (PDT) Received: from [192.168.10.160] (91-159-62-202.elisa-laajakaista.fi. [91.159.62.202]) by smtp.gmail.com with ESMTPSA id 6-v6sm439233lfv.36.2018.09.05.11.54.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Sep 2018 11:54:32 -0700 (PDT) Subject: Re: [PATCH] infiniband: nes: add unlikely() to assert() To: Leon Romanovsky Cc: Faisal Latif , Igor Stoppa , Chien Tung , Roland Dreier , Jason Gunthorpe , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180831192418.12346-1-igor.stoppa@huawei.com> <20180905060106.GI2977@mtr-leonro.mtl.com> From: Igor Stoppa Message-ID: <62351491-66cb-0541-85e4-481251433a19@gmail.com> Date: Wed, 5 Sep 2018 21:54:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180905060106.GI2977@mtr-leonro.mtl.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/09/18 09:01, Leon Romanovsky wrote: > On Fri, Aug 31, 2018 at 10:24:18PM +0300, Igor Stoppa wrote: >> Typically the assert is expected to not fail. > > This whole assert can be removed. ok >> >> Signed-off-by: Igor Stoppa >> Acked-by: Doug Ledford > > Most probably that I missed discussion, but anyway, does this > "Acked-by" come from internal or external discussion? https://lkml.org/lkml/2018/8/31/456 -- igor