Received: by 2002:ac0:adb2:0:0:0:0:0 with SMTP id o47-v6csp11534imb; Wed, 5 Sep 2018 12:39:32 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdb1qcHwWnHLj4cmJBJp3WVyWvjfGhVBXi1ZQ/ZTgbl0QFce725G0LTe91rkODkgK9o0+bg8 X-Received: by 2002:a17:902:7102:: with SMTP id a2-v6mr40523712pll.217.1536176372127; Wed, 05 Sep 2018 12:39:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536176372; cv=none; d=google.com; s=arc-20160816; b=Uq+zmHmw9ekG721zshk5GVZOcL99FFFzaGntjmiTvitHpkCSKEU2slzHKNU1pRQX2I wJgrAqI9h2ZmZQS+zZSEpcd1pDVbEXdyYDQPuTh/ictSfX9xKR5EehaGtcVO7KaK9pm3 my2/m5bAC2zqzyrN9HzuV4pFX4l3DFFQtT66AvwubP26UUKH5GSygwdGS2S4U34fyb6i qc6XNfVGWpoRDB6S3+O7pCPPx2Kz9LzBbdSW24YexegreZ3mrP7s/Ns+yvTI1YusDb7j btj7NsIgWG5BrWS6Q7AduOlzh/SJJHW3qmQauYuxcEJzolvn25szM3dcg/1j8yPcJrf1 Jy+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=/tHIj8M2GngKk2DgJXEcotoqfmP004BFGBxFORRWufc=; b=weiOB1hQCiQ2xKY4nS/jnQgJJ3/+EPfsuYJ6hIPXBBCdjnRgB4IgMstf9MmeVxfZMY 70qrVhQapsVcI66aopIg/OH4u9ZYsVen6tdavJ+SiKCFC4G5jL/qV5snUIVKgVRR3Q23 9yS2BmbzE502KVN3QLvPVbfr4wjs8RKhvSp3p+06sfTu3rf0JaLhEI8Awx+388Ii7CFH 8YHdZdeZ7zPpgKID9ewBQcx1MlyC+hdYA4aARufZgsAPezgvJO5Q8+hym+xlhAZ9uQgS YARFDd/ABqDLWnOXItWZSJDslZOW0+iWEJ7F+ma+qcJCg0zEXonHmFkRhX5FdrIPTTvx 6fZg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m1-v6si2600113plb.348.2018.09.05.12.39.16; Wed, 05 Sep 2018 12:39:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728140AbeIFAJc (ORCPT + 99 others); Wed, 5 Sep 2018 20:09:32 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:42542 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728113AbeIFAJb (ORCPT ); Wed, 5 Sep 2018 20:09:31 -0400 Received: by mail-oi0-f65.google.com with SMTP id k81-v6so15915171oib.9; Wed, 05 Sep 2018 12:37:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/tHIj8M2GngKk2DgJXEcotoqfmP004BFGBxFORRWufc=; b=A8ncbPeMa5q0twPS4vxs/9dRQXtfnmr7HwId/KhhclZ5jL75GkjLCHvyoI4wCa4yl/ X0V66I20AM2J5ReGGanoa7IlMbX1DVLiytOhL2qOlRQtl/IEC9yubziSk1stWK3hprM9 ICC9Dq7dajMSQ1gYkuzwtcHKs/dgTk01sn0RsOUthYxUwz+4HxEMUmSs65zAP4O5aSD+ BiVd2OCBj4EN1l/mn3pKrQCHG6j9lvWfp+B3hMk5SiDUDVjGehlwTkers7uwTOrXKgsP DjLVBD6mNGYEs5NkgQfNh+zowBsmKWLwPCLe9Kbmxt2hV209Pf8lDDqZNdfTiJz+3Nsd F4jg== X-Gm-Message-State: APzg51DGBCHTxW0MrPG2rG3BoXIOrkGjM0SFiY+8Ia90jviJKkjGAUvP vOpzegBeyKck56bZlVlp2Z3U/0c= X-Received: by 2002:aca:5841:: with SMTP id m62-v6mr30375846oib.346.1536176272343; Wed, 05 Sep 2018 12:37:52 -0700 (PDT) Received: from xps15.herring.priv (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.googlemail.com with ESMTPSA id u21-v6sm2296053oie.22.2018.09.05.12.37.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Sep 2018 12:37:51 -0700 (PDT) From: Rob Herring To: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linuxppc-dev@lists.ozlabs.org Subject: [PATCH 11/21] powerpc: use for_each_of_cpu_node iterator Date: Wed, 5 Sep 2018 14:37:28 -0500 Message-Id: <20180905193738.19325-12-robh@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180905193738.19325-1-robh@kernel.org> References: <20180905193738.19325-1-robh@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the for_each_of_cpu_node iterator to iterate over cpu nodes. This has the side effect of defaulting to iterating using "cpu" node names in preference to the deprecated (for FDT) device_type == "cpu". Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Rob Herring --- Please ack and I will take via the DT tree. This is dependent on the first 2 patches. arch/powerpc/platforms/powermac/feature.c | 51 ++++++++--------------- arch/powerpc/platforms/powermac/setup.c | 15 +++---- 2 files changed, 26 insertions(+), 40 deletions(-) diff --git a/arch/powerpc/platforms/powermac/feature.c b/arch/powerpc/platforms/powermac/feature.c index 4eb8cb38fc69..ed2f54b3f173 100644 --- a/arch/powerpc/platforms/powermac/feature.c +++ b/arch/powerpc/platforms/powermac/feature.c @@ -1049,7 +1049,6 @@ core99_reset_cpu(struct device_node *node, long param, long value) unsigned long flags; struct macio_chip *macio; struct device_node *np; - struct device_node *cpus; const int dflt_reset_lines[] = { KL_GPIO_RESET_CPU0, KL_GPIO_RESET_CPU1, KL_GPIO_RESET_CPU2, @@ -1059,10 +1058,7 @@ core99_reset_cpu(struct device_node *node, long param, long value) if (macio->type != macio_keylargo) return -ENODEV; - cpus = of_find_node_by_path("/cpus"); - if (cpus == NULL) - return -ENODEV; - for (np = cpus->child; np != NULL; np = np->sibling) { + for_each_of_cpu_node(np) { const u32 *num = of_get_property(np, "reg", NULL); const u32 *rst = of_get_property(np, "soft-reset", NULL); if (num == NULL || rst == NULL) @@ -1072,7 +1068,6 @@ core99_reset_cpu(struct device_node *node, long param, long value) break; } } - of_node_put(cpus); if (np == NULL || reset_io == 0) reset_io = dflt_reset_lines[param]; @@ -1504,16 +1499,12 @@ static long g5_reset_cpu(struct device_node *node, long param, long value) unsigned long flags; struct macio_chip *macio; struct device_node *np; - struct device_node *cpus; macio = &macio_chips[0]; if (macio->type != macio_keylargo2 && macio->type != macio_shasta) return -ENODEV; - cpus = of_find_node_by_path("/cpus"); - if (cpus == NULL) - return -ENODEV; - for (np = cpus->child; np != NULL; np = np->sibling) { + for_each_of_cpu_node(np) { const u32 *num = of_get_property(np, "reg", NULL); const u32 *rst = of_get_property(np, "soft-reset", NULL); if (num == NULL || rst == NULL) @@ -1523,7 +1514,6 @@ static long g5_reset_cpu(struct device_node *node, long param, long value) break; } } - of_node_put(cpus); if (np == NULL || reset_io == 0) return -ENODEV; @@ -2515,31 +2505,26 @@ static int __init probe_motherboard(void) * supposed to be set when not supported, but I'm not very confident * that all Apple OF revs did it properly, I do it the paranoid way. */ - while (uninorth_base && uninorth_rev > 3) { - struct device_node *cpus = of_find_node_by_path("/cpus"); + if (uninorth_base && uninorth_rev > 3) { struct device_node *np; - if (!cpus || !cpus->child) { - printk(KERN_WARNING "Can't find CPU(s) in device tree !\n"); - of_node_put(cpus); - break; - } - np = cpus->child; - /* Nap mode not supported on SMP */ - if (np->sibling) { - of_node_put(cpus); - break; - } - /* Nap mode not supported if flush-on-lock property is present */ - if (of_get_property(np, "flush-on-lock", NULL)) { - of_node_put(cpus); - break; + for_each_of_cpu_node(np) { + int cpu_count = 1; + + /* Nap mode not supported on SMP */ + if (of_get_property(np, "flush-on-lock", NULL) || + (cpu_count > 1)) { + powersave_nap = 0; + of_node_put(np); + break; + } + + cpu_count++; + powersave_nap = 1; } - of_node_put(cpus); - powersave_nap = 1; - printk(KERN_DEBUG "Processor NAP mode on idle enabled.\n"); - break; } + if (powersave_nap) + printk(KERN_DEBUG "Processor NAP mode on idle enabled.\n"); /* On CPUs that support it (750FX), lowspeed by default during * NAP mode diff --git a/arch/powerpc/platforms/powermac/setup.c b/arch/powerpc/platforms/powermac/setup.c index 3a529fcdae97..2f00e3daafb0 100644 --- a/arch/powerpc/platforms/powermac/setup.c +++ b/arch/powerpc/platforms/powermac/setup.c @@ -243,10 +243,9 @@ static void __init l2cr_init(void) { /* Checks "l2cr-value" property in the registry */ if (cpu_has_feature(CPU_FTR_L2CR)) { - struct device_node *np = of_find_node_by_name(NULL, "cpus"); - if (!np) - np = of_find_node_by_type(NULL, "cpu"); - if (np) { + struct device_node *np; + + for_each_of_cpu_node(np) { const unsigned int *l2cr = of_get_property(np, "l2cr-value", NULL); if (l2cr) { @@ -256,6 +255,7 @@ static void __init l2cr_init(void) _set_L2CR(ppc_override_l2cr_value); } of_node_put(np); + break; } } @@ -279,8 +279,8 @@ static void __init pmac_setup_arch(void) /* Set loops_per_jiffy to a half-way reasonable value, for use until calibrate_delay gets called. */ loops_per_jiffy = 50000000 / HZ; - cpu = of_find_node_by_type(NULL, "cpu"); - if (cpu != NULL) { + + for_each_of_cpu_node(cpu) { fp = of_get_property(cpu, "clock-frequency", NULL); if (fp != NULL) { if (pvr >= 0x30 && pvr < 0x80) @@ -292,8 +292,9 @@ static void __init pmac_setup_arch(void) else /* 601, 603, etc. */ loops_per_jiffy = *fp / (2 * HZ); + of_node_put(cpu); + break; } - of_node_put(cpu); } /* See if newworld or oldworld */ -- 2.17.1