Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp39870imm; Wed, 5 Sep 2018 13:20:55 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdb3g3b15DR8Celvg7fLrqJpf0KHVFTw3bsGqYRNnwqSCsukrvtmBVhcIhCkNDMuCuAOJB5j X-Received: by 2002:a62:1157:: with SMTP id z84-v6mr42508194pfi.66.1536178855691; Wed, 05 Sep 2018 13:20:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536178855; cv=none; d=google.com; s=arc-20160816; b=CQj4eMuTIBgGj49AMKO1lTwiW4TKpU8+JeAPRxDfGuYfuTJeck39cmnHql6jAscgO+ nWP2NGJ0Cb+KSahAd/G3WA/LR1CoKUzF7xJYjH6BZgnGicAMuwgFYrYxFWG4kOJ9W3p4 GiRq0yDz1zY7hAdUg88geYM7HA4HoqT9svC5+Xteo4lYJ0OqicFezkX4jSRTS/NNEhH+ h88OCDzJWAwZb8xMvERJ5fzbO11LdgKFpNwhmzrf5qMluMGI8cvoaXpELXkDhavjZFGb V5pHV3lel2opjXD5n1vtFQVVPScHibc79FhHTKd3P3O2Wei5sqG1z2yJm0WWYlHvOEg+ kEqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to; bh=YDyN38piu7yfn0tnVOdhjNYELlhnW9xKqhzSXLF8EIk=; b=BhVNq8s8dASMTEdaFKI3rsMwv1cME+Xiprl1nEdLe4QjxeM/Gd8+2bpyiQdesQfVH4 plx0iEtS2pmcdVytqiS5W3fZtgxrWbhSOU/mM1oFAEq2tvGcUuTgYAALxelgoGVM3ozR t5vtTmuiuRgBHZdDNyYPZvq2zKNBS/MxQIFu1N3tmwKbmNom8Q4+C7uQfbaDe2+2d9BJ 6JWYHkJjnEy0NhMakmG8incT+um9mQn34a0dbDE3LP+L3EfXdA7ELp98Tk/JcXx/xsCj D9Xm/2z62uaKdzYmJnGHHr16i0eTveB/Pa1xqIXEeIHZgnT3Srb0bjD7PHWHmDNXi+3b ROqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a23-v6si2930344pgd.235.2018.09.05.13.20.32; Wed, 05 Sep 2018 13:20:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727854AbeIFAuI (ORCPT + 99 others); Wed, 5 Sep 2018 20:50:08 -0400 Received: from ale.deltatee.com ([207.54.116.67]:53898 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727599AbeIFAuI (ORCPT ); Wed, 5 Sep 2018 20:50:08 -0400 Received: from guinness.priv.deltatee.com ([172.16.1.162]) by ale.deltatee.com with esmtp (Exim 4.89) (envelope-from ) id 1fxeFY-0005al-7K; Wed, 05 Sep 2018 14:18:04 -0600 To: Jens Axboe , Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, linux-nvdimm@lists.01.org, linux-block@vger.kernel.org, Stephen Bates , Keith Busch , Sagi Grimberg , Bjorn Helgaas , Jason Gunthorpe , Max Gurtovoy , Dan Williams , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Benjamin Herrenschmidt , Alex Williamson , =?UTF-8?Q?Christian_K=c3=b6nig?= References: <20180830185352.3369-1-logang@deltatee.com> <20180830185352.3369-8-logang@deltatee.com> <20180901082812.GB670@lst.de> <5f79c012-c6e1-56bb-62fd-0689181fb2c9@deltatee.com> <59b28977-8f2a-6228-2050-03fae6bdbedd@kernel.dk> <1b4283da-44df-4a02-3167-e295243cef78@deltatee.com> <09258b9b-3aed-9890-b31a-bd70a133966c@kernel.dk> <20180905195647.GA1626@lst.de> <20180905201152.GA1893@lst.de> <2a3394bd-5f13-4818-43f4-dfc61f501e05@kernel.dk> From: Logan Gunthorpe Message-ID: Date: Wed, 5 Sep 2018 14:18:03 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <2a3394bd-5f13-4818-43f4-dfc61f501e05@kernel.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: christian.koenig@amd.com, alex.williamson@redhat.com, benh@kernel.crashing.org, jglisse@redhat.com, dan.j.williams@intel.com, maxg@mellanox.com, jgg@mellanox.com, bhelgaas@google.com, sagi@grimberg.me, keith.busch@intel.com, sbates@raithlin.com, linux-block@vger.kernel.org, linux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, hch@lst.de, axboe@kernel.dk X-SA-Exim-Mail-From: logang@deltatee.com X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on ale.deltatee.com X-Spam-Level: X-Spam-Status: No, score=-8.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, GREYLIST_ISWHITE autolearn=ham autolearn_force=no version=3.4.1 Subject: Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/09/18 02:14 PM, Jens Axboe wrote: > But if the caller must absolutely know where the bio will end up, then > it seems super redundant. So I'd vote for killing this check, it buys > us absolutely nothing and isn't even exhaustive in its current form. Ok, I'll remove it for v6. Logan